From: Andrew Lunn <andrew@lunn.ch>
To: sean.wang@mediatek.com
Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com,
matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
davem@davemloft.net, Landen.Chao@mediatek.com,
keyhaede@gmail.com, objelf@gmail.com
Subject: Re: [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch
Date: Tue, 14 Mar 2017 00:11:17 +0100 [thread overview]
Message-ID: <20170313231117.GF14183@lunn.ch> (raw)
In-Reply-To: <1489421488-300-5-git-send-email-sean.wang@mediatek.com>
> +static int
> +mt7530_setup(struct dsa_switch *ds)
> +{
> + struct mt7530_priv *priv = ds->priv;
> + int ret, i, phy_mode;
> + u8 cpup_mask = 0;
> + u32 id, val;
> + struct regmap *regmap;
> +
> + /* Make sure that cpu port specfied on the dt is appropriate */
> + if (!dsa_is_cpu_port(ds, MT7530_CPU_PORT)) {
> + dev_err(priv->dev, "port not matched with the CPU port\n");
> + return -EINVAL;
> + }
> +
> + regmap = devm_regmap_init(ds->dev, NULL, priv,
> + &mt7530_regmap_config);
> + if (IS_ERR(regmap))
> + dev_warn(priv->dev, "phy regmap initialization failed");
> +
> + phy_mode = of_get_phy_mode(ds->ports[ds->dst->cpu_port].dn);
> + if (phy_mode < 0) {
> + dev_err(priv->dev, "Can't find phy-mode for master device\n");
> + return phy_mode;
> + }
> + dev_info(priv->dev, "phy-mode for master device = %x\n", phy_mode);
Hi Sean
It is not documented in the binding that a phy-mode is mandatory for
the cpu port.
Andrew
next prev parent reply other threads:[~2017-03-13 23:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 16:11 [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support sean.wang
2017-03-13 16:11 ` [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding sean.wang
2017-03-13 16:36 ` Andrew Lunn
2017-03-14 6:06 ` Sean Wang
2017-03-13 16:47 ` Florian Fainelli
2017-03-14 6:52 ` Sean Wang
2017-03-14 11:58 ` Andrew Lunn
2017-03-13 16:11 ` [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler sean.wang
2017-03-13 16:27 ` Andrew Lunn
2017-03-13 16:35 ` Florian Fainelli
2017-03-14 6:16 ` Sean Wang
2017-03-13 16:59 ` Vivien Didelot
2017-03-14 6:22 ` Sean Wang
2017-03-14 13:38 ` Vivien Didelot
2017-03-13 16:11 ` [PATCH net-next 3/4] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA sean.wang
2017-03-13 16:30 ` Andrew Lunn
2017-03-13 16:39 ` Florian Fainelli
2017-03-13 16:11 ` [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch sean.wang
2017-03-13 16:41 ` Andrew Lunn
2017-03-13 23:11 ` Andrew Lunn [this message]
2017-03-14 7:03 ` Sean Wang
2017-03-15 2:20 ` kbuild test robot
2017-03-15 2:30 ` kbuild test robot
2017-03-13 16:25 ` [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313231117.GF14183@lunn.ch \
--to=andrew@lunn.ch \
--cc=Landen.Chao@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=keyhaede@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=objelf@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).