* [PATCH] drivers/staging/dgnc: Updating dev_dbg function
@ 2017-03-22 7:47 Pushkar Jambhlekar
2017-03-23 7:23 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-22 7:47 UTC (permalink / raw)
To: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
Cc: driverdev-devel, devel, linux-kernel, Pushkar Jambhlekar
Making use of __func__ instead of using function name directly in dev_dbg.
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f7e754e..b0c88b8 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1858,13 +1858,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
if (!bd || bd->magic != DGNC_BOARD_MAGIC)
return;
- dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
+ dev_dbg(tty->dev, "%s start\n", __func__);
spin_lock_irqsave(&ch->ch_lock, flags);
bd->bd_ops->send_immediate_char(ch, c);
spin_unlock_irqrestore(&ch->ch_lock, flags);
- dev_dbg(tty->dev, "dgnc_tty_send_xchar finish\n");
+ dev_dbg(tty->dev, "%s finish\n", __func__);
}
/* Return modem signals to ld. */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/staging/dgnc: Updating dev_dbg function
2017-03-22 7:47 [PATCH] drivers/staging/dgnc: Updating dev_dbg function Pushkar Jambhlekar
@ 2017-03-23 7:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-23 7:23 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Lidza Louina, Mark Hounschell, driverdev-devel, devel, linux-kernel
On Wed, Mar 22, 2017 at 01:17:57PM +0530, Pushkar Jambhlekar wrote:
> Making use of __func__ instead of using function name directly in dev_dbg.
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index f7e754e..b0c88b8 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -1858,13 +1858,13 @@ static void dgnc_tty_send_xchar(struct tty_struct *tty, char c)
> if (!bd || bd->magic != DGNC_BOARD_MAGIC)
> return;
>
> - dev_dbg(tty->dev, "dgnc_tty_send_xchar start\n");
> + dev_dbg(tty->dev, "%s start\n", __func__);
As I stated on the mailing list a few days ago, these lines need to just
be deleted entirely, as we have ftrace to help with this type of thing.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-23 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 7:47 [PATCH] drivers/staging/dgnc: Updating dev_dbg function Pushkar Jambhlekar
2017-03-23 7:23 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).