* [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
@ 2017-03-28 8:35 Cao jin
2017-03-28 16:00 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Cao jin @ 2017-03-28 8:35 UTC (permalink / raw)
To: linux-arch, linux-kernel; +Cc: arnd, tj, cl
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
include/asm-generic/percpu.h | 4 ----
include/linux/percpu-defs.h | 4 ++--
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/include/asm-generic/percpu.h b/include/asm-generic/percpu.h
index 0504ef8..be90c3d 100644
--- a/include/asm-generic/percpu.h
+++ b/include/asm-generic/percpu.h
@@ -61,10 +61,6 @@ extern void setup_per_cpu_areas(void);
#define PER_CPU_ATTRIBUTES
#endif
-#ifndef PER_CPU_DEF_ATTRIBUTES
-#define PER_CPU_DEF_ATTRIBUTES
-#endif
-
#define raw_cpu_generic_read(pcp) \
({ \
*raw_cpu_ptr(&(pcp)); \
diff --git a/include/linux/percpu-defs.h b/include/linux/percpu-defs.h
index 8f16299..c05cc4d 100644
--- a/include/linux/percpu-defs.h
+++ b/include/linux/percpu-defs.h
@@ -91,7 +91,7 @@
extern __PCPU_DUMMY_ATTRS char __pcpu_unique_##name; \
__PCPU_DUMMY_ATTRS char __pcpu_unique_##name; \
extern __PCPU_ATTRS(sec) __typeof__(type) name; \
- __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES __weak \
+ __PCPU_ATTRS(sec) __weak \
__typeof__(type) name
#else
/*
@@ -101,7 +101,7 @@
extern __PCPU_ATTRS(sec) __typeof__(type) name
#define DEFINE_PER_CPU_SECTION(type, name, sec) \
- __PCPU_ATTRS(sec) PER_CPU_DEF_ATTRIBUTES \
+ __PCPU_ATTRS(sec) \
__typeof__(type) name
#endif
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
2017-03-28 8:35 [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin
@ 2017-03-28 16:00 ` Tejun Heo
2017-03-29 2:38 ` Cao jin
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2017-03-28 16:00 UTC (permalink / raw)
To: Cao jin; +Cc: linux-arch, linux-kernel, arnd, cl
On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
I'm not sure. I think I used it during development and it's not like
it costs anything to keep.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
2017-03-28 16:00 ` Tejun Heo
@ 2017-03-29 2:38 ` Cao jin
2017-03-29 15:28 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Cao jin @ 2017-03-29 2:38 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-arch, linux-kernel, arnd, cl
On 03/29/2017 12:00 AM, Tejun Heo wrote:
> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> I'm not sure. I think I used it during development and it's not like
> it costs anything to keep.
>
It easily confusing newbies without any comments for its purpose.
Temporary using during development seems not good to persist. Could I
know its purpose?
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
2017-03-29 2:38 ` Cao jin
@ 2017-03-29 15:28 ` Tejun Heo
2017-03-30 3:34 ` Cao jin
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2017-03-29 15:28 UTC (permalink / raw)
To: Cao jin; +Cc: linux-arch, linux-kernel, arnd, cl
On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote:
> On 03/29/2017 12:00 AM, Tejun Heo wrote:
> > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> >
> > I'm not sure. I think I used it during development and it's not like
> > it costs anything to keep.
>
> It easily confusing newbies without any comments for its purpose.
percpu variable handling is pretty complex to begin with. I don't buy
that an empty default attribute macro adds anything noticeable there.
> Temporary using during development seems not good to persist. Could I
> know its purpose?
I don't remember the exact details but at the same time I don't see
the value of the proposed change. We can apply or not apply the patch
and either way wouldn't make any noticeable difference. What's the
point?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES
2017-03-29 15:28 ` Tejun Heo
@ 2017-03-30 3:34 ` Cao jin
0 siblings, 0 replies; 5+ messages in thread
From: Cao jin @ 2017-03-30 3:34 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-arch, linux-kernel, arnd, cl
On 03/29/2017 11:28 PM, Tejun Heo wrote:
> On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote:
>> On 03/29/2017 12:00 AM, Tejun Heo wrote:
>>> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote:
>>>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
>>>
>>> I'm not sure. I think I used it during development and it's not like
>>> it costs anything to keep.
>>
>> It easily confusing newbies without any comments for its purpose.
>
> percpu variable handling is pretty complex to begin with. I don't buy
> that an empty default attribute macro adds anything noticeable there.
>
>> Temporary using during development seems not good to persist. Could I
>> know its purpose?
>
> I don't remember the exact details but at the same time I don't see
> the value of the proposed change. We can apply or not apply the patch
> and either way wouldn't make any noticeable difference. What's the
> point?
>
> Thanks.
>
It doesn't matter whether apply or not. I just start to read these code
and want to know what every tiny symbol is for. Thanks for your time.
--
Sincerely,
Cao jin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-30 3:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-28 8:35 [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES Cao jin
2017-03-28 16:00 ` Tejun Heo
2017-03-29 2:38 ` Cao jin
2017-03-29 15:28 ` Tejun Heo
2017-03-30 3:34 ` Cao jin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).