* [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error
@ 2017-04-01 10:43 Jeffy Chen
2017-04-01 10:43 ` [PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp Jeffy Chen
` (8 more replies)
0 siblings, 9 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, linux-arm-kernel, Tomeu Vizoso, Daniel Vetter,
dri-devel, linux-rockchip, Heiko Stuebner, David Airlie,
Archit Taneja
Verified on rk3399 chromebook kevin:
1/ stop ui && pkill -9 frecon
2/ unbind/bind drm
Jeffy Chen (9):
drm: bridge: analogix: Detach panel when unbinding analogix dp
drm: bridge: analogix: Unregister dp aux when unbinding
drm: bridge: analogix: Destroy connector when unbinding
drm/rockchip: cdn-dp: Don't try to release firmware when not loaded
drm/rockchip: vop: Enable pm domain when resetting vop
drm/rockchip: Reoder unload sequence
drm/rockchip: Force disable all crtc when unload
drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered
drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 +++
drivers/gpu/drm/rockchip/cdn-dp-core.c | 10 ++++---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 7 +++--
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 ++++++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++++++++++++++-------
5 files changed, 44 insertions(+), 16 deletions(-)
--
2.1.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:43 ` [PATCH 2/9] drm: bridge: analogix: Unregister dp aux when unbinding Jeffy Chen
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Tomeu Vizoso, Daniel Vetter, dri-devel, David Airlie,
Archit Taneja
The panel is attached when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index e7cd105..a3db290 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1443,6 +1443,8 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
if (dp->plat_data->panel) {
if (drm_panel_unprepare(dp->plat_data->panel))
DRM_ERROR("failed to turnoff the panel\n");
+ if (drm_panel_detach(dp->plat_data->panel))
+ DRM_ERROR("failed to detach the panel\n");
}
pm_runtime_disable(dev);
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/9] drm: bridge: analogix: Unregister dp aux when unbinding
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-01 10:43 ` [PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:43 ` [PATCH 3/9] drm: bridge: analogix: Destroy connector " Jeffy Chen
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Tomeu Vizoso, Daniel Vetter, dri-devel, David Airlie,
Archit Taneja
The dp aux is registered when binding analogix dp.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index a3db290..ec47fc2 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1447,6 +1447,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
DRM_ERROR("failed to detach the panel\n");
}
+ drm_dp_aux_unregister(&dp->aux);
pm_runtime_disable(dev);
}
EXPORT_SYMBOL_GPL(analogix_dp_unbind);
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/9] drm: bridge: analogix: Destroy connector when unbinding
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-01 10:43 ` [PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp Jeffy Chen
2017-04-01 10:43 ` [PATCH 2/9] drm: bridge: analogix: Unregister dp aux when unbinding Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:43 ` [PATCH 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Tomeu Vizoso, Daniel Vetter, dri-devel, David Airlie,
Archit Taneja
Normally we do this in drm_mode_config_cleanup. But analogix dp's
connector is allocated when binding, and would be freed after unbind.
So we need to destroy it when unbinding, to avoid further access.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index ec47fc2..084ee8f 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1439,6 +1439,7 @@ void analogix_dp_unbind(struct device *dev, struct device *master,
struct analogix_dp_device *dp = dev_get_drvdata(dev);
analogix_dp_bridge_disable(dp->bridge);
+ dp->connector.funcs->destroy(&dp->connector);
if (dp->plat_data->panel) {
if (drm_panel_unprepare(dp->plat_data->panel))
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (2 preceding siblings ...)
2017-04-01 10:43 ` [PATCH 3/9] drm: bridge: analogix: Destroy connector " Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:43 ` [PATCH 5/9] drm/rockchip: vop: Enable pm domain when resetting vop Jeffy Chen
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index fd79a70..a97f3f4 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1052,6 +1052,7 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
dp->connected = false;
dp->active = false;
dp->active_port = -1;
+ dp->fw_loaded = false;
INIT_WORK(&dp->event_work, cdn_dp_pd_event_work);
@@ -1132,7 +1133,8 @@ static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
connector->funcs->destroy(connector);
pm_runtime_disable(dev);
- release_firmware(dp->fw);
+ if (dp->fw_loaded)
+ release_firmware(dp->fw);
kfree(dp->edid);
dp->edid = NULL;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/9] drm/rockchip: vop: Enable pm domain when resetting vop
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (3 preceding siblings ...)
2017-04-01 10:43 ` [PATCH 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:43 ` [PATCH 6/9] drm/rockchip: Reoder unload sequence Jeffy Chen
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 31 +++++++++++++++++++----------
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index 76c79ac..1d85319 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1365,6 +1365,12 @@ static int vop_initial(struct vop *vop)
return ret;
}
+ ret = pm_runtime_get_sync(vop->dev);
+ if (ret < 0) {
+ dev_err(vop->dev, "failed to get pm runtime: %d\n", ret);
+ goto err_put_pm_runtime;
+ }
+
/* Enable both the hclk and aclk to setup the vop */
ret = clk_prepare_enable(vop->hclk);
if (ret < 0) {
@@ -1422,6 +1428,8 @@ static int vop_initial(struct vop *vop)
vop->is_enabled = false;
+ pm_runtime_put_sync(vop->dev);
+
return 0;
err_disable_aclk:
@@ -1430,6 +1438,8 @@ static int vop_initial(struct vop *vop)
clk_disable_unprepare(vop->hclk);
err_unprepare_dclk:
clk_unprepare(vop->dclk);
+err_put_pm_runtime:
+ pm_runtime_put_sync(vop->dev);
return ret;
}
@@ -1530,12 +1540,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
if (!vop->regsbak)
return -ENOMEM;
- ret = vop_initial(vop);
- if (ret < 0) {
- dev_err(&pdev->dev, "cannot initial vop dev - err %d\n", ret);
- return ret;
- }
-
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "cannot find irq for vop\n");
@@ -1556,15 +1560,22 @@ static int vop_bind(struct device *dev, struct device *master, void *data)
/* IRQ is initially disabled; it gets enabled in power_on */
disable_irq(vop->irq);
+ pm_runtime_enable(&pdev->dev);
+
+ ret = vop_initial(vop);
+ if (ret < 0) {
+ dev_err(&pdev->dev, "cannot initial vop dev - err %d\n", ret);
+ goto err_disable_pm_runtime;
+ }
+
ret = vop_create_crtc(vop);
if (ret)
- goto err_enable_irq;
-
- pm_runtime_enable(&pdev->dev);
+ goto err_disable_pm_runtime;
return 0;
-err_enable_irq:
+err_disable_pm_runtime:
+ pm_runtime_disable(&pdev->dev);
enable_irq(vop->irq); /* To balance out the disable_irq above */
return ret;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 6/9] drm/rockchip: Reoder unload sequence
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (4 preceding siblings ...)
2017-04-01 10:43 ` [PATCH 5/9] drm/rockchip: vop: Enable pm domain when resetting vop Jeffy Chen
@ 2017-04-01 10:43 ` Jeffy Chen
2017-04-01 10:44 ` [PATCH 7/9] drm/rockchip: Force disable all crtc when unload Jeffy Chen
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:43 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
We should don't cleanup iommu before cleanup other resources.
Reorder unload sequence, follow exynos drm.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index b360e62..a5d83cb 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -244,11 +244,13 @@ static void rockchip_drm_unbind(struct device *dev)
struct drm_device *drm_dev = dev_get_drvdata(dev);
rockchip_drm_fbdev_fini(drm_dev);
- drm_vblank_cleanup(drm_dev);
drm_kms_helper_poll_fini(drm_dev);
+
+ drm_vblank_cleanup(drm_dev);
component_unbind_all(dev, drm_dev);
- rockchip_iommu_cleanup(drm_dev);
drm_mode_config_cleanup(drm_dev);
+ rockchip_iommu_cleanup(drm_dev);
+
drm_dev->dev_private = NULL;
drm_dev_unregister(drm_dev);
drm_dev_unref(drm_dev);
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 7/9] drm/rockchip: Force disable all crtc when unload
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (5 preceding siblings ...)
2017-04-01 10:43 ` [PATCH 6/9] drm/rockchip: Reoder unload sequence Jeffy Chen
@ 2017-04-01 10:44 ` Jeffy Chen
2017-04-01 10:44 ` [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
2017-04-01 10:44 ` [PATCH 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:44 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index a5d83cb..5dbf011 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -246,6 +246,7 @@ static void rockchip_drm_unbind(struct device *dev)
rockchip_drm_fbdev_fini(drm_dev);
drm_kms_helper_poll_fini(drm_dev);
+ drm_crtc_force_disable_all(drm_dev);
drm_vblank_cleanup(drm_dev);
component_unbind_all(dev, drm_dev);
drm_mode_config_cleanup(drm_dev);
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (6 preceding siblings ...)
2017-04-01 10:44 ` [PATCH 7/9] drm/rockchip: Force disable all crtc when unload Jeffy Chen
@ 2017-04-01 10:44 ` Jeffy Chen
2017-04-03 7:22 ` kbuild test robot
2017-04-01 10:44 ` [PATCH 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
8 siblings, 1 reply; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:44 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index df9e570..19679b2 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -184,6 +184,9 @@ static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj,
struct drm_device *drm = obj->dev;
struct rockchip_drm_private *private = drm->dev_private;
+ if (!drm->registered)
+ return;
+
if (private->domain)
return rockchip_gem_alloc_iommu(rk_obj, alloc_kmap);
else
@@ -208,6 +211,11 @@ static void rockchip_gem_free_dma(struct rockchip_gem_object *rk_obj)
static void rockchip_gem_free_buf(struct rockchip_gem_object *rk_obj)
{
+ struct drm_device *drm = rk_obj->base.dev;
+
+ if (!drm->registered)
+ return;
+
if (rk_obj->pages)
rockchip_gem_free_iommu(rk_obj);
else
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
` (7 preceding siblings ...)
2017-04-01 10:44 ` [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
@ 2017-04-01 10:44 ` Jeffy Chen
8 siblings, 0 replies; 11+ messages in thread
From: Jeffy Chen @ 2017-04-01 10:44 UTC (permalink / raw)
To: linux-kernel
Cc: briannorris, dianders, tfiga, seanpaul, zyw, mark.yao,
Jeffy Chen, Heiko Stuebner, dri-devel, linux-rockchip,
David Airlie, linux-arm-kernel
In current sound framework, there's no way to unbind dai link after
unregister codec.
So don't unregister the codec when unbinding for now.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index a97f3f4..1deab9f 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -1091,8 +1091,6 @@ static int cdn_dp_bind(struct device *dev, struct device *master, void *data)
goto err_free_connector;
}
- cdn_dp_audio_codec_init(dp, dev);
-
for (i = 0; i < dp->ports; i++) {
port = dp->port[i];
@@ -1127,7 +1125,6 @@ static void cdn_dp_unbind(struct device *dev, struct device *master, void *data)
struct drm_connector *connector = &dp->connector;
cancel_work_sync(&dp->event_work);
- platform_device_unregister(dp->audio_pdev);
cdn_dp_encoder_disable(encoder);
encoder->funcs->destroy(encoder);
connector->funcs->destroy(connector);
@@ -1220,6 +1217,8 @@ static int cdn_dp_probe(struct platform_device *pdev)
mutex_init(&dp->lock);
dev_set_drvdata(dev, dp);
+ cdn_dp_audio_codec_init(dp, dev);
+
return component_add(dev, &cdn_dp_component_ops);
}
@@ -1227,6 +1226,7 @@ static int cdn_dp_remove(struct platform_device *pdev)
{
struct cdn_dp_device *dp = platform_get_drvdata(pdev);
+ platform_device_unregister(dp->audio_pdev);
cdn_dp_suspend(dp->dev);
component_del(&pdev->dev, &cdn_dp_component_ops);
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered
2017-04-01 10:44 ` [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
@ 2017-04-03 7:22 ` kbuild test robot
0 siblings, 0 replies; 11+ messages in thread
From: kbuild test robot @ 2017-04-03 7:22 UTC (permalink / raw)
To: Jeffy Chen
Cc: kbuild-all, linux-kernel, briannorris, dianders, tfiga, seanpaul,
zyw, mark.yao, Jeffy Chen, Heiko Stuebner, dri-devel,
linux-rockchip, David Airlie, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]
Hi Jeffy,
[auto build test WARNING on rockchip/for-next]
[also build test WARNING on v4.11-rc5 next-20170331]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jeffy-Chen/drm-rockchip-Fix-rockchip-drm-unbind-crash-error/20170403-094428
base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All warnings (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function 'rockchip_gem_alloc_buf':
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:188:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
return;
^~~~~~
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:180:12: note: declared here
static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj,
^~~~~~~~~~~~~~~~~~~~~~
vim +/return +188 drivers/gpu/drm/rockchip/rockchip_drm_gem.c
172 if (!rk_obj->kvaddr) {
173 DRM_ERROR("failed to allocate %zu byte dma buffer", obj->size);
174 return -ENOMEM;
175 }
176
177 return 0;
178 }
179
180 static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj,
181 bool alloc_kmap)
182 {
183 struct drm_gem_object *obj = &rk_obj->base;
184 struct drm_device *drm = obj->dev;
185 struct rockchip_drm_private *private = drm->dev_private;
186
187 if (!drm->registered)
> 188 return;
189
190 if (private->domain)
191 return rockchip_gem_alloc_iommu(rk_obj, alloc_kmap);
192 else
193 return rockchip_gem_alloc_dma(rk_obj, alloc_kmap);
194 }
195
196 static void rockchip_gem_free_iommu(struct rockchip_gem_object *rk_obj)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 61325 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-04-03 7:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-01 10:43 [PATCH 0/9] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen
2017-04-01 10:43 ` [PATCH 1/9] drm: bridge: analogix: Detach panel when unbinding analogix dp Jeffy Chen
2017-04-01 10:43 ` [PATCH 2/9] drm: bridge: analogix: Unregister dp aux when unbinding Jeffy Chen
2017-04-01 10:43 ` [PATCH 3/9] drm: bridge: analogix: Destroy connector " Jeffy Chen
2017-04-01 10:43 ` [PATCH 4/9] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen
2017-04-01 10:43 ` [PATCH 5/9] drm/rockchip: vop: Enable pm domain when resetting vop Jeffy Chen
2017-04-01 10:43 ` [PATCH 6/9] drm/rockchip: Reoder unload sequence Jeffy Chen
2017-04-01 10:44 ` [PATCH 7/9] drm/rockchip: Force disable all crtc when unload Jeffy Chen
2017-04-01 10:44 ` [PATCH 8/9] drm/rockchip: gem: Don't alloc/free gem buf before drm dev registered Jeffy Chen
2017-04-03 7:22 ` kbuild test robot
2017-04-01 10:44 ` [PATCH 9/9] drm/rockchip: cdn-dp: Don't unregister audio dev when unbinding Jeffy Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).