* [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.
@ 2017-04-05 19:23 Valerio Genovese
2017-04-05 23:57 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Valerio Genovese @ 2017-04-05 19:23 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel
This was reported by checkpatch.pl:
ERROR: space required after that close brace '}'
Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
index 2c398ca..5218f27 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
@@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
struct {
u16 FragNum:4;
u16 SeqNum:12;
- }field;
+ } field;
}SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
typedef union _BA_PARAM_SET {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.
2017-04-05 19:23 [PATCH] staging: rtl8192u: ieee80211: Fix space required after } Valerio Genovese
@ 2017-04-05 23:57 ` Joe Perches
2017-04-06 21:25 ` Valerio G
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2017-04-05 23:57 UTC (permalink / raw)
To: Valerio Genovese, gregkh; +Cc: devel, linux-kernel
On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
> This was reported by checkpatch.pl:
> ERROR: space required after that close brace '}'
>
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> index 2c398ca..5218f27 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
> struct {
> u16 FragNum:4;
> u16 SeqNum:12;
> - }field;
> + } field;
> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
What about the one on the next line?
$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.
2017-04-05 23:57 ` Joe Perches
@ 2017-04-06 21:25 ` Valerio G
0 siblings, 0 replies; 3+ messages in thread
From: Valerio G @ 2017-04-06 21:25 UTC (permalink / raw)
To: Joe Perches, gregkh; +Cc: devel, linux-kernel
Hi,
Thanks for the feedback. I re-submitted the patch as v2.
best
Valerio
Il 06/04/2017 01:57, Joe Perches ha scritto:
> On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
>> This was reported by checkpatch.pl:
>> ERROR: space required after that close brace '}'
>>
>> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
>> ---
>> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> index 2c398ca..5218f27 100644
>> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
>> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
>> struct {
>> u16 FragNum:4;
>> u16 SeqNum:12;
>> - }field;
>> + } field;
>> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
>
> What about the one on the next line?
>
> $ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-06 21:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-05 19:23 [PATCH] staging: rtl8192u: ieee80211: Fix space required after } Valerio Genovese
2017-04-05 23:57 ` Joe Perches
2017-04-06 21:25 ` Valerio G
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).