* [PATCH] mux: mux-gpio: fix compatible according to binding documentation
@ 2017-04-13 14:24 Philipp Zabel
2017-04-13 16:10 ` Peter Rosin
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Zabel @ 2017-04-13 14:24 UTC (permalink / raw)
To: Peter Rosin; +Cc: linux-kernel, kernel, Philipp Zabel
According to the device tree binding documentation, the compatible
should be "gpio-mux", not "mux-gpio".
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
drivers/mux/mux-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
index b304845c4812b..227d3572e6dbf 100644
--- a/drivers/mux/mux-gpio.c
+++ b/drivers/mux/mux-gpio.c
@@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
};
static const struct of_device_id mux_gpio_dt_ids[] = {
- { .compatible = "mux-gpio", },
+ { .compatible = "gpio-mux", },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation
2017-04-13 14:24 [PATCH] mux: mux-gpio: fix compatible according to binding documentation Philipp Zabel
@ 2017-04-13 16:10 ` Peter Rosin
2017-04-13 16:14 ` Peter Rosin
2017-04-18 8:21 ` Philipp Zabel
0 siblings, 2 replies; 4+ messages in thread
From: Peter Rosin @ 2017-04-13 16:10 UTC (permalink / raw)
To: Philipp Zabel, Greg Kroah-Hartman; +Cc: linux-kernel, kernel
On 2017-04-13 16:24, Philipp Zabel wrote:
> According to the device tree binding documentation, the compatible
> should be "gpio-mux", not "mux-gpio".
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/mux/mux-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
> index b304845c4812b..227d3572e6dbf 100644
> --- a/drivers/mux/mux-gpio.c
> +++ b/drivers/mux/mux-gpio.c
> @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
> };
>
> static const struct of_device_id mux_gpio_dt_ids[] = {
> - { .compatible = "mux-gpio", },
> + { .compatible = "gpio-mux", },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
>
Oh, crap, right you are. However, the mux patch series is not frozen yet,
and I think Greg KH will want this fixed before they are. So, I guess I'll
send a v11 of the mux series (shortly) instead of having this extra patch.
Cheers,
peda
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation
2017-04-13 16:10 ` Peter Rosin
@ 2017-04-13 16:14 ` Peter Rosin
2017-04-18 8:21 ` Philipp Zabel
1 sibling, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2017-04-13 16:14 UTC (permalink / raw)
To: Philipp Zabel, Greg Kroah-Hartman; +Cc: linux-kernel, kernel
On 2017-04-13 18:10, Peter Rosin wrote:
> On 2017-04-13 16:24, Philipp Zabel wrote:
>> According to the device tree binding documentation, the compatible
>> should be "gpio-mux", not "mux-gpio".
>>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>> drivers/mux/mux-gpio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
>> index b304845c4812b..227d3572e6dbf 100644
>> --- a/drivers/mux/mux-gpio.c
>> +++ b/drivers/mux/mux-gpio.c
>> @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>> };
>>
>> static const struct of_device_id mux_gpio_dt_ids[] = {
>> - { .compatible = "mux-gpio", },
>> + { .compatible = "gpio-mux", },
>> { /* sentinel */ }
>> };
>> MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
>>
>
> Oh, crap, right you are. However, the mux patch series is not frozen yet,
> and I think Greg KH will want this fixed before they are. So, I guess I'll
> send a v11 of the mux series (shortly) instead of having this extra patch.
Should be v13 of course....
> Cheers,
> peda
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation
2017-04-13 16:10 ` Peter Rosin
2017-04-13 16:14 ` Peter Rosin
@ 2017-04-18 8:21 ` Philipp Zabel
1 sibling, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2017-04-18 8:21 UTC (permalink / raw)
To: Peter Rosin; +Cc: Greg Kroah-Hartman, linux-kernel, kernel
On Thu, 2017-04-13 at 18:10 +0200, Peter Rosin wrote:
> On 2017-04-13 16:24, Philipp Zabel wrote:
> > According to the device tree binding documentation, the compatible
> > should be "gpio-mux", not "mux-gpio".
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> > drivers/mux/mux-gpio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
> > index b304845c4812b..227d3572e6dbf 100644
> > --- a/drivers/mux/mux-gpio.c
> > +++ b/drivers/mux/mux-gpio.c
> > @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
> > };
> >
> > static const struct of_device_id mux_gpio_dt_ids[] = {
> > - { .compatible = "mux-gpio", },
> > + { .compatible = "gpio-mux", },
> > { /* sentinel */ }
> > };
> > MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
> >
>
> Oh, crap, right you are. However, the mux patch series is not frozen yet,
> and I think Greg KH will want this fixed before they are. So, I guess I'll
> send a v11 of the mux series (shortly) instead of having this extra patch.
Of course, I wasn't aware.
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-18 8:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 14:24 [PATCH] mux: mux-gpio: fix compatible according to binding documentation Philipp Zabel
2017-04-13 16:10 ` Peter Rosin
2017-04-13 16:14 ` Peter Rosin
2017-04-18 8:21 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).