Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC

From: Paul Kocialkowski <contact@paulk.fr>
To: Stephen Warren <swarren@wwwdotorg.org>,
	linux-kernel@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC
Date: Tue, 18 Apr 2017 18:38:33 +0200	[thread overview]
Message-ID: <1492533513.3504.2.camel@paulk.fr> (raw)
In-Reply-To: <d18b57d3-a44f-e44b-9bd5-526993dc91e4@wwwdotorg.org>

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]

Le mardi 18 avril 2017 à 10:15 -0600, Stephen Warren a écrit :
> On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:
> > This selects the tegra30 i2s and ahub controllers for the tegra124 SoC.
> > These are needed when building without ARCH_TEGRA_3x_SOC set.
> > diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> > index efbe8d4c019e..bcd18d2cf7a7 100644
> > --- a/sound/soc/tegra/Kconfig
> > +++ b/sound/soc/tegra/Kconfig
> > @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF
> > 
> >  config SND_SOC_TEGRA30_AHUB
> >  	tristate
> > -	depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC
> > +	depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC ||
> > ARCH_TEGRA_124_SOC)
> 
> Is this really a compile-time dependency?

From a quick look at the code, I doubt this is really a build dependency.

> If so, don't we need to add T210 and T186 entries into that || condition too,
> since we could be building a kernel with just T210/T186 support and no T124
> support?

In the spirit of this patch, adding entries for other tegra platforms would make
sense. Would you prefer that we leave out the dependency from SND_SOC_TEGRA30_*
and only select the right I2S driver to use in each codec driver?

If not, we'd have to list all relevant platforms both in the I2S/AHUB drivers
and in each codec's rules (which is not necessarily and issue, but there's no
need to have artificial platform dependencies).

What do you think?

-- 
Paul Kocialkowski, developer of free digital technology at the lower levels

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]