* [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
@ 2017-04-20 13:29 Alexander Kochetkov
2017-04-20 17:11 ` Florian Fainelli
2017-04-21 19:24 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kochetkov @ 2017-04-20 13:29 UTC (permalink / raw)
To: David S. Miller, Philippe Reynes, Peter Chen, Wei Yongjun,
netdev, linux-kernel
Cc: Alexander Kochetkov
Currently driver use phy_start_aneg() in arc_emac_open() to bring
up PHY. But phy_start() function is more appropriate for this purposes.
Besides that it call phy_start_aneg() as part of PHY startup sequence
it also can correctly bring up PHY from error and suspended states.
So the patch replace phy_start_aneg() to phy_start().
Also the patch add call to phy_stop() to arc_emac_stop() to allow
the PHY device to be fully suspended when the interface is unused.
Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
Changes in v2:
- Updated commit message to clarify changes
drivers/net/ethernet/arc/emac_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c
index abc9f2a..188676d 100644
--- a/drivers/net/ethernet/arc/emac_main.c
+++ b/drivers/net/ethernet/arc/emac_main.c
@@ -434,7 +434,7 @@ static int arc_emac_open(struct net_device *ndev)
/* Enable EMAC */
arc_reg_or(priv, R_CTRL, EN_MASK);
- phy_start_aneg(ndev->phydev);
+ phy_start(ndev->phydev);
netif_start_queue(ndev);
@@ -556,6 +556,8 @@ static int arc_emac_stop(struct net_device *ndev)
napi_disable(&priv->napi);
netif_stop_queue(ndev);
+ phy_stop(ndev->phydev);
+
/* Disable interrupts */
arc_reg_clr(priv, R_ENABLE, RXINT_MASK | TXINT_MASK | ERR_MASK);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
2017-04-20 13:29 [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
@ 2017-04-20 17:11 ` Florian Fainelli
2017-04-21 19:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2017-04-20 17:11 UTC (permalink / raw)
To: Alexander Kochetkov, David S. Miller, Philippe Reynes,
Peter Chen, Wei Yongjun, netdev, linux-kernel
On 04/20/2017 06:29 AM, Alexander Kochetkov wrote:
> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
>
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
2017-04-20 13:29 [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
2017-04-20 17:11 ` Florian Fainelli
@ 2017-04-21 19:24 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-04-21 19:24 UTC (permalink / raw)
To: al.kochet; +Cc: tremyfr, peter.chen, weiyongjun1, netdev, linux-kernel
From: Alexander Kochetkov <al.kochet@gmail.com>
Date: Thu, 20 Apr 2017 16:29:34 +0300
> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
>
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
>
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-21 19:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 13:29 [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov
2017-04-20 17:11 ` Florian Fainelli
2017-04-21 19:24 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).