* [PATCH] power: supply: sbs-battery: fix the sbs interrupt request
@ 2017-04-21 3:13 raitosyo
2017-05-01 11:31 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: raitosyo @ 2017-04-21 3:13 UTC (permalink / raw)
To: sre; +Cc: linux-pm, linux-kernel
From: Ryosuke Saito <raitosyo@gmail.com>
Since we use the default primary handler for the irq, IRQF_ONESHOT must
be set. Otherwise the request fails and the following errors are
displayed:
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 129
sbs-battery 0-000b: Failed to request irq: -22
Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
---
drivers/power/supply/sbs-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
index 8bb2eb3..e07d570 100644
--- a/drivers/power/supply/sbs-battery.c
+++ b/drivers/power/supply/sbs-battery.c
@@ -820,7 +820,7 @@ static int sbs_probe(struct i2c_client *client,
}
rc = devm_request_threaded_irq(&client->dev, irq, NULL, sbs_irq,
- IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+ IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
dev_name(&client->dev), chip);
if (rc) {
dev_warn(&client->dev, "Failed to request irq: %d\n", rc);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: sbs-battery: fix the sbs interrupt request
2017-04-21 3:13 [PATCH] power: supply: sbs-battery: fix the sbs interrupt request raitosyo
@ 2017-05-01 11:31 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2017-05-01 11:31 UTC (permalink / raw)
To: raitosyo; +Cc: linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
Hi,
On Fri, Apr 21, 2017 at 12:13:17PM +0900, raitosyo@gmail.com wrote:
> From: Ryosuke Saito <raitosyo@gmail.com>
>
> Since we use the default primary handler for the irq, IRQF_ONESHOT must
> be set. Otherwise the request fails and the following errors are
> displayed:
>
> genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 129
> sbs-battery 0-000b: Failed to request irq: -22
>
> Signed-off-by: Ryosuke Saito <raitosyo@gmail.com>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-01 11:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-21 3:13 [PATCH] power: supply: sbs-battery: fix the sbs interrupt request raitosyo
2017-05-01 11:31 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).