linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jerome Forissier <jerome.forissier@linaro.org>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: add --typedefsfile
Date: Thu, 27 Apr 2017 08:59:56 -0700	[thread overview]
Message-ID: <1493308796.18659.45.camel@perches.com> (raw)
In-Reply-To: <c9cfaa3f-b82d-3de7-3860-57c0f05111c7@linaro.org>

On Thu, 2017-04-27 at 17:41 +0200, Jerome Forissier wrote:
> On 04/21/2017 08:31 AM, Jerome Forissier wrote:
> > On 04/20/2017 06:49 PM, Joe Perches wrote:
> > > On Thu, 2017-04-20 at 17:39 +0200, Jerome Forissier wrote:
> > > > When using checkpatch on out-of-tree code, it may occur that some
> > > > project-specific types are used, which will cause spurious warnings.
> > > > Add the --typedefsfile option as a way to extend the known types and
> > > > deal with this issue.
> > > 
> > > I'm not opposed to the addition.
> > > What out-of-tree project is this for?
> > 
> > OP-TEE [1]. We run a Travis job on all pull requests [2], and checkpatch
> > is part of that. The typical false warning we get on a regular basis is
> > with some pointers to functions returning TEE_Result [3], which is a
> > typedef from the GlobalPlatform APIs. We consider it is acceptable to
> > use GP types in the OP-TEE core implementation, that's why this patch
> > would be helpful for us.
> > 
> > [1] https://github.com/OP-TEE/optee_os
> > [2] https://travis-ci.org/OP-TEE/optee_os/builds
> > [3] https://travis-ci.org/OP-TEE/optee_os/builds/193355335#L1733 
> 
> Ping?

It's a well written patch.

But I'll leave it up to Andrew Morton to accept/reject this.

I'm not opposed to it though as it seems reasonable because
using a checkpatch command-line --ignore=NEW_TYPEDEFS may
not be the right solution for your use case.

      reply	other threads:[~2017-04-27 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 15:39 [PATCH] checkpatch: add --typedefsfile Jerome Forissier
2017-04-20 16:49 ` Joe Perches
2017-04-21  6:31   ` Jerome Forissier
2017-04-27 15:41     ` Jerome Forissier
2017-04-27 15:59       ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493308796.18659.45.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=jerome.forissier@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).