* [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter
@ 2017-05-02 15:00 Martin Kepplinger
2017-05-08 16:11 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Martin Kepplinger @ 2017-05-02 15:00 UTC (permalink / raw)
To: dmitry.torokhov, simon.budig, daniel.wagener, mchehab
Cc: linux-input, devicetree, linux-kernel, linux-doc,
Martin Kepplinger, Schoefegger Stefan, Manfred Schlaegl
The datasheet and application note does not mention an allowed range for
the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
T5x06 touch.
So, lacking a known lower limit, we increase the range for thresholds,
and set the lower limit to 0. The documentation is updated accordingly.
Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
---
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
Documentation/input/devices/edt-ft5x06.rst | 2 +-
drivers/input/touchscreen/edt-ft5x06.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
index 6db2210..025cf8c 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
@@ -36,7 +36,7 @@ Optional properties:
control gpios
- threshold: allows setting the "click"-threshold in the range
- from 20 to 80.
+ from 0 to 80.
- gain: allows setting the sensitivity in the range from 0 to
31. Note that lower values indicate higher
diff --git a/Documentation/input/devices/edt-ft5x06.rst b/Documentation/input/devices/edt-ft5x06.rst
index 2032f0b..1ccc94b 100644
--- a/Documentation/input/devices/edt-ft5x06.rst
+++ b/Documentation/input/devices/edt-ft5x06.rst
@@ -15,7 +15,7 @@ It has been tested with the following devices:
The driver allows configuration of the touch screen via a set of sysfs files:
/sys/class/input/eventX/device/device/threshold:
- allows setting the "click"-threshold in the range from 20 to 80.
+ allows setting the "click"-threshold in the range from 0 to 80.
/sys/class/input/eventX/device/device/gain:
allows setting the sensitivity in the range from 0 to 31. Note that
diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index 8cf8d8d..f872817 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -471,7 +471,7 @@ static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN,
static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET,
M09_REGISTER_OFFSET, 0, 31);
static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD,
- M09_REGISTER_THRESHOLD, 20, 80);
+ M09_REGISTER_THRESHOLD, 0, 80);
static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE,
NO_REGISTER, 3, 14);
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter
2017-05-02 15:00 [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter Martin Kepplinger
@ 2017-05-08 16:11 ` Rob Herring
2017-05-11 8:32 ` Martin Kepplinger
2017-05-23 0:20 ` Dmitry Torokhov
0 siblings, 2 replies; 5+ messages in thread
From: Rob Herring @ 2017-05-08 16:11 UTC (permalink / raw)
To: Martin Kepplinger
Cc: dmitry.torokhov, simon.budig, daniel.wagener, mchehab,
linux-input, devicetree, linux-kernel, linux-doc,
Schoefegger Stefan, Manfred Schlaegl
On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
> The datasheet and application note does not mention an allowed range for
> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
> T5x06 touch.
>
> So, lacking a known lower limit, we increase the range for thresholds,
> and set the lower limit to 0. The documentation is updated accordingly.
>
> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> ---
> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
> Documentation/input/devices/edt-ft5x06.rst | 2 +-
> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter
2017-05-08 16:11 ` Rob Herring
@ 2017-05-11 8:32 ` Martin Kepplinger
2017-05-17 12:39 ` Martin Kepplinger
2017-05-23 0:20 ` Dmitry Torokhov
1 sibling, 1 reply; 5+ messages in thread
From: Martin Kepplinger @ 2017-05-11 8:32 UTC (permalink / raw)
To: Rob Herring, dmitry.torokhov
Cc: simon.budig, daniel.wagener, mchehab, linux-input, devicetree,
linux-kernel, linux-doc, Schoefegger Stefan, Manfred Schlaegl
On 2017-05-08 18:11, Rob Herring wrote:
> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
>> The datasheet and application note does not mention an allowed range for
>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
>> T5x06 touch.
>>
>> So, lacking a known lower limit, we increase the range for thresholds,
>> and set the lower limit to 0. The documentation is updated accordingly.
>>
>> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
>> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>> ---
>> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>> Documentation/input/devices/edt-ft5x06.rst | 2 +-
>> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
>
Dmitry, any objections or thoughts?
thanks
martin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter
2017-05-11 8:32 ` Martin Kepplinger
@ 2017-05-17 12:39 ` Martin Kepplinger
0 siblings, 0 replies; 5+ messages in thread
From: Martin Kepplinger @ 2017-05-17 12:39 UTC (permalink / raw)
To: Rob Herring, dmitry.torokhov
Cc: simon.budig, daniel.wagener, mchehab, linux-input, devicetree,
linux-kernel, linux-doc, Schoefegger Stefan, Manfred Schlaegl
On 2017-05-11 10:32, Martin Kepplinger wrote:
> On 2017-05-08 18:11, Rob Herring wrote:
>> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
>>> The datasheet and application note does not mention an allowed range for
>>> the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
>>> lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
>>> T5x06 touch.
>>>
>>> So, lacking a known lower limit, we increase the range for thresholds,
>>> and set the lower limit to 0. The documentation is updated accordingly.
>>>
>>> Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
>>> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
>>> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
>>> ---
>>> Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
>>> Documentation/input/devices/edt-ft5x06.rst | 2 +-
>>> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>>
>
> Dmitry, any objections or thoughts?
Hey Dmitry, this still applies to today's -next and wouldn't take too
long for you to review :)
thanks
martin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter
2017-05-08 16:11 ` Rob Herring
2017-05-11 8:32 ` Martin Kepplinger
@ 2017-05-23 0:20 ` Dmitry Torokhov
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2017-05-23 0:20 UTC (permalink / raw)
To: Rob Herring
Cc: Martin Kepplinger, simon.budig, daniel.wagener, mchehab,
linux-input, devicetree, linux-kernel, linux-doc,
Schoefegger Stefan, Manfred Schlaegl
On Mon, May 08, 2017 at 11:11:46AM -0500, Rob Herring wrote:
> On Tue, May 02, 2017 at 05:00:59PM +0200, Martin Kepplinger wrote:
> > The datasheet and application note does not mention an allowed range for
> > the M09_REGISTER_THRESHOLD parameter. One of our customers needs to set
> > lower values than 20 and they seem to work just fine on EDT EP0xx0M09 with
> > T5x06 touch.
> >
> > So, lacking a known lower limit, we increase the range for thresholds,
> > and set the lower limit to 0. The documentation is updated accordingly.
> >
> > Signed-off-by: Schoefegger Stefan <stefan.schoefegger@ginzinger.com>
> > Signed-off-by: Manfred Schlaegl <manfred.schlaegl@ginzinger.com>
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> > ---
> > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt | 2 +-
> > Documentation/input/devices/edt-ft5x06.rst | 2 +-
> > drivers/input/touchscreen/edt-ft5x06.c | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-23 0:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 15:00 [PATCH] input: edt-ft5x06: increase allowed data range for threshold parameter Martin Kepplinger
2017-05-08 16:11 ` Rob Herring
2017-05-11 8:32 ` Martin Kepplinger
2017-05-17 12:39 ` Martin Kepplinger
2017-05-23 0:20 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).