[PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Geert Uytterhoeven]

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 6caff35af8815cda..51bf4da6dc18e7e8 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -463,6 +463,7 @@ config SPI_OMAP24XX
 
 config SPI_TI_QSPI
 	tristate "DRA7xxx QSPI controller support"
+	depends on HAS_DMA
 	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	help
 	  QSPI master controller for DRA7xxx used for flash devices.
-- 
2.7.4

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
> 
> Add a dependency on HAS_DMA to fix this.

There's no progress on fixing the architectures that don't do DMA to
stub it out?  :(

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Applied "spi: SPI_TI_QSPI should depend on HAS_DMA" to the spi tree

[Mark Brown]

The patch

   spi: SPI_TI_QSPI should depend on HAS_DMA

has been applied to the spi tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 967d6941f49f1ddd5764d3a09423a63841b9394c Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 4 May 2017 09:37:18 +0200
Subject: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

If NO_DMA=y:

    ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!

Add a dependency on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 1761c9004fc1..097883362036 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -457,6 +457,7 @@ config SPI_OMAP24XX
 
 config SPI_TI_QSPI
 	tristate "DRA7xxx QSPI controller support"
+	depends on HAS_DMA
 	depends on ARCH_OMAP2PLUS || COMPILE_TEST
 	help
 	  QSPI master controller for DRA7xxx used for flash devices.
-- 
2.11.0

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Geert Uytterhoeven]

Hi Mark,

On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> If NO_DMA=y:
>>
>>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>>
>> Add a dependency on HAS_DMA to fix this.
>
> There's no progress on fixing the architectures that don't do DMA to
> stub it out?  :(

Then it has to become "depends on HAS_DMA || COMPILE_TEST"?

Even more typing work for me ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
> >> If NO_DMA=y:

> >>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!

> >> Add a dependency on HAS_DMA to fix this.

> > There's no progress on fixing the architectures that don't do DMA to
> > stub it out?  :(

> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?

No, I was thinking more just not needing the dependency at all.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Geert Uytterhoeven]

Hi Mark,

On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, May 15, 2017 at 10:46:15AM +0200, Geert Uytterhoeven wrote:
>> On Sun, May 14, 2017 at 11:50 AM, Mark Brown <broonie@kernel.org> wrote:
>> > On Thu, May 04, 2017 at 09:37:18AM +0200, Geert Uytterhoeven wrote:
>> >> If NO_DMA=y:
>
>> >>     ERROR: "bad_dma_ops" [drivers/spi/spi-ti-qspi.ko] undefined!
>
>> >> Add a dependency on HAS_DMA to fix this.
>
>> > There's no progress on fixing the architectures that don't do DMA to
>> > stub it out?  :(
>
>> Then it has to become "depends on HAS_DMA || COMPILE_TEST"?
>
> No, I was thinking more just not needing the dependency at all.

Then what's the point of the existence of COMPILE_TEST?
We can just have stubs for everything, and always build everything.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] spi: SPI_TI_QSPI should depend on HAS_DMA

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

On Mon, May 15, 2017 at 12:21:33PM +0200, Geert Uytterhoeven wrote:
> On Mon, May 15, 2017 at 12:12 PM, Mark Brown <broonie@kernel.org> wrote:

> > No, I was thinking more just not needing the dependency at all.

> Then what's the point of the existence of COMPILE_TEST?
> We can just have stubs for everything, and always build everything.

It's useful for platform specific devices (like this one should be) but
having to add dependencies for basic kernel APIs like the DMA one is
just making for a lot of noise.  There's plenty of platforms without DMA
that also have no real use for this driver, it's not really a relevant
thing when deciding if the driver might be useful if what you're trying
to do is hide drivers that aren't useful on the platform.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]