From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Chen, Xiaoguang" <xiaoguang.chen@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
"Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"Wang, Zhi A" <zhi.a.wang@intel.com>
Subject: Re: [RFC PATCH 6/6] drm/i915/gvt: support QEMU getting the dmabuf
Date: Fri, 05 May 2017 08:55:31 +0200 [thread overview]
Message-ID: <1493967331.371.53.camel@redhat.com> (raw)
In-Reply-To: <20170504100833.199bc8ba@t450s.home>
Hi,
> > >>Hmm, that looks like a rather strange way to return a file descriptor.
> > >>
> > >>What is the reason to not use ioctls on the vfio file handle, like
> > >>older version of these patches did?
> > >If I understood correctly that Alex prefer not to change the ioctls on the vfio file
> > >handle like the old version.
> > >So I used this way the smallest change to general vfio framework only adding a
> > >subregion definition.
>
> I think I was hoping we could avoid a separate file descriptor
> altogether and use a vfio region instead.
What exactly did you have in mind? Put the framebuffer information
(struct intel_vgpu_dmabuf) into the vfio region, then access it using
read/write/mmap?
> However, it was explained
> previously why this really needs to be a separate fd and I agree that
> using a region to expose an fd is really awkward.
Now with this patchset we have *two* kinds of separate file handles.
First the anon-fd created by reading from the region. This is then used
to run the intel ioctls on, which in turn create the other kind of file
handle (dma-buf-fd).
The dma-buf-fd really needs to be a separate fd, because it gets passed
around as handle and because this is the way dma-bufs work (guess this
is the discussion you are referring to).
I can't see a compelling reason for the anon-fd though. I suspect this
was done due to a misunderstanding ...
cheers,
Gerd
next prev parent reply other threads:[~2017-05-05 6:55 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 9:35 [RFC PATCH 0/6] drm/i915/gvt: dma-buf support for GVT-g Xiaoguang Chen
2017-04-28 9:35 ` [RFC PATCH 1/6] drm/i915/gvt: extend the GVT-g architecture to support vfio device region Xiaoguang Chen
2017-04-28 9:35 ` [RFC PATCH 2/6] drm/i915/gvt: OpRegion support for GVT-g Xiaoguang Chen
2017-04-28 9:35 ` [RFC PATCH 3/6] drm/i915/gvt: framebuffer decoder " Xiaoguang Chen
2017-04-28 9:35 ` [RFC PATCH 4/6] drm/i915: export i915 dmabuf_ops Xiaoguang Chen
2017-04-28 9:35 ` [RFC PATCH 5/6] drm/i915/gvt: dmabuf support for GVT-g Xiaoguang Chen
2017-04-28 10:08 ` [Intel-gfx] " Chris Wilson
2017-05-02 7:40 ` Chen, Xiaoguang
2017-05-04 3:12 ` Chen, Xiaoguang
2017-05-02 9:37 ` Gerd Hoffmann
2017-04-28 9:35 ` [RFC PATCH 6/6] drm/i915/gvt: support QEMU getting the dmabuf Xiaoguang Chen
2017-05-02 9:50 ` Gerd Hoffmann
2017-05-03 1:39 ` Chen, Xiaoguang
2017-05-04 3:09 ` Chen, Xiaoguang
2017-05-04 16:08 ` Alex Williamson
2017-05-05 6:55 ` Gerd Hoffmann [this message]
2017-05-05 15:11 ` Alex Williamson
2017-05-11 8:45 ` Chen, Xiaoguang
2017-05-11 13:27 ` Gerd Hoffmann
2017-05-11 15:45 ` Alex Williamson
2017-05-12 2:12 ` Chen, Xiaoguang
2017-05-12 2:58 ` Alex Williamson
2017-05-12 3:52 ` Chen, Xiaoguang
2017-05-12 9:12 ` Gerd Hoffmann
2017-05-12 16:38 ` Alex Williamson
2017-05-15 3:36 ` Chen, Xiaoguang
2017-05-15 17:44 ` Alex Williamson
2017-05-16 10:16 ` Chen, Xiaoguang
2017-05-17 21:43 ` Alex Williamson
2017-05-18 1:51 ` Chen, Xiaoguang
2017-05-18 14:56 ` Alex Williamson
2017-05-19 6:23 ` Chen, Xiaoguang
2017-05-19 8:04 ` Gerd Hoffmann
2017-05-19 8:17 ` Chen, Xiaoguang
2017-05-19 8:57 ` Gerd Hoffmann
2017-05-19 9:14 ` Chen, Xiaoguang
2017-05-19 10:51 ` Gerd Hoffmann
2017-05-18 6:22 ` Gerd Hoffmann
2017-05-12 6:56 ` Chen, Xiaoguang
2017-05-12 17:04 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493967331.371.53.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguang.chen@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).