* [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()
@ 2017-05-09 7:50 SF Markus Elfring
2017-05-09 7:53 ` Johannes Berg
2017-05-09 12:25 ` Eric Dumazet
0 siblings, 2 replies; 3+ messages in thread
From: SF Markus Elfring @ 2017-05-09 7:50 UTC (permalink / raw)
To: wil6210, linux-wireless, netdev, Kalle Valo, Maya Erez
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 8 May 2017 22:22:04 +0200
Five single characters (line breaks) should be put into a sequence.
Thus use the corresponding function "seq_putc".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/wireless/ath/wil6210/debugfs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
index 5648ebbd0e16..90118d286fb9 100644
--- a/drivers/net/wireless/ath/wil6210/debugfs.c
+++ b/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -76,11 +76,11 @@ static void wil_print_vring(struct seq_file *s, struct wil6210_priv *wil,
volatile struct vring_tx_desc *d = &vring->va[i].tx;
if ((i % 128) == 0 && (i != 0))
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
seq_printf(s, "%c", (d->dma.status & BIT(0)) ?
_s : (vring->ctx[i].skb ? _h : 'h'));
}
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
seq_puts(s, "}\n");
}
@@ -233,7 +233,7 @@ static void wil_print_ring(struct seq_file *s, const char *prefix,
wil_seq_hexdump(s, databuf, len, " : ");
}
} else {
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
}
out:
@@ -1366,7 +1366,7 @@ static void wil_print_rxtid_crypto(struct seq_file *s, int tid,
seq_printf(s, " [%i%s]%6phN", i, cc->key_set ? "+" : "-",
cc->pn);
}
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
static int wil_sta_debugfs_show(struct seq_file *s, void *data)
@@ -1423,7 +1423,7 @@ __acquires(&p->tid_rx_lock) __releases(&p->tid_rx_lock)
mcs++)
seq_printf(s, " %lld",
p->stats.rx_per_mcs[mcs]);
- seq_puts(s, "\n");
+ seq_putc(s, '\n');
}
}
--
2.12.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()
2017-05-09 7:50 [PATCH] wil6210: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
@ 2017-05-09 7:53 ` Johannes Berg
2017-05-09 12:25 ` Eric Dumazet
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2017-05-09 7:53 UTC (permalink / raw)
To: SF Markus Elfring, wil6210, linux-wireless, netdev, Kalle Valo,
Maya Erez
Cc: LKML, kernel-janitors
On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 22:22:04 +0200
>
> Five single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
Please stop, this isn't really an issue worth worrying about.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wil6210: Replace five seq_puts() calls by seq_putc()
2017-05-09 7:50 [PATCH] wil6210: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-09 7:53 ` Johannes Berg
@ 2017-05-09 12:25 ` Eric Dumazet
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2017-05-09 12:25 UTC (permalink / raw)
To: SF Markus Elfring
Cc: wil6210, linux-wireless, netdev, Kalle Valo, Maya Erez, LKML,
kernel-janitors
On Tue, 2017-05-09 at 09:50 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 8 May 2017 22:22:04 +0200
>
> Five single characters (line breaks) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
There is no _issue_ at all here, only a matter of taste.
printf("\n") or putchar('\n') in some slow path is really not that
interesting.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-09 12:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 7:50 [PATCH] wil6210: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-09 7:53 ` Johannes Berg
2017-05-09 12:25 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).