* [RESEND PATCH] sched: Don't reinvent the wheel but use existing llist API
@ 2017-05-12 0:39 Byungchul Park
2017-05-23 8:44 ` [tip:sched/core] sched/core: Use the new llist_for_each_entry_safe() primitive tip-bot for Byungchul Park
0 siblings, 1 reply; 2+ messages in thread
From: Byungchul Park @ 2017-05-12 0:39 UTC (permalink / raw)
To: peterz; +Cc: linux-kernel, kernel-team
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
kernel/sched/core.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d01f9d0..8938125 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1773,7 +1773,7 @@ void sched_ttwu_pending(void)
{
struct rq *rq = this_rq();
struct llist_node *llist = llist_del_all(&rq->wake_list);
- struct task_struct *p;
+ struct task_struct *p, *t;
unsigned long flags;
struct rq_flags rf;
@@ -1783,17 +1783,8 @@ void sched_ttwu_pending(void)
raw_spin_lock_irqsave(&rq->lock, flags);
rq_pin_lock(rq, &rf);
- while (llist) {
- int wake_flags = 0;
-
- p = llist_entry(llist, struct task_struct, wake_entry);
- llist = llist_next(llist);
-
- if (p->sched_remote_wakeup)
- wake_flags = WF_MIGRATED;
-
- ttwu_do_activate(rq, p, wake_flags, &rf);
- }
+ llist_for_each_entry_safe(p, t, llist, wake_entry)
+ ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
rq_unpin_lock(rq, &rf);
raw_spin_unlock_irqrestore(&rq->lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:sched/core] sched/core: Use the new llist_for_each_entry_safe() primitive
2017-05-12 0:39 [RESEND PATCH] sched: Don't reinvent the wheel but use existing llist API Byungchul Park
@ 2017-05-23 8:44 ` tip-bot for Byungchul Park
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Byungchul Park @ 2017-05-23 8:44 UTC (permalink / raw)
To: linux-tip-commits
Cc: hpa, tglx, kernel-team, byungchul.park, linux-kernel, mingo,
peterz, torvalds
Commit-ID: 73215849dfbf63421c1cafea5a1b6da9bb17831e
Gitweb: http://git.kernel.org/tip/73215849dfbf63421c1cafea5a1b6da9bb17831e
Author: Byungchul Park <byungchul.park@lge.com>
AuthorDate: Fri, 12 May 2017 09:39:44 +0900
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 23 May 2017 10:01:33 +0200
sched/core: Use the new llist_for_each_entry_safe() primitive
Now that we've added llist_for_each_entry_safe(), use it to simplify
an open coded version of it in sched_ttwu_pending().
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <kernel-team@lge.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1494549584-11730-1-git-send-email-byungchul.park@lge.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
kernel/sched/core.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index dde5d1e..4a31239 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1731,7 +1731,7 @@ void sched_ttwu_pending(void)
{
struct rq *rq = this_rq();
struct llist_node *llist = llist_del_all(&rq->wake_list);
- struct task_struct *p;
+ struct task_struct *p, *t;
struct rq_flags rf;
if (!llist)
@@ -1740,17 +1740,8 @@ void sched_ttwu_pending(void)
rq_lock_irqsave(rq, &rf);
update_rq_clock(rq);
- while (llist) {
- int wake_flags = 0;
-
- p = llist_entry(llist, struct task_struct, wake_entry);
- llist = llist_next(llist);
-
- if (p->sched_remote_wakeup)
- wake_flags = WF_MIGRATED;
-
- ttwu_do_activate(rq, p, wake_flags, &rf);
- }
+ llist_for_each_entry_safe(p, t, llist, wake_entry)
+ ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
rq_unlock_irqrestore(rq, &rf);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-23 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-12 0:39 [RESEND PATCH] sched: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-05-23 8:44 ` [tip:sched/core] sched/core: Use the new llist_for_each_entry_safe() primitive tip-bot for Byungchul Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).