[PATCH RFC] perf/callchain: fixup charset file header

[PATCH RFC] perf/callchain: fixup charset file header

[Nicholas Mc Guire]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1874 bytes --]

Non-UTF-8 characters are a problem for some terminals and also
make greping harder than necessary - this only switches the
copyright sign to the common (C).

Reported-by: Markus Kreidl <mkreidl@opentech.at>
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---

Found by checkpatch --strict:
CHECK: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#7: FILE: kernel/events/callchain.c:7:
+ *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <paulus@au1.ibm.com>

Before I start generating sets of patches that fix encoding issues 
I would like to know if that is going to be accepted at all - the
background is that it causes quite a bit of trouble when automating
tools if these encoding problems make using simple tools hard (e.g.
grep) and thus make automation a lot more complicated that necessary.
It seems to me that the codingstyle does not mandate UTF-8 but there
are a few places where it is "suggested" like in:
  Documentation/process/email-clients.rst

This really should not have any impact on the code but 
patch was compile-tested with x86_64_defconfig (implies CONFIG_PERF_EVENTS)
(issues two sparse warnings - not related though)

Patch is against 4.12-rc1 (localversion-next is next-20170519)

 kernel/events/callchain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c
index 1b2be63..357f488 100644
--- a/kernel/events/callchain.c
+++ b/kernel/events/callchain.c
@@ -4,7 +4,7 @@
  *  Copyright (C) 2008 Thomas Gleixner <tglx@linutronix.de>
  *  Copyright (C) 2008-2011 Red Hat, Inc., Ingo Molnar
  *  Copyright (C) 2008-2011 Red Hat, Inc., Peter Zijlstra
- *  Copyright  ©  2009 Paul Mackerras, IBM Corp. <paulus@au1.ibm.com>
+ *  Copyright (C) 2009 Paul Mackerras, IBM Corp. <paulus@au1.ibm.com>
  *
  * For licensing details see kernel-base/COPYING
  */
-- 
2.1.4

Re: [PATCH RFC] perf/callchain: fixup charset file header

[Peter Zijlstra]

On Sat, May 20, 2017 at 06:47:31PM +0200, Nicholas Mc Guire wrote:
> Non-UTF-8 characters are a problem for some terminals and also
> make greping harder than necessary - this only switches the
> copyright sign to the common (C).
> 
> Reported-by: Markus Kreidl <mkreidl@opentech.at>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
> 
> Found by checkpatch --strict:
> CHECK: Invalid UTF-8, patch and commit message should be encoded in UTF-8
> #7: FILE: kernel/events/callchain.c:7:
> + *  Copyright  ?  2009 Paul Mackerras, IBM Corp. <paulus@au1.ibm.com>
> 
> Before I start generating sets of patches that fix encoding issues 
> I would like to know if that is going to be accepted at all - the
> background is that it causes quite a bit of trouble when automating
> tools if these encoding problems make using simple tools hard (e.g.
> grep) and thus make automation a lot more complicated that necessary.
> It seems to me that the codingstyle does not mandate UTF-8 but there
> are a few places where it is "suggested" like in:
>   Documentation/process/email-clients.rst

The last discussion on the subject was:

http://lkml.iu.edu/hypermail/linux/kernel/1001.2/02928.html

Which seemed to suggest replacing it with the UTF8 equivalent glyph. I
can't remember a patch, not Paul Ack'ing it (which is very much required
in order to change his copyright message).