linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 02/10] gpio: mockup: add prefixes to the direction enum
Date: Thu, 25 May 2017 10:33:39 +0200	[thread overview]
Message-ID: <1495701227-28809-3-git-send-email-brgl@bgdev.pl> (raw)
In-Reply-To: <1495701227-28809-1-git-send-email-brgl@bgdev.pl>

All internal symbols except for the direction enum follow the same
convention and use the gpio_mockup prefix. Add the prefix to the
DIR_IN and DIR_OUT definitions as well for consistency across the
file.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/gpio/gpio-mockup.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
index c18d011..b1ee45c 100644
--- a/drivers/gpio/gpio-mockup.c
+++ b/drivers/gpio/gpio-mockup.c
@@ -29,8 +29,8 @@
 #define	GPIO_MOCKUP_MAX_GC	10
 
 enum {
-	DIR_OUT = 0,
-	DIR_IN = 1,
+	GPIO_MOCKUP_DIR_OUT = 0,
+	GPIO_MOCKUP_DIR_IN = 1,
 };
 
 /*
@@ -93,7 +93,7 @@ static int gpio_mockup_dirout(struct gpio_chip *gc, unsigned int offset,
 	struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
 
 	gpio_mockup_set(gc, offset, value);
-	chip->lines[offset].dir = DIR_OUT;
+	chip->lines[offset].dir = GPIO_MOCKUP_DIR_OUT;
 
 	return 0;
 }
@@ -102,7 +102,7 @@ static int gpio_mockup_dirin(struct gpio_chip *gc, unsigned int offset)
 {
 	struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
 
-	chip->lines[offset].dir = DIR_IN;
+	chip->lines[offset].dir = GPIO_MOCKUP_DIR_IN;
 
 	return 0;
 }
-- 
2.9.3

  parent reply	other threads:[~2017-05-25  8:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25  8:33 [PATCH 00/10] gpio: mockup: updates for 4.13 Bartosz Golaszewski
2017-05-25  8:33 ` [PATCH 01/10] gpio: mockup: fix direction values Bartosz Golaszewski
2017-05-27 16:43   ` Andy Shevchenko
2017-05-29 11:27   ` Linus Walleij
2017-05-25  8:33 ` Bartosz Golaszewski [this message]
2017-05-29 11:28   ` [PATCH 02/10] gpio: mockup: add prefixes to the direction enum Linus Walleij
2017-05-25  8:33 ` [PATCH 03/10] gpio: mockup: be quiet unless something goes wrong Bartosz Golaszewski
2017-05-29 11:29   ` Linus Walleij
2017-05-25  8:33 ` [PATCH 04/10] gpio: mockup: support irqmask and irqunmask Bartosz Golaszewski
2017-05-29 11:30   ` Linus Walleij
2017-05-25  8:33 ` [PATCH 05/10] gpio: mockup: improve the debugfs input sanitization Bartosz Golaszewski
2017-05-27 16:45   ` Andy Shevchenko
2017-05-27 16:47     ` Andy Shevchenko
2017-05-29  6:57       ` Bartosz Golaszewski
2017-05-29 11:32   ` Linus Walleij
2017-05-25  8:33 ` [PATCH 06/10] gpio: mockup: refuse to accept an odd number of GPIO ranges Bartosz Golaszewski
2017-05-27 17:29   ` Andy Shevchenko
2017-05-27 17:30     ` Andy Shevchenko
2017-05-25  8:33 ` [PATCH 07/10] gpio: mockup: improve readability Bartosz Golaszewski
2017-05-25  8:33 ` [PATCH 08/10] gpio: mockup: don't return magic numbers from probe() Bartosz Golaszewski
2017-05-25  8:33 ` [PATCH 09/10] gpio: mockup: improve the error message Bartosz Golaszewski
2017-05-25  8:33 ` [PATCH 10/10] gpio: mockup: add myself as author Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495701227-28809-3-git-send-email-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=bamvor.zhangjian@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).