From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/10] gpio: mockup: refuse to accept an odd number of GPIO ranges
Date: Sat, 27 May 2017 20:29:33 +0300 [thread overview]
Message-ID: <CAHp75VfwAS3fKfnDGb6cGEC0-YhpR2J_mwSHzjykh6vbQ=p4eQ@mail.gmail.com> (raw)
In-Reply-To: <1495701227-28809-7-git-send-email-brgl@bgdev.pl>
On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> Currently we ignore the last odd range value, since each chip is
> described by two values. Be more strict and require the user to
> pass an even number of ranges.
> - if (gpio_mockup_params_nr < 2)
> + if (gpio_mockup_params_nr < 2 || (gpio_mockup_params_nr % 2))
if (((gpio_mockup_params_nr + 1) & ~3) < 3)
3 might have a suffix regarding to the type of variable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-05-27 17:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 8:33 [PATCH 00/10] gpio: mockup: updates for 4.13 Bartosz Golaszewski
2017-05-25 8:33 ` [PATCH 01/10] gpio: mockup: fix direction values Bartosz Golaszewski
2017-05-27 16:43 ` Andy Shevchenko
2017-05-29 11:27 ` Linus Walleij
2017-05-25 8:33 ` [PATCH 02/10] gpio: mockup: add prefixes to the direction enum Bartosz Golaszewski
2017-05-29 11:28 ` Linus Walleij
2017-05-25 8:33 ` [PATCH 03/10] gpio: mockup: be quiet unless something goes wrong Bartosz Golaszewski
2017-05-29 11:29 ` Linus Walleij
2017-05-25 8:33 ` [PATCH 04/10] gpio: mockup: support irqmask and irqunmask Bartosz Golaszewski
2017-05-29 11:30 ` Linus Walleij
2017-05-25 8:33 ` [PATCH 05/10] gpio: mockup: improve the debugfs input sanitization Bartosz Golaszewski
2017-05-27 16:45 ` Andy Shevchenko
2017-05-27 16:47 ` Andy Shevchenko
2017-05-29 6:57 ` Bartosz Golaszewski
2017-05-29 11:32 ` Linus Walleij
2017-05-25 8:33 ` [PATCH 06/10] gpio: mockup: refuse to accept an odd number of GPIO ranges Bartosz Golaszewski
2017-05-27 17:29 ` Andy Shevchenko [this message]
2017-05-27 17:30 ` Andy Shevchenko
2017-05-25 8:33 ` [PATCH 07/10] gpio: mockup: improve readability Bartosz Golaszewski
2017-05-25 8:33 ` [PATCH 08/10] gpio: mockup: don't return magic numbers from probe() Bartosz Golaszewski
2017-05-25 8:33 ` [PATCH 09/10] gpio: mockup: improve the error message Bartosz Golaszewski
2017-05-25 8:33 ` [PATCH 10/10] gpio: mockup: add myself as author Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfwAS3fKfnDGb6cGEC0-YhpR2J_mwSHzjykh6vbQ=p4eQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=brgl@bgdev.pl \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).