linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.
@ 2017-05-31 12:54 srishti sharma
  2017-06-03  8:36 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: srishti sharma @ 2017-05-31 12:54 UTC (permalink / raw)
  To: gregkh
  Cc: gilad, linux-crypto, driverdev-devel, devel, linux-kernel,
	srishti sharma

Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/cc_crypto_ctx.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h
index c5784bc..38f6615 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -239,10 +239,10 @@ struct drv_ctx_cipher {
 	enum drv_crypto_padding_type padding_type;
 	u32 key_size; /* numeric value in bytes   */
 	u32 data_unit_size; /* required for XTS */
-	/* block_state is the AES engine block state.
-	*  It is used by the host to pass IV or counter at initialization.
-	*  It is used by SeP for intermediate block chaining state and for
-	*  returning MAC algorithms results.           */
+	/*  block_state is the AES engine block state.
+	 *  It is used by the host to pass IV or counter at initialization.
+	 *  It is used by SeP for intermediate block chaining state and for
+	 *  returning MAC algorithms results.           */
 	u8 block_state[CC_AES_BLOCK_SIZE];
 	u8 key[CC_AES_KEY_SIZE_MAX];
 	u8 xex_key[CC_AES_KEY_SIZE_MAX];
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.
  2017-05-31 12:54 [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue srishti sharma
@ 2017-06-03  8:36 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-06-03  8:36 UTC (permalink / raw)
  To: srishti sharma; +Cc: devel, driverdev-devel, linux-kernel, linux-crypto

On Wed, May 31, 2017 at 06:24:55PM +0530, srishti sharma wrote:
> Fixed a comment coding style issue that generated a warning stating that block comments should align the * on each line.
> 

Please properly line-wrap your changelog comments :(

You also sent 2 different patches, that did different things, yet they
had the same subject line.  That's not ok, and also, I have no idea
which one to apply first.

I'm dropping both, please fix and resend them properly as a patch
series.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue.
@ 2017-05-31 12:06 srishti sharma
  0 siblings, 0 replies; 3+ messages in thread
From: srishti sharma @ 2017-05-31 12:06 UTC (permalink / raw)
  To: gregkh; +Cc: gilad, linux-crypto, driverdev-devel, linux-kernel, srishti sharma

Fixed a comment coding style issue that generated a warning stating block comments use * on subsequent lines.

Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
 drivers/staging/ccree/cc_crypto_ctx.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ccree/cc_crypto_ctx.h b/drivers/staging/ccree/cc_crypto_ctx.h
index ac39d34..c5784bc 100644
--- a/drivers/staging/ccree/cc_crypto_ctx.h
+++ b/drivers/staging/ccree/cc_crypto_ctx.h
@@ -279,9 +279,9 @@ struct drv_ctx_aead {
/* Get the address of a @member within a given @ctx address
-   @ctx: The context address
-   @type: Type of context structure
-   @member: Associated context field */
+ * @ctx: The context address
+ * @type: Type of context structure
+ * @member: Associated context field */
 #define GET_CTX_FIELD_ADDR(ctx, type, member) (ctx + offsetof(type, member))
 #endif /* _CC_CRYPTO_CTX_H_ */
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-03 14:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 12:54 [PATCH] Staging: ccree: cc_crypto_ctx.h: Fixed a comment coding style issue srishti sharma
2017-06-03  8:36 ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-05-31 12:06 srishti sharma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).