* [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.
@ 2017-06-02 22:45 srishti sharma
2017-06-03 8:37 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: srishti sharma @ 2017-06-02 22:45 UTC (permalink / raw)
To: gilad
Cc: gregkh, linux-crypto, driverdev-devel, devel, linux-kernel,
srishti sharma
Fixed a pointer declaration error , the dereferencing operator was misplaced.
Signed-off-by: srishti sharma <srishtishar@gmail.com>
---
drivers/staging/ccree/ssi_aead.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_aead.h b/drivers/staging/ccree/ssi_aead.h
index 654a181..9cf5225 100644
--- a/drivers/staging/ccree/ssi_aead.h
+++ b/drivers/staging/ccree/ssi_aead.h
@@ -97,8 +97,8 @@ struct aead_req_ctx {
struct ssi_mlli assoc;
struct ssi_mlli src;
struct ssi_mlli dst;
- struct scatterlist* srcSgl;
- struct scatterlist* dstSgl;
+ struct scatterlist *srcSgl;
+ struct scatterlist *dstSgl;
unsigned int srcOffset;
unsigned int dstOffset;
enum ssi_req_dma_buf_type assoc_buff_type;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.
2017-06-02 22:45 [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error srishti sharma
@ 2017-06-03 8:37 ` Greg KH
2017-06-03 17:58 ` srishti sharma
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-06-03 8:37 UTC (permalink / raw)
To: srishti sharma; +Cc: gilad, devel, driverdev-devel, linux-kernel, linux-crypto
On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote:
> Fixed a pointer declaration error , the dereferencing operator was misplaced.
Odd use of a ,
Also, I don't understand what was "misplaced" here? There does not seem
to be a "error" fixed here...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error.
2017-06-03 8:37 ` Greg KH
@ 2017-06-03 17:58 ` srishti sharma
0 siblings, 0 replies; 3+ messages in thread
From: srishti sharma @ 2017-06-03 17:58 UTC (permalink / raw)
To: Greg KH
Cc: Gilad Ben-Yossef, devel, driverdev-devel, linux-kernel, linux-crypto
Hey,
checkpatch.pl generated two errors , because the dereferencing
operator was placed next to the structure name instead of being placed
with the pointer .
for eg:
struct scatterlist* srcSgl; (this was giving an error)
whereas
struct scatterlist *srcSgl; (this did not give an error)
Both of them will compile , but the second one is a better
representation of it and does not produce an error on running
checkpatch.pl .
Regards,
Srishti
On Sat, Jun 3, 2017 at 2:07 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Jun 03, 2017 at 04:15:17AM +0530, srishti sharma wrote:
>> Fixed a pointer declaration error , the dereferencing operator was misplaced.
>
> Odd use of a ,
>
> Also, I don't understand what was "misplaced" here? There does not seem
> to be a "error" fixed here...
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-03 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 22:45 [PATCH] Staging: ccree: ssi_aead.h: Fixed a pointer declaration error srishti sharma
2017-06-03 8:37 ` Greg KH
2017-06-03 17:58 ` srishti sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).