* [PATCH] usb: gadget: bdc: 64-bit pointer capability check
@ 2017-06-15 9:09 Srinath Mannam
2017-06-16 18:12 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Srinath Mannam @ 2017-06-15 9:09 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, bcm-kernel-feedback-list, Srinath Mannam
Corrected the register to check the 64-bit pointer
capability state. 64-bit pointer implementation capability
was checking in wrong register, which causes the BDC
enumeration failure in 64-bit memory address.
Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for
Broadcom USB3.0 device controller IP BDC")
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index ccb9c21..e9bd8d4 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -475,7 +475,7 @@ static int bdc_probe(struct platform_device *pdev)
bdc->dev = dev;
dev_dbg(bdc->dev, "bdc->regs: %p irq=%d\n", bdc->regs, bdc->irq);
- temp = bdc_readl(bdc->regs, BDC_BDCSC);
+ temp = bdc_readl(bdc->regs, BDC_BDCCAP1);
if ((temp & BDC_P64) &&
!dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64))) {
dev_dbg(bdc->dev, "Using 64-bit address\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: gadget: bdc: 64-bit pointer capability check
2017-06-15 9:09 [PATCH] usb: gadget: bdc: 64-bit pointer capability check Srinath Mannam
@ 2017-06-16 18:12 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2017-06-16 18:12 UTC (permalink / raw)
To: Srinath Mannam, Felipe Balbi, Greg Kroah-Hartman
Cc: linux-usb, linux-kernel, bcm-kernel-feedback-list
On 06/15/2017 02:09 AM, Srinath Mannam wrote:
> Corrected the register to check the 64-bit pointer
> capability state. 64-bit pointer implementation capability
> was checking in wrong register, which causes the BDC
> enumeration failure in 64-bit memory address.
>
> Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for
> Broadcom USB3.0 device controller IP BDC")
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-16 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-15 9:09 [PATCH] usb: gadget: bdc: 64-bit pointer capability check Srinath Mannam
2017-06-16 18:12 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).