* [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0
@ 2017-06-23 14:35 Mario Limonciello
2017-06-23 21:18 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2017-06-23 14:35 UTC (permalink / raw)
To: dvhart; +Cc: LKML, platform-driver-x86, Mario Limonciello, Louis Davis
Pali recently noticed that WMI instances are zero indexed.
The only reason that these calls all worked properly is because the ASL
didn't verify the instance number.
Signed-off-by: Louis Davis <louis.davis@dell.com>
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
---
drivers/platform/x86/dell-wmi-led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell-wmi-led.c b/drivers/platform/x86/dell-wmi-led.c
index a0c7e99..5bedaf7 100644
--- a/drivers/platform/x86/dell-wmi-led.c
+++ b/drivers/platform/x86/dell-wmi-led.c
@@ -68,7 +68,7 @@ static int dell_led_perform_fn(u8 length, u8 result_code, u8 device_id,
input.length = sizeof(struct bios_args);
input.pointer = &args;
- status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
+ status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 0, 1, &input, &output);
if (ACPI_FAILURE(status))
return status;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0
2017-06-23 14:35 [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 Mario Limonciello
@ 2017-06-23 21:18 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2017-06-23 21:18 UTC (permalink / raw)
To: Mario Limonciello; +Cc: LKML, platform-driver-x86, Louis Davis
On Fri, Jun 23, 2017 at 09:35:21AM -0500, Mario Limonciello wrote:
> Pali recently noticed that WMI instances are zero indexed.
>
> The only reason that these calls all worked properly is because the ASL
> didn't verify the instance number.
>
> Signed-off-by: Louis Davis <louis.davis@dell.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Thanks, queued to testing.
--
Darren Hart
VMware Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-23 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-23 14:35 [PATCH] dell-wmi-led: Adjust instance of all wmi_evaluate_method calls to 0 Mario Limonciello
2017-06-23 21:18 ` Darren Hart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).