* [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.
@ 2017-06-24 16:24 Christos Gkekas
2017-06-26 7:17 ` Rangankar, Manish
2017-06-26 17:43 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Christos Gkekas @ 2017-06-24 16:24 UTC (permalink / raw)
To: QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Cc: Christos Gkekas
Variable idx is defined as u16 thus statement (idx < 0) is
always false and should be removed.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/scsi/qedi/qedi_fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
index e937490..19254bd 100644
--- a/drivers/scsi/qedi/qedi_fw.c
+++ b/drivers/scsi/qedi/qedi_fw.c
@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
/* Obtain buffer address from rqe_opaque */
idx = cqe->rqe_opaque.lo;
- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+ if (idx > (QEDI_BDQ_NUM - 1)) {
QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
"wrong idx %d returned by FW, dropping the unsolicited pkt\n",
idx);
@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,
/* Obtain buffer address from rqe_opaque */
idx = cqe->rqe_opaque.lo;
- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
+ if (idx > (QEDI_BDQ_NUM - 1)) {
QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
"wrong idx %d returned by FW, dropping the unsolicited pkt\n",
idx);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.
2017-06-24 16:24 [PATCH] scsi: qedi: Remove comparison of u16 idx with zero Christos Gkekas
@ 2017-06-26 7:17 ` Rangankar, Manish
2017-06-26 17:43 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Rangankar, Manish @ 2017-06-26 7:17 UTC (permalink / raw)
To: Christos Gkekas, Dept-Eng QLogic Storage Upstream,
James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
On 24/06/17 9:54 PM, "Christos Gkekas" <chris.gekas@gmail.com> wrote:
>Variable idx is defined as u16 thus statement (idx < 0) is
>always false and should be removed.
>
>Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
>---
> drivers/scsi/qedi/qedi_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
>index e937490..19254bd 100644
>--- a/drivers/scsi/qedi/qedi_fw.c
>+++ b/drivers/scsi/qedi/qedi_fw.c
>@@ -333,7 +333,7 @@ static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
>
> /* Obtain buffer address from rqe_opaque */
> idx = cqe->rqe_opaque.lo;
>- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+ if (idx > (QEDI_BDQ_NUM - 1)) {
> QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> idx);
>@@ -370,7 +370,7 @@ static void qedi_put_rq_bdq_buf(struct qedi_ctx *qedi,
>
> /* Obtain buffer address from rqe_opaque */
> idx = cqe->rqe_opaque.lo;
>- if ((idx < 0) || (idx > (QEDI_BDQ_NUM - 1))) {
>+ if (idx > (QEDI_BDQ_NUM - 1)) {
> QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_CONN,
> "wrong idx %d returned by FW, dropping the unsolicited pkt\n",
> idx);
>--
>2.7.4
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: Remove comparison of u16 idx with zero.
2017-06-24 16:24 [PATCH] scsi: qedi: Remove comparison of u16 idx with zero Christos Gkekas
2017-06-26 7:17 ` Rangankar, Manish
@ 2017-06-26 17:43 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-06-26 17:43 UTC (permalink / raw)
To: Christos Gkekas
Cc: QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Christos,
> Variable idx is defined as u16 thus statement (idx < 0) is always
> false and should be removed.
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-26 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-24 16:24 [PATCH] scsi: qedi: Remove comparison of u16 idx with zero Christos Gkekas
2017-06-26 7:17 ` Rangankar, Manish
2017-06-26 17:43 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).