linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Rui <rui.zhang@intel.com>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, edubezval@gmail.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure
Date: Thu, 29 Jun 2017 11:00:19 +0800	[thread overview]
Message-ID: <1498705219.2510.4.camel@intel.com> (raw)
In-Reply-To: <1498028988-12916-1-git-send-email-bhumirks@gmail.com>

On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote:
> Declare thermal_cooling_device_ops structure as const as it is only
> passed
> as an argument to the function thermal_cooling_device_register and
> this
> argument is of type const. So, declare the structure as const.
> 
I checked the source and the code is written in this way as well in
some other drivers, why not fix them altogether?

thanks,
rui
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/thermal/intel_powerclamp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/intel_powerclamp.c
> index d718cd1..e4c68b7 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -659,7 +659,7 @@ static int powerclamp_set_cur_state(struct
> thermal_cooling_device *cdev,
>  }
>  
>  /* bind to generic thermal layer as cooling device*/
> -static struct thermal_cooling_device_ops powerclamp_cooling_ops = {
> +static const struct thermal_cooling_device_ops
> powerclamp_cooling_ops = {
>  	.get_max_state = powerclamp_get_max_state,
>  	.get_cur_state = powerclamp_get_cur_state,
>  	.set_cur_state = powerclamp_set_cur_state,

  reply	other threads:[~2017-06-29  3:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  7:09 [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure Bhumika Goyal
2017-06-29  3:00 ` Zhang Rui [this message]
2017-06-29  5:11   ` Bhumika Goyal
2017-06-29  5:32     ` Zhang Rui
2017-06-29  5:56       ` Bhumika Goyal
2017-06-29 12:08         ` Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498705219.2510.4.camel@intel.com \
    --to=rui.zhang@intel.com \
    --cc=bhumirks@gmail.com \
    --cc=edubezval@gmail.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).