* [PATCH] arm64: dts: ls1012a: add USB host controller nodes
@ 2017-07-05 2:54 Ran Wang
2017-07-13 8:07 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Ran Wang @ 2017-07-05 2:54 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon
Cc: Shawn Guo, Yuantian Tang, Harninder Rai, Ran Wang, horia.geanta,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
open list
LS1012A has one USB 3.0(DWC3) controller and
one USB 2.0 controller.
Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index b497ac1..8aa2dcf 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -411,6 +411,23 @@
<&clockgen 4 3>;
};
+ usb0: usb3@2f00000 {
+ compatible = "snps,dwc3";
+ reg = <0x0 0x2f00000 0x0 0x10000>;
+ interrupts = <0 60 0x4>;
+ dr_mode = "host";
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,dis_rxdet_inp3_quirk;
+ };
+
+ usb1: usb2@8600000 {
+ compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
+ reg = <0x0 0x8600000 0x0 0x1000>;
+ interrupts = <0 139 0x4>;
+ dr_mode = "host";
+ phy_type = "ulpi";
+ };
+
sata: sata@3200000 {
compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
reg = <0x0 0x3200000 0x0 0x10000>,
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
2017-07-05 2:54 [PATCH] arm64: dts: ls1012a: add USB host controller nodes Ran Wang
@ 2017-07-13 8:07 ` Shawn Guo
2017-07-13 8:46 ` Ran Wang
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2017-07-13 8:07 UTC (permalink / raw)
To: Ran Wang
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Yuantian Tang, Harninder Rai, horia.geanta,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
open list
On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:
> LS1012A has one USB 3.0(DWC3) controller and
> one USB 2.0 controller.
>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> index b497ac1..8aa2dcf 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> @@ -411,6 +411,23 @@
> <&clockgen 4 3>;
> };
>
> + usb0: usb3@2f00000 {
> + compatible = "snps,dwc3";
> + reg = <0x0 0x2f00000 0x0 0x10000>;
> + interrupts = <0 60 0x4>;
> + dr_mode = "host";
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,dis_rxdet_inp3_quirk;
> + };
> +
> + usb1: usb2@8600000 {
> + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> + reg = <0x0 0x8600000 0x0 0x1000>;
> + interrupts = <0 139 0x4>;
> + dr_mode = "host";
> + phy_type = "ulpi";
> + };
Please keep the nodes sorted in unit-address.
Shawn
> +
> sata: sata@3200000 {
> compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> reg = <0x0 0x3200000 0x0 0x10000>,
> --
> 2.1.0.27.g96db324
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
2017-07-13 8:07 ` Shawn Guo
@ 2017-07-13 8:46 ` Ran Wang
2017-07-13 8:57 ` Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Ran Wang @ 2017-07-13 8:46 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Andy Tang, Harninder Rai, Horia Geantă,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
open list
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, July 13, 2017 4:07 PM
> To: Ran Wang <ran.wang_1@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Catalin Marinas <catalin.marinas@arm.com>; Will
> Deacon <will.deacon@arm.com>; Andy Tang <andy.tang@nxp.com>; Harninder
> Rai <harninder.rai@nxp.com>; Horia Geantă <horia.geanta@nxp.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; moderated list:ARM64 PORT (AARCH64
> ARCHITECTURE) <linux-arm-kernel@lists.infradead.org>; open list <linux-
> kernel@vger.kernel.org>
> Subject: Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
>
> On Wed, Jul 05, 2017 at 10:54:03AM +0800, Ran Wang wrote:
> > LS1012A has one USB 3.0(DWC3) controller and one USB 2.0 controller.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > index b497ac1..8aa2dcf 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > @@ -411,6 +411,23 @@
> > <&clockgen 4 3>;
> > };
> >
> > + usb0: usb3@2f00000 {
> > + compatible = "snps,dwc3";
> > + reg = <0x0 0x2f00000 0x0 0x10000>;
> > + interrupts = <0 60 0x4>;
> > + dr_mode = "host";
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,dis_rxdet_inp3_quirk;
> > + };
> > +
> > + usb1: usb2@8600000 {
> > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > + reg = <0x0 0x8600000 0x0 0x1000>;
> > + interrupts = <0 139 0x4>;
> > + dr_mode = "host";
> > + phy_type = "ulpi";
> > + };
>
> Please keep the nodes sorted in unit-address.
>
> Shawn
Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before '@8600000 '?
I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.
Ran
>
> > +
> > sata: sata@3200000 {
> > compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > reg = <0x0 0x3200000 0x0 0x10000>,
> > --
> > 2.1.0.27.g96db324
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: ls1012a: add USB host controller nodes
2017-07-13 8:46 ` Ran Wang
@ 2017-07-13 8:57 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-07-13 8:57 UTC (permalink / raw)
To: Ran Wang
Cc: Rob Herring, Mark Rutland, Catalin Marinas, Will Deacon,
Andy Tang, Harninder Rai, Horia Geantă,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM64 PORT (AARCH64 ARCHITECTURE),
open list
On Thu, Jul 13, 2017 at 08:46:50AM +0000, Ran Wang wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > index b497ac1..8aa2dcf 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > > @@ -411,6 +411,23 @@
> > > <&clockgen 4 3>;
> > > };
> > >
> > > + usb0: usb3@2f00000 {
> > > + compatible = "snps,dwc3";
> > > + reg = <0x0 0x2f00000 0x0 0x10000>;
> > > + interrupts = <0 60 0x4>;
> > > + dr_mode = "host";
> > > + snps,quirk-frame-length-adjustment = <0x20>;
> > > + snps,dis_rxdet_inp3_quirk;
> > > + };
> > > +
> > > + usb1: usb2@8600000 {
> > > + compatible = "fsl-usb2-dr-v2.5", "fsl-usb2-dr";
> > > + reg = <0x0 0x8600000 0x0 0x1000>;
> > > + interrupts = <0 139 0x4>;
> > > + dr_mode = "host";
> > > + phy_type = "ulpi";
> > > + };
> >
> > Please keep the nodes sorted in unit-address.
> >
> > Shawn
> Do you mean to move the node 'usb1: usb2@8600000' forward to where it's address is just before '@8600000 '?
> I think it's reasonable to put USB controller nodes together in DTS for developer to do issue analysis.
The nodes under simple-bus are maintained in order of unit-address.
Please respect that.
usb2@8600000 should go after sata@3200000 with the current nodes.
Shawn
> > > +
> > > sata: sata@3200000 {
> > > compatible = "fsl,ls1012a-ahci", "fsl,ls1043a-ahci";
> > > reg = <0x0 0x3200000 0x0 0x10000>,
> > > --
> > > 2.1.0.27.g96db324
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-13 8:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-05 2:54 [PATCH] arm64: dts: ls1012a: add USB host controller nodes Ran Wang
2017-07-13 8:07 ` Shawn Guo
2017-07-13 8:46 ` Ran Wang
2017-07-13 8:57 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).