linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ptp: dte: Use LL suffix for 64-bit constants
@ 2017-07-06  8:34 Geert Uytterhoeven
  2017-07-06 10:41 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-07-06  8:34 UTC (permalink / raw)
  To: Arun Parameswaran, Richard Cochran, David S . Miller
  Cc: Arnd Bergmann, netdev, linux-kernel, Geert Uytterhoeven

With gcc 4.1.2:

    drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’:
    drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for ‘long’ type
    drivers/ptp/ptp_dte.c:112: warning: integer constant is too large for ‘long’ type
    drivers/ptp/ptp_dte.c:114: warning: integer constant is too large for ‘long’ type

Add the missing "LL" suffix to fix this.

Fixes: 8a56aa107f1e8123 ("ptp: Add a ptp clock driver for Broadcom DTE")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/ptp/ptp_dte.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ptp/ptp_dte.c b/drivers/ptp/ptp_dte.c
index 00145a3f1e707451..faf6f7a837137408 100644
--- a/drivers/ptp/ptp_dte.c
+++ b/drivers/ptp/ptp_dte.c
@@ -40,7 +40,7 @@
 #define DTE_WRAP_AROUND_NSEC_SHIFT 44
 
 /* 44 bits NCO */
-#define DTE_NCO_MAX_NS	0xFFFFFFFFFFF
+#define DTE_NCO_MAX_NS	0xFFFFFFFFFFFLL
 
 /* 125MHz with 3.29 reg cfg */
 #define DTE_PPB_ADJ(ppb) (u32)(div64_u64((((u64)abs(ppb) * BIT(28)) +\
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ptp: dte: Use LL suffix for 64-bit constants
  2017-07-06  8:34 [PATCH] ptp: dte: Use LL suffix for 64-bit constants Geert Uytterhoeven
@ 2017-07-06 10:41 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-07-06 10:41 UTC (permalink / raw)
  To: geert; +Cc: arun.parameswaran, richardcochran, arnd, netdev, linux-kernel

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  6 Jul 2017 10:34:54 +0200

> With gcc 4.1.2:
> 
>     drivers/ptp/ptp_dte.c: In function ‘dte_write_nco_delta’:
>     drivers/ptp/ptp_dte.c:105: warning: integer constant is too large for ‘long’ type
>     drivers/ptp/ptp_dte.c:112: warning: integer constant is too large for ‘long’ type
>     drivers/ptp/ptp_dte.c:114: warning: integer constant is too large for ‘long’ type
> 
> Add the missing "LL" suffix to fix this.
> 
> Fixes: 8a56aa107f1e8123 ("ptp: Add a ptp clock driver for Broadcom DTE")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-06 10:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06  8:34 [PATCH] ptp: dte: Use LL suffix for 64-bit constants Geert Uytterhoeven
2017-07-06 10:41 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).