From: Sinan Kaya <okaya@kernel.org>
To: "Zhao, Haifeng" <haifeng.zhao@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"oohall@gmail.com" <oohall@gmail.com>,
"ruscur@russell.cc" <ruscur@russell.cc>,
"lukas@wunner.de" <lukas@wunner.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"stuart.w.hayes@gmail.com" <stuart.w.hayes@gmail.com>,
"mr.nuke.me@gmail.com" <mr.nuke.me@gmail.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
Keith Busch <keith.busch@intel.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jia, Pei P" <pei.p.jia@intel.com>,
"ashok.raj@linux.intel.com" <ashok.raj@linux.intel.com>,
"Kuppuswamy,
Sathyanarayanan" <sathyanarayanan.kuppuswamy@intel.com>
Subject: Re: [PATCH 2/5 V2] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC
Date: Mon, 28 Sep 2020 07:10:17 -0400 [thread overview]
Message-ID: <14b7d988-212b-93dc-6fa6-6b155d5c8ac3@kernel.org> (raw)
In-Reply-To: <MWHPR11MB1696BA6B8473248A8638FD3797350@MWHPR11MB1696.namprd11.prod.outlook.com>
On 9/27/2020 10:01 PM, Zhao, Haifeng wrote:
> Sinan,
> I explained the reason why locks don't protect this case in the patch description part.
> Write side and read side hold different semaphore and mutex.
>
I have been thinking about it some time but is there any reason why we
have to handle all port AER/DPC/HP events in different threads?
Can we go to single threaded event loop for all port drivers events?
This will require some refactoring but it wlll eliminate the lock
nightmares we are having.
This means no sleeping. All sleeps need to happen outside of the loop.
I wanted to see what you all are thinking about this.
It might become a performance problem if the system is
continuously observing a hotplug/aer/dpc events.
I always think that these should be rare events.
next prev parent reply other threads:[~2020-09-28 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 3:28 [PATCH 0/5 V2] Fix DPC hotplug race and enhance error handling Ethan Zhao
2020-09-27 3:28 ` [PATCH 1/5 V2] PCI: define a function to check and wait till port finish DPC handling Ethan Zhao
2020-09-27 6:23 ` Christoph Hellwig
2020-09-27 6:43 ` Zhao, Haifeng
2020-09-29 2:32 ` Ethan Zhao
2020-09-27 3:28 ` [PATCH 2/5 V2] PCI: pciehp: check and wait port status out of DPC before handling DLLSC and PDC Ethan Zhao
2020-09-27 15:27 ` Sinan Kaya
2020-09-28 2:01 ` Zhao, Haifeng
2020-09-28 11:10 ` Sinan Kaya [this message]
2020-09-28 16:43 ` Sinan Kaya
2020-09-28 16:44 ` Kuppuswamy, Sathyanarayanan
2020-09-29 2:28 ` Ethan Zhao
2020-09-29 2:50 ` Ethan Zhao
2020-09-29 8:18 ` Lukas Wunner
2020-09-29 9:46 ` Ethan Zhao
2020-09-29 10:07 ` Lukas Wunner
2020-09-30 2:20 ` Ethan Zhao
2020-09-27 3:28 ` [PATCH 3/5 V2] PCI/ERR: get device before call device driver to avoid NULL pointer reference Ethan Zhao
2020-09-27 3:28 ` [PATCH 4/5 V2] PCI: only return true when dev io state is really changed Ethan Zhao
2020-09-27 4:16 ` Joe Perches
2020-09-27 5:12 ` Zhao, Haifeng
2020-09-27 3:28 ` [PATCH 5/5 V2] PCI/ERR: don't mix io state not changed and no driver together Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b7d988-212b-93dc-6fa6-6b155d5c8ac3@kernel.org \
--to=okaya@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ashok.raj@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=haifeng.zhao@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
--cc=oohall@gmail.com \
--cc=pei.p.jia@intel.com \
--cc=ruscur@russell.cc \
--cc=sathyanarayanan.kuppuswamy@intel.com \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).