From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>, Tom Vaden <tom.vaden@hpe.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH 05/18] ia64: replace setup_irq() by request_irq()
Date: Wed, 12 Feb 2020 13:33:19 +0530 [thread overview]
Message-ID: <14bfa52a434351ea6612d514b033e9dbb73a9727.1581478324.git.afzal.mohd.ma@gmail.com> (raw)
In-Reply-To: <cover.1581478323.git.afzal.mohd.ma@gmail.com>
request_irq() is preferred over setup_irq(). Existing callers of
setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
memory allocators are ready by 'mm_init()'.
Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
Seldom remove_irq() usage has been observed coupled with setup_irq(),
wherever that has been found, it too has been replaced by free_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---
Since cc'ing cover letter to all maintainers/reviewers would be too
many, refer for cover letter,
https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com
arch/ia64/kernel/irq_ia64.c | 42 ++++++++++--------------------
arch/ia64/kernel/mca.c | 51 +++++++++++--------------------------
2 files changed, 29 insertions(+), 64 deletions(-)
diff --git a/arch/ia64/kernel/irq_ia64.c b/arch/ia64/kernel/irq_ia64.c
index 8e91c86e8072..166a38dae663 100644
--- a/arch/ia64/kernel/irq_ia64.c
+++ b/arch/ia64/kernel/irq_ia64.c
@@ -351,11 +351,6 @@ static irqreturn_t smp_irq_move_cleanup_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static struct irqaction irq_move_irqaction = {
- .handler = smp_irq_move_cleanup_interrupt,
- .name = "irq_move"
-};
-
static int __init parse_vector_domain(char *arg)
{
if (!arg)
@@ -586,28 +581,15 @@ static irqreturn_t dummy_handler (int irq, void *dev_id)
return IRQ_NONE;
}
-static struct irqaction ipi_irqaction = {
- .handler = handle_IPI,
- .name = "IPI"
-};
-
/*
* KVM uses this interrupt to force a cpu out of guest mode
*/
-static struct irqaction resched_irqaction = {
- .handler = dummy_handler,
- .name = "resched"
-};
-
-static struct irqaction tlb_irqaction = {
- .handler = dummy_handler,
- .name = "tlb_flush"
-};
#endif
void
-ia64_native_register_percpu_irq (ia64_vector vec, struct irqaction *action)
+ia64_native_register_percpu_irq(ia64_vector vec, const char *name,
+ irq_handler_t handler)
{
unsigned int irq;
@@ -615,8 +597,9 @@ ia64_native_register_percpu_irq (ia64_vector vec, struct irqaction *action)
BUG_ON(bind_irq_vector(irq, vec, CPU_MASK_ALL));
irq_set_status_flags(irq, IRQ_PER_CPU);
irq_set_chip(irq, &irq_type_ia64_lsapic);
- if (action)
- setup_irq(irq, action);
+ if (handler)
+ if (request_irq(irq, handler, 0, name, NULL))
+ pr_err("request_irq() for %s failed", name);
irq_set_handler(irq, handle_percpu_irq);
}
@@ -624,9 +607,10 @@ void __init
ia64_native_register_ipi(void)
{
#ifdef CONFIG_SMP
- register_percpu_irq(IA64_IPI_VECTOR, &ipi_irqaction);
- register_percpu_irq(IA64_IPI_RESCHEDULE, &resched_irqaction);
- register_percpu_irq(IA64_IPI_LOCAL_TLB_FLUSH, &tlb_irqaction);
+ register_percpu_irq(IA64_IPI_VECTOR, "IPI", handle_IPI);
+ register_percpu_irq(IA64_IPI_RESCHEDULE, "resched", dummy_handler);
+ register_percpu_irq(IA64_IPI_LOCAL_TLB_FLUSH, "tlb_flush",
+ dummy_handler);
#endif
}
@@ -635,10 +619,12 @@ init_IRQ (void)
{
acpi_boot_init();
ia64_register_ipi();
- register_percpu_irq(IA64_SPURIOUS_INT_VECTOR, NULL);
+ register_percpu_irq(IA64_SPURIOUS_INT_VECTOR, NULL, NULL);
#ifdef CONFIG_SMP
- if (vector_domain_type != VECTOR_DOMAIN_NONE)
- register_percpu_irq(IA64_IRQ_MOVE_VECTOR, &irq_move_irqaction);
+ if (vector_domain_type != VECTOR_DOMAIN_NONE) {
+ register_percpu_irq(IA64_IRQ_MOVE_VECTOR, "irq_move",
+ smp_irq_move_cleanup_interrupt);
+ }
#endif
#ifdef CONFIG_PERFMON
pfm_init_percpu();
diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c
index bf2cb9294795..f4be4ad7bf0d 100644
--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -1766,36 +1766,6 @@ ia64_mca_disable_cpe_polling(char *str)
__setup("disable_cpe_poll", ia64_mca_disable_cpe_polling);
-static struct irqaction cmci_irqaction = {
- .handler = ia64_mca_cmc_int_handler,
- .name = "cmc_hndlr"
-};
-
-static struct irqaction cmcp_irqaction = {
- .handler = ia64_mca_cmc_int_caller,
- .name = "cmc_poll"
-};
-
-static struct irqaction mca_rdzv_irqaction = {
- .handler = ia64_mca_rendez_int_handler,
- .name = "mca_rdzv"
-};
-
-static struct irqaction mca_wkup_irqaction = {
- .handler = ia64_mca_wakeup_int_handler,
- .name = "mca_wkup"
-};
-
-static struct irqaction mca_cpe_irqaction = {
- .handler = ia64_mca_cpe_int_handler,
- .name = "cpe_hndlr"
-};
-
-static struct irqaction mca_cpep_irqaction = {
- .handler = ia64_mca_cpe_int_caller,
- .name = "cpe_poll"
-};
-
/* Minimal format of the MCA/INIT stacks. The pseudo processes that run on
* these stacks can never sleep, they cannot return from the kernel to user
* space, they do not appear in a normal ps listing. So there is no need to
@@ -2056,18 +2026,23 @@ void __init ia64_mca_irq_init(void)
* Configure the CMCI/P vector and handler. Interrupts for CMC are
* per-processor, so AP CMC interrupts are setup in smp_callin() (smpboot.c).
*/
- register_percpu_irq(IA64_CMC_VECTOR, &cmci_irqaction);
- register_percpu_irq(IA64_CMCP_VECTOR, &cmcp_irqaction);
+ register_percpu_irq(IA64_CMC_VECTOR, "cmc_hndlr",
+ ia64_mca_cmc_int_handler);
+ register_percpu_irq(IA64_CMCP_VECTOR, "cmc_poll",
+ ia64_mca_cmc_int_caller);
ia64_mca_cmc_vector_setup(); /* Setup vector on BSP */
/* Setup the MCA rendezvous interrupt vector */
- register_percpu_irq(IA64_MCA_RENDEZ_VECTOR, &mca_rdzv_irqaction);
+ register_percpu_irq(IA64_MCA_RENDEZ_VECTOR, "mca_rdzv",
+ ia64_mca_rendez_int_handler);
/* Setup the MCA wakeup interrupt vector */
- register_percpu_irq(IA64_MCA_WAKEUP_VECTOR, &mca_wkup_irqaction);
+ register_percpu_irq(IA64_MCA_WAKEUP_VECTOR, "mca_wkup",
+ ia64_mca_wakeup_int_handler);
/* Setup the CPEI/P handler */
- register_percpu_irq(IA64_CPEP_VECTOR, &mca_cpep_irqaction);
+ register_percpu_irq(IA64_CPEP_VECTOR, "cpe_poll",
+ ia64_mca_cpe_int_caller);
}
/*
@@ -2108,7 +2083,11 @@ ia64_mca_late_init(void)
if (irq > 0) {
cpe_poll_enabled = 0;
irq_set_status_flags(irq, IRQ_PER_CPU);
- setup_irq(irq, &mca_cpe_irqaction);
+ if (request_irq(irq, ia64_mca_cpe_int_handler,
+ 0, "cpe_hndlr", NULL)) {
+ pr_err("request_irq() on %s failed\n",
+ "cpe_hndlr");
+ }
ia64_cpe_irq = irq;
ia64_mca_register_cpev(cpe_vector);
IA64_MCA_DEBUG("%s: CPEI/P setup and enabled.\n",
--
2.24.1
next prev parent reply other threads:[~2020-02-12 8:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:01 [PATCH 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-12 8:02 ` [PATCH 01/18] alpha: replace setup_irq() by request_irq() afzal mohammed
2020-02-12 8:02 ` [PATCH 02/18] ARM: " afzal mohammed
2020-02-12 8:10 ` Viresh Kumar
2020-02-12 23:27 ` Alexander Sverdlin
2020-02-12 8:02 ` [PATCH 03/18] c6x: " afzal mohammed
2020-02-13 17:37 ` Mark Salter
2020-02-12 8:03 ` [PATCH 04/18] hexagon: " afzal mohammed
2020-02-12 8:03 ` afzal mohammed [this message]
2020-02-12 8:03 ` [PATCH 06/18] m68k: Replace " afzal mohammed
2020-02-12 22:25 ` Finn Thain
2020-02-13 2:03 ` afzal mohammed
2020-02-13 7:11 ` Greg Ungerer
2020-02-14 13:07 ` afzal mohammed
2020-02-12 8:03 ` [PATCH 07/18] microblaze: " afzal mohammed
2020-02-12 8:04 ` [PATCH 08/18] MIPS: " afzal mohammed
2020-02-12 8:04 ` [PATCH 09/18] parisc: " afzal mohammed
2020-02-12 8:04 ` [PATCH 10/18] powerpc: " afzal mohammed
2020-02-13 10:59 ` Christophe Leroy
2020-02-12 8:04 ` [PATCH 11/18] s390: replace " afzal mohammed
2020-02-12 8:04 ` [PATCH 12/18] sh: " afzal mohammed
2020-02-12 8:05 ` [PATCH 13/18] unicore32: " afzal mohammed
2020-02-12 8:05 ` [PATCH 14/18] x86: Replace " afzal mohammed
2020-02-27 10:49 ` Thomas Gleixner
2020-02-27 11:36 ` afzal mohammed
2020-02-27 13:29 ` Thomas Gleixner
2020-02-27 14:26 ` afzal mohammed
2020-02-12 8:05 ` [PATCH 15/18] xtensa: replace " afzal mohammed
2020-02-12 9:10 ` Max Filippov
2020-02-12 8:05 ` [PATCH 16/18] clocksource: Replace " afzal mohammed
2020-02-20 11:13 ` Daniel Lezcano
2020-02-20 14:48 ` Linus Walleij
2020-02-12 8:05 ` [PATCH 17/18] irqchip: " afzal mohammed
[not found] ` <8e00874d072f32496c2d0da05423bda1cadd6975.1581478324.git.afzal.mohd.ma@gmail. com>
2020-02-13 16:02 ` Paul Cercueil
2020-02-12 8:06 ` [PATCH 18/18] genirq: Remove setup_irq() and remove_irq() afzal mohammed
2020-02-20 14:49 ` Linus Walleij
2020-02-27 10:31 ` [PATCH 00/18] genirq: Remove setup_irq() Thomas Gleixner
2020-02-27 11:07 ` afzal mohammed
2020-03-21 17:43 ` afzal mohammed
2020-03-27 16:08 ` [PATCH 0/6] Kill setup_irq() afzal mohammed
2020-03-27 16:09 ` [PATCH v5 1/6] alpha: Replace setup_irq() by request_irq() afzal mohammed
2020-03-27 16:09 ` [PATCH v5 2/6] c6x: replace " afzal mohammed
2020-03-27 16:09 ` [PATCH v5 3/6] hexagon: " afzal mohammed
2020-03-27 16:10 ` [PATCH v5 4/6] sh: " afzal mohammed
2020-03-27 16:10 ` [PATCH v5 5/6] unicore32: " afzal mohammed
2020-03-27 16:11 ` [PATCH v5 6/6] genirq: Remove setup_irq() and remove_irq() afzal mohammed
2020-04-11 14:10 ` afzal mohammed
2020-03-28 2:48 ` [PATCH 0/6] Kill setup_irq() Brian Cain
2020-03-28 7:32 ` afzal mohammed
2020-04-02 15:03 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14bfa52a434351ea6612d514b033e9dbb73a9727.1581478324.git.afzal.mohd.ma@gmail.com \
--to=afzal.mohd.ma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tom.vaden@hpe.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).