From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Juergen Gross <jgross@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: [PATCH 14/18] x86: Replace setup_irq() by request_irq()
Date: Wed, 12 Feb 2020 13:35:15 +0530 [thread overview]
Message-ID: <a3116b3b1a03a943cd89efd57d2db32284c3a574.1581478324.git.afzal.mohd.ma@gmail.com> (raw)
In-Reply-To: <cover.1581478323.git.afzal.mohd.ma@gmail.com>
request_irq() is preferred over setup_irq(). Existing callers of
setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
memory allocators are ready by 'mm_init()'.
Per tglx[1], setup_irq() existed in olden days when allocators were not
ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
Seldom remove_irq() usage has been observed coupled with setup_irq(),
wherever that has been found, it too has been replaced by free_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
---
Since cc'ing cover letter to all maintainers/reviewers would be too
many, refer for cover letter,
https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com
arch/x86/kernel/irqinit.c | 18 +++++++-----------
arch/x86/kernel/time.c | 10 +++-------
2 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/arch/x86/kernel/irqinit.c b/arch/x86/kernel/irqinit.c
index 16919a9671fa..8147075238bf 100644
--- a/arch/x86/kernel/irqinit.c
+++ b/arch/x86/kernel/irqinit.c
@@ -44,15 +44,6 @@
* (these are usually mapped into the 0x30-0xff vector range)
*/
-/*
- * IRQ2 is cascade interrupt to second interrupt controller
- */
-static struct irqaction irq2 = {
- .handler = no_action,
- .name = "cascade",
- .flags = IRQF_NO_THREAD,
-};
-
DEFINE_PER_CPU(vector_irq_t, vector_irq) = {
[0 ... NR_VECTORS - 1] = VECTOR_UNUSED,
};
@@ -104,6 +95,11 @@ void __init native_init_IRQ(void)
idt_setup_apic_and_irq_gates();
lapic_assign_system_vectors();
- if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs())
- setup_irq(2, &irq2);
+ if (!acpi_ioapic && !of_ioapic && nr_legacy_irqs()) {
+ /*
+ * IRQ2 is cascade interrupt to second interrupt controller
+ */
+ if (request_irq(2, no_action, IRQF_NO_THREAD, "cascade", NULL))
+ pr_err("request_irq() on %s failed\n", "cascade");
+ }
}
diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index d8673d8a779b..0f9cb386d71f 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -62,19 +62,15 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
-static struct irqaction irq0 = {
- .handler = timer_interrupt,
- .flags = IRQF_NOBALANCING | IRQF_IRQPOLL | IRQF_TIMER,
- .name = "timer"
-};
-
static void __init setup_default_timer_irq(void)
{
/*
* Unconditionally register the legacy timer; even without legacy
* PIC/PIT we need this for the HPET0 in legacy replacement mode.
*/
- if (setup_irq(0, &irq0))
+ if (request_irq(0, timer_interrupt,
+ IRQF_NOBALANCING | IRQF_IRQPOLL | IRQF_TIMER, "timer",
+ NULL))
pr_info("Failed to register legacy timer interrupt\n");
}
--
2.24.1
next prev parent reply other threads:[~2020-02-12 8:05 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 8:01 [PATCH 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-12 8:02 ` [PATCH 01/18] alpha: replace setup_irq() by request_irq() afzal mohammed
2020-02-12 8:02 ` [PATCH 02/18] ARM: " afzal mohammed
2020-02-12 8:10 ` Viresh Kumar
2020-02-12 23:27 ` Alexander Sverdlin
2020-02-12 8:02 ` [PATCH 03/18] c6x: " afzal mohammed
2020-02-13 17:37 ` Mark Salter
2020-02-12 8:03 ` [PATCH 04/18] hexagon: " afzal mohammed
2020-02-12 8:03 ` [PATCH 05/18] ia64: " afzal mohammed
2020-02-12 8:03 ` [PATCH 06/18] m68k: Replace " afzal mohammed
2020-02-12 22:25 ` Finn Thain
2020-02-13 2:03 ` afzal mohammed
2020-02-13 7:11 ` Greg Ungerer
2020-02-14 13:07 ` afzal mohammed
2020-02-12 8:03 ` [PATCH 07/18] microblaze: " afzal mohammed
2020-02-12 8:04 ` [PATCH 08/18] MIPS: " afzal mohammed
2020-02-12 8:04 ` [PATCH 09/18] parisc: " afzal mohammed
2020-02-12 8:04 ` [PATCH 10/18] powerpc: " afzal mohammed
2020-02-13 10:59 ` Christophe Leroy
2020-02-12 8:04 ` [PATCH 11/18] s390: replace " afzal mohammed
2020-02-12 8:04 ` [PATCH 12/18] sh: " afzal mohammed
2020-02-12 8:05 ` [PATCH 13/18] unicore32: " afzal mohammed
2020-02-12 8:05 ` afzal mohammed [this message]
2020-02-27 10:49 ` [PATCH 14/18] x86: Replace " Thomas Gleixner
2020-02-27 11:36 ` afzal mohammed
2020-02-27 13:29 ` Thomas Gleixner
2020-02-27 14:26 ` afzal mohammed
2020-02-12 8:05 ` [PATCH 15/18] xtensa: replace " afzal mohammed
2020-02-12 9:10 ` Max Filippov
2020-02-12 8:05 ` [PATCH 16/18] clocksource: Replace " afzal mohammed
2020-02-20 11:13 ` Daniel Lezcano
2020-02-20 14:48 ` Linus Walleij
2020-02-12 8:05 ` [PATCH 17/18] irqchip: " afzal mohammed
[not found] ` <8e00874d072f32496c2d0da05423bda1cadd6975.1581478324.git.afzal.mohd.ma@gmail. com>
2020-02-13 16:02 ` Paul Cercueil
2020-02-12 8:06 ` [PATCH 18/18] genirq: Remove setup_irq() and remove_irq() afzal mohammed
2020-02-20 14:49 ` Linus Walleij
2020-02-27 10:31 ` [PATCH 00/18] genirq: Remove setup_irq() Thomas Gleixner
2020-02-27 11:07 ` afzal mohammed
2020-03-21 17:43 ` afzal mohammed
2020-03-27 16:08 ` [PATCH 0/6] Kill setup_irq() afzal mohammed
2020-03-27 16:09 ` [PATCH v5 1/6] alpha: Replace setup_irq() by request_irq() afzal mohammed
2020-03-27 16:09 ` [PATCH v5 2/6] c6x: replace " afzal mohammed
2020-03-27 16:09 ` [PATCH v5 3/6] hexagon: " afzal mohammed
2020-03-27 16:10 ` [PATCH v5 4/6] sh: " afzal mohammed
2020-03-27 16:10 ` [PATCH v5 5/6] unicore32: " afzal mohammed
2020-03-27 16:11 ` [PATCH v5 6/6] genirq: Remove setup_irq() and remove_irq() afzal mohammed
2020-04-11 14:10 ` afzal mohammed
2020-03-28 2:48 ` [PATCH 0/6] Kill setup_irq() Brian Cain
2020-03-28 7:32 ` afzal mohammed
2020-04-02 15:03 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3116b3b1a03a943cd89efd57d2db32284c3a574.1581478324.git.afzal.mohd.ma@gmail.com \
--to=afzal.mohd.ma@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).