* [PATCH] ARM: aspeed: ast2500 is ARMv6K
@ 2019-09-19 14:26 Arnd Bergmann
2019-09-20 3:58 ` Andrew Jeffery
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-19 14:26 UTC (permalink / raw)
To: Joel Stanley
Cc: Arnd Bergmann, Andrew Jeffery, linux-arm-kernel, linux-aspeed,
linux-kernel
Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K
(later ARM1136, ARM1176 and ARM11mpcore).
ast2500 falls into the second categoy, being based on arm1176jzf-s.
This is enabled by default when using ARCH_MULTI_V6, so we should
not 'select CPU_V6'.
Removing this will lead to more efficient use of atomic instructions.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-aspeed/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
index a293137f5814..163931a03136 100644
--- a/arch/arm/mach-aspeed/Kconfig
+++ b/arch/arm/mach-aspeed/Kconfig
@@ -26,7 +26,6 @@ config MACH_ASPEED_G4
config MACH_ASPEED_G5
bool "Aspeed SoC 5th Generation"
depends on ARCH_MULTI_V6
- select CPU_V6
select PINCTRL_ASPEED_G5 if !CC_IS_CLANG
select FTTMR010_TIMER
help
--
2.20.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K
2019-09-19 14:26 [PATCH] ARM: aspeed: ast2500 is ARMv6K Arnd Bergmann
@ 2019-09-20 3:58 ` Andrew Jeffery
2019-09-20 5:51 ` Joel Stanley
2019-09-20 5:54 ` Andrew Jeffery
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2019-09-20 3:58 UTC (permalink / raw)
To: Arnd Bergmann, Joel Stanley; +Cc: linux-arm-kernel, linux-aspeed, linux-kernel
On Thu, 19 Sep 2019, at 23:56, Arnd Bergmann wrote:
> Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K
> (later ARM1136, ARM1176 and ARM11mpcore).
>
> ast2500 falls into the second categoy, being based on arm1176jzf-s.
> This is enabled by default when using ARCH_MULTI_V6, so we should
> not 'select CPU_V6'.
>
> Removing this will lead to more efficient use of atomic instructions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K
2019-09-19 14:26 [PATCH] ARM: aspeed: ast2500 is ARMv6K Arnd Bergmann
2019-09-20 3:58 ` Andrew Jeffery
@ 2019-09-20 5:51 ` Joel Stanley
2019-09-20 7:42 ` Arnd Bergmann
2019-09-20 5:54 ` Andrew Jeffery
2 siblings, 1 reply; 5+ messages in thread
From: Joel Stanley @ 2019-09-20 5:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List
On Thu, 19 Sep 2019 at 14:27, Arnd Bergmann <arnd@arndb.de> wrote:
>
> Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K
> (later ARM1136, ARM1176 and ARM11mpcore).
>
> ast2500 falls into the second categoy, being based on arm1176jzf-s.
> This is enabled by default when using ARCH_MULTI_V6, so we should
> not 'select CPU_V6'.
>
> Removing this will lead to more efficient use of atomic instructions.
Wow, nice find.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-aspeed/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> index a293137f5814..163931a03136 100644
> --- a/arch/arm/mach-aspeed/Kconfig
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -26,7 +26,6 @@ config MACH_ASPEED_G4
> config MACH_ASPEED_G5
> bool "Aspeed SoC 5th Generation"
> depends on ARCH_MULTI_V6
> - select CPU_V6
> select PINCTRL_ASPEED_G5 if !CC_IS_CLANG
I can't find any trees with !CC_IS_CLANG here. Is there a problem
building our pinmux driver with Clang?
I tested with this patch:
--- a/arch/arm/mach-aspeed/Kconfig
+++ b/arch/arm/mach-aspeed/Kconfig
@@ -25,8 +25,8 @@ config MACH_ASPEED_G4
config MACH_ASPEED_G5
bool "Aspeed SoC 5th Generation"
+ # This implies ARMv6K which covers the ARM1176
depends on ARCH_MULTI_V6
- select CPU_V6
select PINCTRL_ASPEED_G5
select FTTMR010_TIMER
help
If you want to apply that as a fix for 5.4 I would be happy with that.
Fixes: 8c2ed9bcfbeb ("arm: Add Aspeed machine")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K
2019-09-20 5:51 ` Joel Stanley
@ 2019-09-20 7:42 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-20 7:42 UTC (permalink / raw)
To: Joel Stanley
Cc: Andrew Jeffery, Linux ARM, linux-aspeed, Linux Kernel Mailing List
On Fri, Sep 20, 2019 at 7:51 AM Joel Stanley <joel@jms.id.au> wrote:
> On Thu, 19 Sep 2019 at 14:27, Arnd Bergmann <arnd@arndb.de> wrote:
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > arch/arm/mach-aspeed/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> > index a293137f5814..163931a03136 100644
> > --- a/arch/arm/mach-aspeed/Kconfig
> > +++ b/arch/arm/mach-aspeed/Kconfig
> > @@ -26,7 +26,6 @@ config MACH_ASPEED_G4
> > config MACH_ASPEED_G5
> > bool "Aspeed SoC 5th Generation"
> > depends on ARCH_MULTI_V6
> > - select CPU_V6
> > select PINCTRL_ASPEED_G5 if !CC_IS_CLANG
>
> I can't find any trees with !CC_IS_CLANG here. Is there a problem
> building our pinmux driver with Clang?
This was an unrelated change from my local randconfig tree.
Your driver uncovered a bug in clang that is now fixed, the driver
itself is fine, see https://bugs.llvm.org/show_bug.cgi?id=43243
> I tested with this patch:
> --- a/arch/arm/mach-aspeed/Kconfig
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -25,8 +25,8 @@ config MACH_ASPEED_G4
>
> config MACH_ASPEED_G5
> bool "Aspeed SoC 5th Generation"
> + # This implies ARMv6K which covers the ARM1176
> depends on ARCH_MULTI_V6
> - select CPU_V6
> select PINCTRL_ASPEED_G5
> select FTTMR010_TIMER
> help
>
> If you want to apply that as a fix for 5.4 I would be happy with that.
>
> Fixes: 8c2ed9bcfbeb ("arm: Add Aspeed machine")
> Reviewed-by: Joel Stanley <joel@jms.id.au>
Applied to arm/fixes now.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K
2019-09-19 14:26 [PATCH] ARM: aspeed: ast2500 is ARMv6K Arnd Bergmann
2019-09-20 3:58 ` Andrew Jeffery
2019-09-20 5:51 ` Joel Stanley
@ 2019-09-20 5:54 ` Andrew Jeffery
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2019-09-20 5:54 UTC (permalink / raw)
To: Arnd Bergmann, Joel Stanley; +Cc: linux-arm-kernel, linux-aspeed, linux-kernel
On Thu, 19 Sep 2019, at 23:56, Arnd Bergmann wrote:
> Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K
> (later ARM1136, ARM1176 and ARM11mpcore).
>
> ast2500 falls into the second categoy, being based on arm1176jzf-s.
> This is enabled by default when using ARCH_MULTI_V6, so we should
> not 'select CPU_V6'.
>
> Removing this will lead to more efficient use of atomic instructions.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-aspeed/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> index a293137f5814..163931a03136 100644
> --- a/arch/arm/mach-aspeed/Kconfig
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -26,7 +26,6 @@ config MACH_ASPEED_G4
> config MACH_ASPEED_G5
> bool "Aspeed SoC 5th Generation"
> depends on ARCH_MULTI_V6
> - select CPU_V6
> select PINCTRL_ASPEED_G5 if !CC_IS_CLANG
Unrelated, but I'm intrigued by this. Looks like I should try compile it with clang
and fix the fallout.
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-20 7:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-19 14:26 [PATCH] ARM: aspeed: ast2500 is ARMv6K Arnd Bergmann
2019-09-20 3:58 ` Andrew Jeffery
2019-09-20 5:51 ` Joel Stanley
2019-09-20 7:42 ` Arnd Bergmann
2019-09-20 5:54 ` Andrew Jeffery
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).