* [PATCH] [media] staging/atomisp: fix minor coding style warnings
@ 2017-07-13 15:06 smklearn
2017-07-13 15:12 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: smklearn @ 2017-07-13 15:06 UTC (permalink / raw)
To: mchehab, gregkh, alan; +Cc: linux-media, devel, linux-kernel, smklearn
Below were the minor issues flagged by checkpatch.pl:
- WARNING: Block comments use * on subsequent lines
- ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Shy More <smklearn@gmail.com>
---
.../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 26 +++++++++++-----------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
index 76d9142..856fb6e 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
@@ -14,18 +14,18 @@
*/
#else
/**
-Support for Intel Camera Imaging ISP subsystem.
-Copyright (c) 2010 - 2015, Intel Corporation.
-
-This program is free software; you can redistribute it and/or modify it
-under the terms and conditions of the GNU General Public License,
-version 2, as published by the Free Software Foundation.
-
-This program is distributed in the hope it will be useful, but WITHOUT
-ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
-FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-more details.
-*/
+ * Support for Intel Camera Imaging ISP subsystem.
+ * Copyright (c) 2010 - 2015, Intel Corporation.
+
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ */
#endif
#include "system_global.h"
@@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
handle = getHandle(i);
if ((handle->start_addr == *start_addr)
- && ( true == handle->active)) {
+ && (true == handle->active)) {
handle->active = false;
ibuf_rsrc.num_active--;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] staging/atomisp: fix minor coding style warnings
2017-07-13 15:06 [PATCH] [media] staging/atomisp: fix minor coding style warnings smklearn
@ 2017-07-13 15:12 ` Greg KH
2017-07-16 23:35 ` [PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning Shy More
2017-07-16 23:38 ` [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue Shy More
0 siblings, 2 replies; 6+ messages in thread
From: Greg KH @ 2017-07-13 15:12 UTC (permalink / raw)
To: smklearn; +Cc: mchehab, alan, devel, linux-kernel, linux-media
On Thu, Jul 13, 2017 at 08:06:21AM -0700, smklearn wrote:
> Below were the minor issues flagged by checkpatch.pl:
> - WARNING: Block comments use * on subsequent lines
> - ERROR: space prohibited after that open parenthesis '('
Don't do multiple things in the same patch please, this should be
multiple patches.
> Signed-off-by: Shy More <smklearn@gmail.com>
This name doesn't match your "From:" name in the email :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning
2017-07-13 15:12 ` Greg KH
@ 2017-07-16 23:35 ` Shy More
2017-07-16 23:38 ` [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue Shy More
1 sibling, 0 replies; 6+ messages in thread
From: Shy More @ 2017-07-16 23:35 UTC (permalink / raw)
Cc: Shy More, Mauro Carvalho Chehab, Greg Kroah-Hartman, Jiri Kosina,
Alan Cox, linux-media, devel, linux-kernel
Below was the trivial wanrning flagged by checkpatch.pl
WARNING: Block comments use * on subsequent lines
Signed-off-by: Shy More <smklearn@gmail.com>
---
.../css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 24 +++++++++++-----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
index 76d9142..bb9f5cd 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
@@ -14,18 +14,18 @@
*/
#else
/**
-Support for Intel Camera Imaging ISP subsystem.
-Copyright (c) 2010 - 2015, Intel Corporation.
-
-This program is free software; you can redistribute it and/or modify it
-under the terms and conditions of the GNU General Public License,
-version 2, as published by the Free Software Foundation.
-
-This program is distributed in the hope it will be useful, but WITHOUT
-ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
-FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
-more details.
-*/
+ * Support for Intel Camera Imaging ISP subsystem.
+ * Copyright (c) 2010 - 2015, Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ */
#endif
#include "system_global.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue
2017-07-13 15:12 ` Greg KH
2017-07-16 23:35 ` [PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning Shy More
@ 2017-07-16 23:38 ` Shy More
2017-07-16 23:57 ` Joe Perches
1 sibling, 1 reply; 6+ messages in thread
From: Shy More @ 2017-07-16 23:38 UTC (permalink / raw)
Cc: Shy More, Mauro Carvalho Chehab, Greg Kroah-Hartman, Jiri Kosina,
Alan Cox, linux-media, devel, linux-kernel
Below was the trival error flagged by checkpatch.pl:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Shy More <smklearn@gmail.com>
---
.../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
index bb9f5cd..99edb81 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
@@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
handle = getHandle(i);
if ((handle->start_addr == *start_addr)
- && ( true == handle->active)) {
+ && (true == handle->active)) {
handle->active = false;
ibuf_rsrc.num_active--;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue
2017-07-16 23:38 ` [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue Shy More
@ 2017-07-16 23:57 ` Joe Perches
2017-07-17 4:10 ` [PATCH v2] " Shy More
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2017-07-16 23:57 UTC (permalink / raw)
To: Shy More
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Jiri Kosina, Alan Cox,
linux-media, devel, linux-kernel
On Sun, 2017-07-16 at 16:38 -0700, Shy More wrote:
> Below was the trival error flagged by checkpatch.pl:
> ERROR: space prohibited after that open parenthesis '('
[]
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
[]
> @@ -131,7 +131,7 @@ void ia_css_isys_ibuf_rmgr_release(
> for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
> handle = getHandle(i);
> if ((handle->start_addr == *start_addr)
> - && ( true == handle->active)) {
> + && (true == handle->active)) {
> handle->active = false;
> ibuf_rsrc.num_active--;
> break;
Better would have been to remove the comparison to true
if (handle->start_addr == *start_addr && handle->active)
but this would probably read better and perhaps be
marginally faster on some processors if written like:
if (handle->active && handle->start_addr == *start_addr)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] [media] staging/atomisp: fixed trivial coding style issue
2017-07-16 23:57 ` Joe Perches
@ 2017-07-17 4:10 ` Shy More
0 siblings, 0 replies; 6+ messages in thread
From: Shy More @ 2017-07-17 4:10 UTC (permalink / raw)
Cc: joe, Shy More, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Jiri Kosina, Alan Cox, linux-media, devel, linux-kernel
Below was the trival error flagged by checkpatch.pl:
ERROR: space prohibited after that open parenthesis '('
Signed-off-by: Shy More <smklearn@gmail.com>
---
changes in v2:
- made the suggested corrections
---
.../atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
index bb9f5cd..faef976 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/isys/src/ibuf_ctrl_rmgr.c
@@ -130,8 +130,7 @@ void ia_css_isys_ibuf_rmgr_release(
for (i = 0; i < ibuf_rsrc.num_allocated; i++) {
handle = getHandle(i);
- if ((handle->start_addr == *start_addr)
- && ( true == handle->active)) {
+ if (handle->active && handle->start_addr == *start_addr) {
handle->active = false;
ibuf_rsrc.num_active--;
break;
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-17 4:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-13 15:06 [PATCH] [media] staging/atomisp: fix minor coding style warnings smklearn
2017-07-13 15:12 ` Greg KH
2017-07-16 23:35 ` [PATCH 1/2] [media] staging/atomisp: fixed trivial coding style warning Shy More
2017-07-16 23:38 ` [PATCH 2/2] [media] staging/atomisp: fixed trivial coding style issue Shy More
2017-07-16 23:57 ` Joe Perches
2017-07-17 4:10 ` [PATCH v2] " Shy More
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).