[PATCH] iommu/exynos: Replace non-existing big-endian Kconfig option

[PATCH] iommu/exynos: Replace non-existing big-endian Kconfig option

[Krzysztof Kozlowski]

Wrong Kconfig option was used when adding warning for untested
big-endian capabilities. There is no CONFIG_BIG_ENDIAN option.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/iommu/exynos-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 2395478dde75..b7aebaf28b82 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -54,7 +54,7 @@ typedef u32 sysmmu_pte_t;
 #define lv2ent_small(pent) ((*(pent) & 2) == 2)
 #define lv2ent_large(pent) ((*(pent) & 3) == 1)
 
-#ifdef CONFIG_BIG_ENDIAN
+#ifdef CONFIG_CPU_BIG_ENDIAN
 #warning "revisit driver if we can enable big-endian ptes"
 #endif
 
-- 
2.7.4

Re: [PATCH] iommu/exynos: Replace non-existing big-endian Kconfig option

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1776 bytes --]

Hi Krzysztof,

[auto build test WARNING on iommu/next]
[also build test WARNING on v4.13-rc1 next-20170717]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/iommu-exynos-Replace-non-existing-big-endian-Kconfig-option/20170717-141202
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

>> drivers//iommu/exynos-iommu.c:58:2: warning: #warning "revisit driver if we can enable big-endian ptes" [-Wcpp]
    #warning "revisit driver if we can enable big-endian ptes"
     ^~~~~~~

vim +58 drivers//iommu/exynos-iommu.c

2a96536e KyongHo Cho         2012-05-12  56  
61dfd0bc Krzysztof Kozlowski 2017-07-17  57  #ifdef CONFIG_CPU_BIG_ENDIAN
6ae5343c Ben Dooks           2016-06-08 @58  #warning "revisit driver if we can enable big-endian ptes"
6ae5343c Ben Dooks           2016-06-08  59  #endif
6ae5343c Ben Dooks           2016-06-08  60  

:::::: The code at line 58 was first introduced by commit
:::::: 6ae5343c26f9cba5e9ef8ba6f23b5bb255ebc798 iommu/exynos: update to use iommu big-endian

:::::: TO: Ben Dooks <ben.dooks@codethink.co.uk>
:::::: CC: Joerg Roedel <jroedel@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62409 bytes --]

Re: [PATCH] iommu/exynos: Replace non-existing big-endian Kconfig option

[Krzysztof Kozlowski]

On Mon, Jul 17, 2017 at 5:25 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Krzysztof,
>
> [auto build test WARNING on iommu/next]
> [also build test WARNING on v4.13-rc1 next-20170717]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url:    https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/iommu-exynos-Replace-non-existing-big-endian-Kconfig-option/20170717-141202
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
> config: arm-allmodconfig (attached as .config)
> compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=arm
>
> All warnings (new ones prefixed by >>):
>
>>> drivers//iommu/exynos-iommu.c:58:2: warning: #warning "revisit driver if we can enable big-endian ptes" [-Wcpp]
>     #warning "revisit driver if we can enable big-endian ptes"
>      ^~~~~~~

FYI,
Everything is fine, this is an expected warning which I am bringing
back to life.

Best regards,
Krzysztof

Re: [PATCH] iommu/exynos: Replace non-existing big-endian Kconfig option

[Joerg Roedel]

On Mon, Jul 17, 2017 at 07:47:02AM +0200, Krzysztof Kozlowski wrote:
> Wrong Kconfig option was used when adding warning for untested
> big-endian capabilities. There is no CONFIG_BIG_ENDIAN option.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/iommu/exynos-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.