[PATCH v5 0/1] acpi: apei: Bug fix to enable APEI support for ARMv8

[PATCH v5 0/1] acpi: apei: Bug fix to enable APEI support for ARMv8

[Loc Ho]

v5:
* Remove the patch set 1/2 as it was accepted
* Fix the signed-off-by using Co-authored-by

v4:
* Update patch commit log for gsi.c patch
* Make change to be 80 column aligned

v3
* Change the title of the patch to reflect the patch
* Completely dropped the driver. Instead, move completely to the FW by
  accessing the GIC directly.
* Fix a bug with function acpi_gsi_to_irq
* Enable APEI multiple GHES source to share an single external IRQ

v2
* Make all code more generic naming
* Still waiting for comment from Linaro folks on APEI

---
Loc Ho (1):
  acpi: apei: Enable APEI multiple GHES source to share an single
    external IRQ

 drivers/acpi/apei/ghes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

[Loc Ho]

This patch allows APEI generic error source table with external
IRQ to share a single IRQ.

Co-authored-by: Tuan Phan <tphan@apm.com>
Signed-off-by: Loc Ho <lho@apm.com>
---
 drivers/acpi/apei/ghes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index d661d45..eed09fc 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -1157,7 +1157,8 @@ static int ghes_probe(struct platform_device *ghes_dev)
 			       generic->header.source_id);
 			goto err_edac_unreg;
 		}
-		rc = request_irq(ghes->irq, ghes_irq_func, 0, "GHES IRQ", ghes);
+		rc = request_irq(ghes->irq, ghes_irq_func, IRQF_SHARED,
+				 "GHES IRQ", ghes);
 		if (rc) {
 			pr_err(GHES_PFX "Failed to register IRQ for generic hardware error source: %d\n",
 			       generic->header.source_id);
-- 
1.8.3.1

Re: [PATCH v5 1/1] acpi: apei: Enable APEI multiple GHES source to share an single external IRQ

[Borislav Petkov]

On Thu, Jul 20, 2017 at 02:36:03PM -0700, Loc Ho wrote:
> This patch allows APEI generic error source table with external

"This patch" in a commit message is tautologically redundant.

> IRQ to share a single IRQ.

Because? More background please.

> Co-authored-by: Tuan Phan <tphan@apm.com>

I guess an invented tag is fine. What you can also do is say in free
text in the commit message that Tuan has helped.

> Signed-off-by: Loc Ho <lho@apm.com>
> ---

...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--