* [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin
@ 2017-07-20 23:50 Marcin Wojtas
2017-08-02 17:16 ` Miquel RAYNAL
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Wojtas @ 2017-07-20 23:50 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: andrew, thomas.petazzoni, gregory.clement, mark.rutland,
marc.zyngier, nadavh, neta, mw, jaz, hannah, zbodek
The ESPRESSObin board exposes one of the SDHCI interfaces
via J1 uSD slot. This patch enables it.
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Signed-off-by: Zbigniew Bodek <zbodek@gmail.com>
---
.../boot/dts/marvell/armada-3720-espressobin.dts | 26 ++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
index b1af3f98..6d0caf1 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
@@ -45,6 +45,7 @@
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
#include "armada-372x.dtsi"
/ {
@@ -59,6 +60,20 @@
device_type = "memory";
reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
};
+
+ vcc_sd_reg1: regulator {
+ compatible = "regulator-gpio";
+ regulator-name = "vcc_sd1";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+
+ gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
+ gpios-states = <0>;
+ states = <1800000 0x1
+ 3300000 0x0>;
+ enable-active-high;
+ };
};
/* J9 */
@@ -71,6 +86,17 @@
status = "okay";
};
+/* J1 */
+&sdhci1 {
+ wp-inverted;
+ bus-width = <4>;
+ cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
+ no-1-8-v;
+ marvell,pad-type = "sd";
+ vqmmc-supply = <&vcc_sd_reg1>;
+ status = "okay";
+};
+
/* Exported on the micro USB connector J5 through an FTDI */
&uart0 {
status = "okay";
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin
2017-07-20 23:50 [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin Marcin Wojtas
@ 2017-08-02 17:16 ` Miquel RAYNAL
2017-08-03 12:23 ` Gregory CLEMENT
0 siblings, 1 reply; 3+ messages in thread
From: Miquel RAYNAL @ 2017-08-02 17:16 UTC (permalink / raw)
To: Marcin Wojtas
Cc: linux-kernel, linux-arm-kernel, thomas.petazzoni, andrew,
marc.zyngier, jaz, hannah, nadavh, neta, gregory.clement,
mark.rutland, zbodek
Hi,
On Fri, 21 Jul 2017 01:50:36 +0200
Marcin Wojtas <mw@semihalf.com> wrote:
> The ESPRESSObin board exposes one of the SDHCI interfaces
> via J1 uSD slot. This patch enables it.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Zbigniew Bodek <zbodek@gmail.com>
Tested-by: Miquel Raynal <miquel.raynal@free-electrons.com>
> ---
> .../boot/dts/marvell/armada-3720-espressobin.dts | 26
> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
> b1af3f98..6d0caf1 100644 ---
> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
> +45,7 @@
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> #include "armada-372x.dtsi"
>
> / {
> @@ -59,6 +60,20 @@
> device_type = "memory";
> reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
> };
> +
> + vcc_sd_reg1: regulator {
> + compatible = "regulator-gpio";
> + regulator-name = "vcc_sd1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> +
> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
> + gpios-states = <0>;
> + states = <1800000 0x1
> + 3300000 0x0>;
> + enable-active-high;
> + };
> };
>
> /* J9 */
> @@ -71,6 +86,17 @@
> status = "okay";
> };
>
> +/* J1 */
> +&sdhci1 {
> + wp-inverted;
> + bus-width = <4>;
> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
> + no-1-8-v;
> + marvell,pad-type = "sd";
> + vqmmc-supply = <&vcc_sd_reg1>;
> + status = "okay";
> +};
> +
> /* Exported on the micro USB connector J5 through an FTDI */
> &uart0 {
> status = "okay";
--
Miquel Raynal, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin
2017-08-02 17:16 ` Miquel RAYNAL
@ 2017-08-03 12:23 ` Gregory CLEMENT
0 siblings, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2017-08-03 12:23 UTC (permalink / raw)
To: Marcin Wojtas
Cc: Miquel RAYNAL, linux-kernel, linux-arm-kernel, thomas.petazzoni,
andrew, marc.zyngier, jaz, hannah, nadavh, neta, mark.rutland,
zbodek
Hi Marcin,
On mer., août 02 2017, Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote:
> Hi,
>
> On Fri, 21 Jul 2017 01:50:36 +0200
> Marcin Wojtas <mw@semihalf.com> wrote:
>
>> The ESPRESSObin board exposes one of the SDHCI interfaces
>> via J1 uSD slot. This patch enables it.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Signed-off-by: Zbigniew Bodek <zbodek@gmail.com>
>
> Tested-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Applied on mvebu/dt64 (I also removed the "no-1-8-v" property while
applying it becauseit was obviously wrong)
Thanks,
Gregory
>
>> ---
>> .../boot/dts/marvell/armada-3720-espressobin.dts | 26
>> ++++++++++++++++++++++ 1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index
>> b1af3f98..6d0caf1 100644 ---
>> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++
>> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6
>> +45,7 @@
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> #include "armada-372x.dtsi"
>>
>> / {
>> @@ -59,6 +60,20 @@
>> device_type = "memory";
>> reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
>> };
>> +
>> + vcc_sd_reg1: regulator {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vcc_sd1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> +
>> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>;
>> + gpios-states = <0>;
>> + states = <1800000 0x1
>> + 3300000 0x0>;
>> + enable-active-high;
>> + };
>> };
>>
>> /* J9 */
>> @@ -71,6 +86,17 @@
>> status = "okay";
>> };
>>
>> +/* J1 */
>> +&sdhci1 {
>> + wp-inverted;
>> + bus-width = <4>;
>> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>;
>> + no-1-8-v;
>> + marvell,pad-type = "sd";
>> + vqmmc-supply = <&vcc_sd_reg1>;
>> + status = "okay";
>> +};
>> +
>> /* Exported on the micro USB connector J5 through an FTDI */
>> &uart0 {
>> status = "okay";
>
>
>
> --
> Miquel Raynal, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-03 12:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-20 23:50 [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin Marcin Wojtas
2017-08-02 17:16 ` Miquel RAYNAL
2017-08-03 12:23 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).