* [PATCH 0/3] mmc: sdhci: refactor PM in sdhci-pltfm and support PM for cadence port
@ 2017-07-31 12:56 Masahiro Yamada
2017-07-31 12:56 ` [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Masahiro Yamada @ 2017-07-31 12:56 UTC (permalink / raw)
To: linux-mmc
Cc: Piotr Sroka, Adrian Hunter, Masahiro Yamada, Al Cooper,
linux-kernel, Brian Norris, bcm-kernel-feedback-list, Barry Song,
Florian Fainelli, Gregory Fong, linux-arm-kernel, Ulf Hansson
[1] adds clk handling for suspend/resume hooks of sdhci-pltfm.
This also cleans up sdhci-brcmstb.c and sdhci-sirf.c
[2] exports suspend / resume, which will be used by [3]
[3] implements suspend / resume for sdhci-cadence.c
Masahiro Yamada (3):
mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume
mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume
mmc: sdhci-cadence: add suspend / resume support
drivers/mmc/host/sdhci-brcmstb.c | 37 +------------------
drivers/mmc/host/sdhci-cadence.c | 77 +++++++++++++++++++++++++++++++++++-----
drivers/mmc/host/sdhci-pltfm.c | 22 ++++++++++--
drivers/mmc/host/sdhci-pltfm.h | 2 ++
drivers/mmc/host/sdhci-sirf.c | 39 +-------------------
5 files changed, 91 insertions(+), 86 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume
2017-07-31 12:56 [PATCH 0/3] mmc: sdhci: refactor PM in sdhci-pltfm and support PM for cadence port Masahiro Yamada
@ 2017-07-31 12:56 ` Masahiro Yamada
2017-08-02 15:50 ` kbuild test robot
2017-07-31 12:56 ` [PATCH 2/3] mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume Masahiro Yamada
2017-07-31 12:56 ` [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2017-07-31 12:56 UTC (permalink / raw)
To: linux-mmc
Cc: Piotr Sroka, Adrian Hunter, Masahiro Yamada, Al Cooper,
linux-kernel, Brian Norris, bcm-kernel-feedback-list, Barry Song,
Florian Fainelli, Gregory Fong, linux-arm-kernel, Ulf Hansson
This commit provides similar cleanups as commit 83eacdfa2529 ("mmc:
sdhci: disable the clock in sdhci_pltfm_unregister()") did for
unregister hooks.
Some drivers duplicate code to handle pltfm_host->clk in their own
hooks. The clock can be handled in sdhci_pltfm.c so that drivers
can reuse sdhci_pltfm_pmops.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/sdhci-brcmstb.c | 37 +------------------------------------
drivers/mmc/host/sdhci-pltfm.c | 16 +++++++++++++++-
drivers/mmc/host/sdhci-sirf.c | 39 +--------------------------------------
3 files changed, 17 insertions(+), 75 deletions(-)
diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index e2f638338e8f..6d461fcdd663 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -21,41 +21,6 @@
#include "sdhci-pltfm.h"
-#ifdef CONFIG_PM_SLEEP
-
-static int sdhci_brcmstb_suspend(struct device *dev)
-{
- struct sdhci_host *host = dev_get_drvdata(dev);
- struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- int res;
-
- if (host->tuning_mode != SDHCI_TUNING_MODE_3)
- mmc_retune_needed(host->mmc);
-
- res = sdhci_suspend_host(host);
- if (res)
- return res;
- clk_disable_unprepare(pltfm_host->clk);
- return res;
-}
-
-static int sdhci_brcmstb_resume(struct device *dev)
-{
- struct sdhci_host *host = dev_get_drvdata(dev);
- struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- int err;
-
- err = clk_prepare_enable(pltfm_host->clk);
- if (err)
- return err;
- return sdhci_resume_host(host);
-}
-
-#endif /* CONFIG_PM_SLEEP */
-
-static SIMPLE_DEV_PM_OPS(sdhci_brcmstb_pmops, sdhci_brcmstb_suspend,
- sdhci_brcmstb_resume);
-
static const struct sdhci_ops sdhci_brcmstb_ops = {
.set_clock = sdhci_set_clock,
.set_bus_width = sdhci_set_bus_width,
@@ -131,7 +96,7 @@ MODULE_DEVICE_TABLE(of, sdhci_brcm_of_match);
static struct platform_driver sdhci_brcmstb_driver = {
.driver = {
.name = "sdhci-brcmstb",
- .pm = &sdhci_brcmstb_pmops,
+ .pm = &sdhci_pltfm_pmops,
.of_match_table = of_match_ptr(sdhci_brcm_of_match),
},
.probe = sdhci_brcmstb_probe,
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index e090d8c42ddb..be9a79d62e22 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -212,16 +212,30 @@ EXPORT_SYMBOL_GPL(sdhci_pltfm_unregister);
static int sdhci_pltfm_suspend(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);
+ struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
+ int ret;
if (host->tuning_mode != SDHCI_TUNING_MODE_3)
mmc_retune_needed(host->mmc);
- return sdhci_suspend_host(host);
+ ret = sdhci_suspend_host(host);
+ if (ret)
+ return ret;
+
+ clk_disable_unprepare(pltfm_host->clk);
+
+ return 0;
}
static int sdhci_pltfm_resume(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);
+ struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
+ int ret;
+
+ ret = clk_prepare_enable(pltfm_host->clk);
+ if (ret)
+ return ret;
return sdhci_resume_host(host);
}
diff --git a/drivers/mmc/host/sdhci-sirf.c b/drivers/mmc/host/sdhci-sirf.c
index c251c6c0a112..dd4680a0ada4 100644
--- a/drivers/mmc/host/sdhci-sirf.c
+++ b/drivers/mmc/host/sdhci-sirf.c
@@ -230,43 +230,6 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
return ret;
}
-#ifdef CONFIG_PM_SLEEP
-static int sdhci_sirf_suspend(struct device *dev)
-{
- struct sdhci_host *host = dev_get_drvdata(dev);
- struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- int ret;
-
- if (host->tuning_mode != SDHCI_TUNING_MODE_3)
- mmc_retune_needed(host->mmc);
-
- ret = sdhci_suspend_host(host);
- if (ret)
- return ret;
-
- clk_disable(pltfm_host->clk);
-
- return 0;
-}
-
-static int sdhci_sirf_resume(struct device *dev)
-{
- struct sdhci_host *host = dev_get_drvdata(dev);
- struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- int ret;
-
- ret = clk_enable(pltfm_host->clk);
- if (ret) {
- dev_dbg(dev, "Resume: Error enabling clock\n");
- return ret;
- }
-
- return sdhci_resume_host(host);
-}
-#endif
-
-static SIMPLE_DEV_PM_OPS(sdhci_sirf_pm_ops, sdhci_sirf_suspend, sdhci_sirf_resume);
-
static const struct of_device_id sdhci_sirf_of_match[] = {
{ .compatible = "sirf,prima2-sdhc" },
{ }
@@ -276,7 +239,7 @@ MODULE_DEVICE_TABLE(of, sdhci_sirf_of_match);
static struct platform_driver sdhci_sirf_driver = {
.driver = {
.name = "sdhci-sirf",
- .of_match_table = sdhci_sirf_of_match,
+ .of_match_table = sdhci_pltfm_pmops,
.pm = &sdhci_sirf_pm_ops,
},
.probe = sdhci_sirf_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume
2017-07-31 12:56 [PATCH 0/3] mmc: sdhci: refactor PM in sdhci-pltfm and support PM for cadence port Masahiro Yamada
2017-07-31 12:56 ` [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
@ 2017-07-31 12:56 ` Masahiro Yamada
2017-07-31 12:56 ` [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada
2 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2017-07-31 12:56 UTC (permalink / raw)
To: linux-mmc
Cc: Piotr Sroka, Adrian Hunter, Masahiro Yamada, linux-kernel, Ulf Hansson
This will be useful when drivers want to reuse only the suspend/resume
callbacks instead of whole of sdhci_pltfm_pmops.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/sdhci-pltfm.c | 6 ++++--
drivers/mmc/host/sdhci-pltfm.h | 2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index be9a79d62e22..a34eacac612f 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -209,7 +209,7 @@ int sdhci_pltfm_unregister(struct platform_device *pdev)
EXPORT_SYMBOL_GPL(sdhci_pltfm_unregister);
#ifdef CONFIG_PM_SLEEP
-static int sdhci_pltfm_suspend(struct device *dev)
+int sdhci_pltfm_suspend(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
@@ -226,8 +226,9 @@ static int sdhci_pltfm_suspend(struct device *dev)
return 0;
}
+EXPORT_SYMBOL_GPL(sdhci_pltfm_suspend);
-static int sdhci_pltfm_resume(struct device *dev)
+int sdhci_pltfm_resume(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
@@ -239,6 +240,7 @@ static int sdhci_pltfm_resume(struct device *dev)
return sdhci_resume_host(host);
}
+EXPORT_SYMBOL_GPL(sdhci_pltfm_resume);
#endif
const struct dev_pm_ops sdhci_pltfm_pmops = {
diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
index 957839d0fe37..1e91fb1c020e 100644
--- a/drivers/mmc/host/sdhci-pltfm.h
+++ b/drivers/mmc/host/sdhci-pltfm.h
@@ -109,6 +109,8 @@ static inline void *sdhci_pltfm_priv(struct sdhci_pltfm_host *host)
return host->private;
}
+int sdhci_pltfm_suspend(struct device *dev);
+int sdhci_pltfm_resume(struct device *dev);
extern const struct dev_pm_ops sdhci_pltfm_pmops;
#endif /* _DRIVERS_MMC_SDHCI_PLTFM_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support
2017-07-31 12:56 [PATCH 0/3] mmc: sdhci: refactor PM in sdhci-pltfm and support PM for cadence port Masahiro Yamada
2017-07-31 12:56 ` [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
2017-07-31 12:56 ` [PATCH 2/3] mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume Masahiro Yamada
@ 2017-07-31 12:56 ` Masahiro Yamada
2017-08-02 15:24 ` kbuild test robot
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2017-07-31 12:56 UTC (permalink / raw)
To: linux-mmc
Cc: Piotr Sroka, Adrian Hunter, Masahiro Yamada, linux-kernel, Ulf Hansson
Currently, the probe function initializes the PHY, but PHY settings
are lost during the sleep state. Restore the PHY registers when
resuming.
To facilitate this, split sdhci_cdns_phy_init() into the DT parse
part and PHY update part so that the latter can be invoked from the
resume hook.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/mmc/host/sdhci-cadence.c | 77 +++++++++++++++++++++++++++++++++++-----
1 file changed, 68 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/sdhci-cadence.c b/drivers/mmc/host/sdhci-cadence.c
index 19d5698244b5..7473766801a5 100644
--- a/drivers/mmc/host/sdhci-cadence.c
+++ b/drivers/mmc/host/sdhci-cadence.c
@@ -67,9 +67,16 @@
*/
#define SDHCI_CDNS_MAX_TUNING_LOOP 40
+struct sdhci_cdns_phy_param {
+ u8 addr;
+ u8 data;
+};
+
struct sdhci_cdns_priv {
void __iomem *hrs_addr;
bool enhanced_strobe;
+ unsigned int nr_phy_params;
+ struct sdhci_cdns_phy_param phy_params[0];
};
struct sdhci_cdns_phy_cfg {
@@ -115,9 +122,22 @@ static int sdhci_cdns_write_phy_reg(struct sdhci_cdns_priv *priv,
return 0;
}
-static int sdhci_cdns_phy_init(struct device_node *np,
- struct sdhci_cdns_priv *priv)
+static unsigned int sdhci_cdns_phy_param_count(struct device_node *np)
{
+ unsigned int count = 0;
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(sdhci_cdns_phy_cfgs); i++)
+ if (of_property_read_bool(np, sdhci_cdns_phy_cfgs[i].property))
+ count++;
+
+ return count;
+}
+
+static void sdhci_cdns_phy_param_parse(struct device_node *np,
+ struct sdhci_cdns_priv *priv)
+{
+ struct sdhci_cdns_phy_param *p = priv->phy_params;
u32 val;
int ret, i;
@@ -127,9 +147,19 @@ static int sdhci_cdns_phy_init(struct device_node *np,
if (ret)
continue;
- ret = sdhci_cdns_write_phy_reg(priv,
- sdhci_cdns_phy_cfgs[i].addr,
- val);
+ p->addr = sdhci_cdns_phy_cfgs[i].addr;
+ p->data = val;
+ p++;
+ }
+}
+
+static int sdhci_cdns_phy_init(struct sdhci_cdns_priv *priv)
+{
+ int ret, i;
+
+ for (i = 0; i < priv->nr_phy_params; i++) {
+ ret = sdhci_cdns_write_phy_reg(priv, priv->phy_params[i].addr,
+ priv->phy_params[i].data);
if (ret)
return ret;
}
@@ -302,6 +332,8 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
struct sdhci_pltfm_host *pltfm_host;
struct sdhci_cdns_priv *priv;
struct clk *clk;
+ size_t priv_size;
+ unsigned int nr_phy_params;
int ret;
struct device *dev = &pdev->dev;
@@ -313,7 +345,9 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
if (ret)
return ret;
- host = sdhci_pltfm_init(pdev, &sdhci_cdns_pltfm_data, sizeof(*priv));
+ nr_phy_params = sdhci_cdns_phy_param_count(dev->of_node);
+ priv_size = sizeof(*priv) + sizeof(priv->phy_params[0]) * nr_phy_params;
+ host = sdhci_pltfm_init(pdev, &sdhci_cdns_pltfm_data, priv_size);
if (IS_ERR(host)) {
ret = PTR_ERR(host);
goto disable_clk;
@@ -322,7 +356,8 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
pltfm_host = sdhci_priv(host);
pltfm_host->clk = clk;
- priv = sdhci_cdns_priv(host);
+ priv = sdhci_pltfm_priv(pltfm_host);
+ priv->nr_phy_params = nr_phy_params;
priv->hrs_addr = host->ioaddr;
priv->enhanced_strobe = false;
host->ioaddr += SDHCI_CDNS_SRS_BASE;
@@ -336,7 +371,9 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
if (ret)
goto free;
- ret = sdhci_cdns_phy_init(dev->of_node, priv);
+ sdhci_cdns_phy_param_parse(dev->of_node, priv);
+
+ ret = sdhci_cdns_phy_init(priv);
if (ret)
goto free;
@@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
return ret;
}
+static int __maybe_unused sdhci_cdns_resume(struct device *dev)
+{
+ struct sdhci_host *host = dev_get_drvdata(dev);
+ struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
+ struct sdhci_cdns_priv *priv = sdhci_pltfm_priv(pltfm_host);
+ int ret;
+
+ ret = clk_prepare_enable(pltfm_host->clk);
+ if (ret)
+ return ret;
+
+ ret = sdhci_cdns_phy_init(priv);
+ if (ret)
+ return ret;
+
+ return sdhci_resume_host(host);
+}
+
+static const struct dev_pm_ops sdhci_cdns_pm_ops = {
+ SET_SYSTEM_SLEEP_PM_OPS(sdhci_pltfm_suspend, sdhci_cdns_resume)
+};
+
static const struct of_device_id sdhci_cdns_match[] = {
{ .compatible = "socionext,uniphier-sd4hc" },
{ .compatible = "cdns,sd4hc" },
@@ -363,7 +422,7 @@ MODULE_DEVICE_TABLE(of, sdhci_cdns_match);
static struct platform_driver sdhci_cdns_driver = {
.driver = {
.name = "sdhci-cdns",
- .pm = &sdhci_pltfm_pmops,
+ .pm = &sdhci_cdns_pm_ops,
.of_match_table = sdhci_cdns_match,
},
.probe = sdhci_cdns_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support
2017-07-31 12:56 ` [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada
@ 2017-08-02 15:24 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2017-08-02 15:24 UTC (permalink / raw)
To: Masahiro Yamada
Cc: kbuild-all, linux-mmc, Piotr Sroka, Adrian Hunter,
Masahiro Yamada, linux-kernel, Ulf Hansson
[-- Attachment #1: Type: text/plain, Size: 1802 bytes --]
Hi Masahiro,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc3 next-20170802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/mmc-sdhci-enable-disable-the-clock-in-sdhci_pltfm_suspend-resume/20170801-021149
config: openrisc-allyesconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 5.4.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All errors (new ones prefixed by >>):
drivers/mmc//host/sdhci-cadence.c: In function 'sdhci_cdns_resume':
>> drivers/mmc//host/sdhci-cadence.c:408:9: error: implicit declaration of function 'sdhci_resume_host' [-Werror=implicit-function-declaration]
return sdhci_resume_host(host);
^
cc1: some warnings being treated as errors
vim +/sdhci_resume_host +408 drivers/mmc//host/sdhci-cadence.c
392
393 static int __maybe_unused sdhci_cdns_resume(struct device *dev)
394 {
395 struct sdhci_host *host = dev_get_drvdata(dev);
396 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
397 struct sdhci_cdns_priv *priv = sdhci_pltfm_priv(pltfm_host);
398 int ret;
399
400 ret = clk_prepare_enable(pltfm_host->clk);
401 if (ret)
402 return ret;
403
404 ret = sdhci_cdns_phy_init(priv);
405 if (ret)
406 return ret;
407
> 408 return sdhci_resume_host(host);
409 }
410
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42498 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume
2017-07-31 12:56 ` [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
@ 2017-08-02 15:50 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2017-08-02 15:50 UTC (permalink / raw)
To: Masahiro Yamada
Cc: kbuild-all, linux-mmc, Piotr Sroka, Adrian Hunter,
Masahiro Yamada, Al Cooper, linux-kernel, Brian Norris,
bcm-kernel-feedback-list, Barry Song, Florian Fainelli,
Gregory Fong, linux-arm-kernel, Ulf Hansson
[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]
Hi Masahiro,
[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc3 next-20170802]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/mmc-sdhci-enable-disable-the-clock-in-sdhci_pltfm_suspend-resume/20170801-021149
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> drivers/mmc/host/sdhci-sirf.c:242:21: error: initializer element is not constant
.of_match_table = sdhci_pltfm_pmops,
^~~~~~~~~~~~~~~~~
drivers/mmc/host/sdhci-sirf.c:242:21: note: (near initialization for 'sdhci_sirf_driver.driver.of_match_table')
>> drivers/mmc/host/sdhci-sirf.c:243:10: error: 'sdhci_sirf_pm_ops' undeclared here (not in a function)
.pm = &sdhci_sirf_pm_ops,
^~~~~~~~~~~~~~~~~
vim +242 drivers/mmc/host/sdhci-sirf.c
238
239 static struct platform_driver sdhci_sirf_driver = {
240 .driver = {
241 .name = "sdhci-sirf",
> 242 .of_match_table = sdhci_pltfm_pmops,
> 243 .pm = &sdhci_sirf_pm_ops,
244 },
245 .probe = sdhci_sirf_probe,
246 .remove = sdhci_pltfm_unregister,
247 };
248
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63458 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-02 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-31 12:56 [PATCH 0/3] mmc: sdhci: refactor PM in sdhci-pltfm and support PM for cadence port Masahiro Yamada
2017-07-31 12:56 ` [PATCH 1/3] mmc: sdhci: enable/disable the clock in sdhci_pltfm_suspend/resume Masahiro Yamada
2017-08-02 15:50 ` kbuild test robot
2017-07-31 12:56 ` [PATCH 2/3] mmc: sdhci-pltfm: export sdhci_pltfm_suspend/resume Masahiro Yamada
2017-07-31 12:56 ` [PATCH 3/3] mmc: sdhci-cadence: add suspend / resume support Masahiro Yamada
2017-08-02 15:24 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).