From: Oliver Neukum <oneukum@suse.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: gregkh@linuxfoundation.org,
Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter
Date: Mon, 07 Aug 2017 13:32:29 +0200 [thread overview]
Message-ID: <1502105549.1909.8.camel@suse.com> (raw)
In-Reply-To: <CAAd53p6o2WJ=oSaje-r_m9EQLK1C=tkqY_SOneSQsTQ=d1Ehfw@mail.gmail.com>
Am Montag, den 07.08.2017, 17:33 +0800 schrieb Kai-Heng Feng:
> On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum <oneukum@suse.com> wrote:
> >
> > Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng:
> > >
> > > The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm
> > > quirk can make it work.
> >
> > So can you confirm it works with LPM on another hub?
>
> Yes, another r8153 dongle (Dell Type-C to Ethernet) does not have this issue.
OK.
> >
> >
> > >
> > > Since another r8153 dongle at my hand does not have the issue, so add
> > > the quirk to the hub instead.
> >
> > This does not match the comment in the patch. This needs to
> > be clarified.
>
> The Moshi USB to Ethernet Adapter internally has a Genesys Logic hub.
> Ethernet chip r8153 is connected to the Genesys Logic hub.
>
> I'll resend a patch with this information if it's clear enough.
Thanks. The piece about an internal hub was missing.
Regards
Oliver
prev parent reply other threads:[~2017-08-07 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 9:34 [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter Kai-Heng Feng
2017-08-07 9:08 ` Oliver Neukum
2017-08-07 9:33 ` Kai-Heng Feng
2017-08-07 11:32 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502105549.1909.8.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).