From: Santosh Mardi <gsantosh@codeaurora.org>
To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
rafael.j.wysocki@intel.com, cw00.choi@samsung.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
gsantosh@qti.qualcomm.com, gsantosh@codeaurora.org,
skannan@quicinc.com, rgottimu@qti.qualcomm.com
Subject: [PATCH] devfreq: add error check for sscanf in userspace governor
Date: Mon, 7 Aug 2017 18:36:45 +0530 [thread overview]
Message-ID: <1502111205-22560-2-git-send-email-gsantosh@codeaurora.org> (raw)
In-Reply-To: <1502111205-22560-1-git-send-email-gsantosh@codeaurora.org>
store_freq function of devfreq userspace governor
executes further, even if error is returned from sscanf,
this will result in setting up wrong frequency value.
Add proper error check to bail out if any error is returned.
Signed-off-by: Santosh Mardi <gsantosh@codeaurora.org>
---
drivers/devfreq/governor_userspace.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/governor_userspace.c b/drivers/devfreq/governor_userspace.c
index 77028c2..1d0c9cc 100644
--- a/drivers/devfreq/governor_userspace.c
+++ b/drivers/devfreq/governor_userspace.c
@@ -53,12 +53,15 @@ static ssize_t store_freq(struct device *dev, struct device_attribute *attr,
mutex_lock(&devfreq->lock);
data = devfreq->data;
- sscanf(buf, "%lu", &wanted);
+ err = sscanf(buf, "%lu", &wanted);
+ if (err != 1)
+ goto out;
data->user_frequency = wanted;
data->valid = true;
err = update_devfreq(devfreq);
if (err == 0)
err = count;
+out:
mutex_unlock(&devfreq->lock);
return err;
}
--
1.9.1
next prev parent reply other threads:[~2017-08-07 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 13:06 [PATCH] devfreq: add error check for sscanf in userspace governor Santosh Mardi
2017-08-07 13:06 ` Santosh Mardi [this message]
2017-08-08 0:51 ` Chanwoo Choi
2017-08-08 6:56 ` Pavan Kondeti
2017-08-08 19:26 ` Saravana Kannan
[not found] ` <CGME20170807130735epcas5p4386af2ade3bd98b67fc5a9c956152c7d@epcms1p5>
2017-08-08 0:14 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502111205-22560-2-git-send-email-gsantosh@codeaurora.org \
--to=gsantosh@codeaurora.org \
--cc=cw00.choi@samsung.com \
--cc=gsantosh@qti.qualcomm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rgottimu@qti.qualcomm.com \
--cc=skannan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).