From: MyungJoo Ham <myungjoo.ham@samsung.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gsantosh@qti.qualcomm.com" <gsantosh@qti.qualcomm.com>,
"gsantosh@codeaurora.org" <gsantosh@codeaurora.org>,
"skannan@quicinc.com" <skannan@quicinc.com>,
"rgottimu@qti.qualcomm.com" <rgottimu@qti.qualcomm.com>
Subject: RE: [PATCH] devfreq: add error check for sscanf in userspace governor
Date: Tue, 08 Aug 2017 00:14:43 +0000 [thread overview]
Message-ID: <20170808001443epcms1p53655025662e843eab56aca33554b09df@epcms1p5> (raw)
In-Reply-To: <1502111205-22560-2-git-send-email-gsantosh@codeaurora.org>
> store_freq function of devfreq userspace governor
> executes further, even if error is returned from sscanf,
> this will result in setting up wrong frequency value.
>
> Add proper error check to bail out if any error is returned.
>
> Signed-off-by: Santosh Mardi <gsantosh@codeaurora.org>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> ---
> drivers/devfreq/governor_userspace.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
prev parent reply other threads:[~2017-08-08 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 13:06 [PATCH] devfreq: add error check for sscanf in userspace governor Santosh Mardi
2017-08-07 13:06 ` Santosh Mardi
2017-08-08 0:51 ` Chanwoo Choi
2017-08-08 6:56 ` Pavan Kondeti
2017-08-08 19:26 ` Saravana Kannan
[not found] ` <CGME20170807130735epcas5p4386af2ade3bd98b67fc5a9c956152c7d@epcms1p5>
2017-08-08 0:14 ` MyungJoo Ham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808001443epcms1p53655025662e843eab56aca33554b09df@epcms1p5 \
--to=myungjoo.ham@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=gsantosh@codeaurora.org \
--cc=gsantosh@qti.qualcomm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rgottimu@qti.qualcomm.com \
--cc=skannan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).