* [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const
@ 2017-08-08 15:45 Bhumika Goyal
2017-08-17 17:03 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-08 15:45 UTC (permalink / raw)
To: julia.lawall, gregkh, devel, linux-kernel; +Cc: Bhumika Goyal
Make the structure const as it is only passed to the function
drm_fb_helper_prepare and the corresponding argument is of type
const.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
index bf66358..c386039 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -317,7 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
return 0;
}
-static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
+static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
.fb_probe = vboxfb_create,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const
2017-08-08 15:45 [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const Bhumika Goyal
@ 2017-08-17 17:03 ` Greg KH
2017-08-17 17:05 ` Bhumika Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-08-17 17:03 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: julia.lawall, devel, linux-kernel
On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
> Make the structure const as it is only passed to the function
> drm_fb_helper_prepare and the corresponding argument is of type
> const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does not apply to my tree at all :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const
2017-08-17 17:03 ` Greg KH
@ 2017-08-17 17:05 ` Bhumika Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-17 17:05 UTC (permalink / raw)
To: Greg KH; +Cc: Julia Lawall, devel, linux-kernel
On Thu, Aug 17, 2017 at 10:33 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
>> Make the structure const as it is only passed to the function
>> drm_fb_helper_prepare and the corresponding argument is of type
>> const.
>> Done using Coccinelle.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>> ---
>> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does not apply to my tree at all :(
Okay, I will resend it.
Thanks,
Bhumika
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-17 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 15:45 [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const Bhumika Goyal
2017-08-17 17:03 ` Greg KH
2017-08-17 17:05 ` Bhumika Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).