* [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id
@ 2017-08-08 16:04 Arvind Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Arvind Yadav @ 2017-08-08 16:04 UTC (permalink / raw)
To: kvalo, herton, htl10, Larry.Finger; +Cc: linux-kernel, netdev, linux-wireless
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
index 55198ac2..121b94f 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
@@ -43,7 +43,7 @@ MODULE_AUTHOR("Larry Finger <Larry.Finger@lwfinger.net>");
MODULE_DESCRIPTION("RTL8187/RTL8187B USB wireless driver");
MODULE_LICENSE("GPL");
-static struct usb_device_id rtl8187_table[] = {
+static const struct usb_device_id rtl8187_table[] = {
/* Asus */
{USB_DEVICE(0x0b05, 0x171d), .driver_info = DEVICE_RTL8187},
/* Belkin */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id
[not found] <1571555159.3124994.1503695127129.ref@mail.yahoo.com>
@ 2017-08-25 21:05 ` Hin-Tak Leung
0 siblings, 0 replies; 2+ messages in thread
From: Hin-Tak Leung @ 2017-08-25 21:05 UTC (permalink / raw)
To: kvalo, herton, Larry.Finger, Arvind Yadav
Cc: linux-kernel, netdev, linux-wireless
--------------------------------------------
On Tue, 8/8/17, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
Subject: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id
To: kvalo@codeaurora.org, herton@canonical.com, htl10@users.sourceforge.net, Larry.Finger@lwfinger.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Date: Tuesday, 8 August, 2017, 17:04
> usb_device_id are not supposed to change at
> runtime. All functions
> working with usb_device_id provided by
> <linux/usb.h> work with
> const usb_device_id. So mark the
> non-const structs as const.
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: htl10@users.sourceforge.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-25 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-08 16:04 [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id Arvind Yadav
[not found] <1571555159.3124994.1503695127129.ref@mail.yahoo.com>
2017-08-25 21:05 ` Hin-Tak Leung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).