* [PATCH 0/2] constify hid usb_device_id and fix space before '[' error
@ 2017-08-09 18:21 Arvind Yadav
2017-08-09 18:21 ` [PATCH 1/2] HID: usbkbd: constify " Arvind Yadav
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-09 18:21 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-usb, linux-input, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.
Arvind Yadav (2):
[PATCH 1/2] HID: usbkbd: constify usb_device_id and fix space before '[' error.
[PATCH 2/2] HID: usbmouse: constify usb_device_id and fix space before '[' error
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/usbhid/usbmouse.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] HID: usbkbd: constify usb_device_id and fix space before '[' error.
2017-08-09 18:21 [PATCH 0/2] constify hid usb_device_id and fix space before '[' error Arvind Yadav
@ 2017-08-09 18:21 ` Arvind Yadav
2017-08-09 18:21 ` [PATCH 2/2] HID: usbmouse: " Arvind Yadav
2017-08-10 9:08 ` [PATCH 0/2] constify hid " Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-09 18:21 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-usb, linux-input, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index 7fb2d1e..ed01dc4 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -392,7 +392,7 @@ static void usb_kbd_disconnect(struct usb_interface *intf)
}
}
-static struct usb_device_id usb_kbd_id_table [] = {
+static const struct usb_device_id usb_kbd_id_table[] = {
{ USB_INTERFACE_INFO(USB_INTERFACE_CLASS_HID, USB_INTERFACE_SUBCLASS_BOOT,
USB_INTERFACE_PROTOCOL_KEYBOARD) },
{ } /* Terminating entry */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] HID: usbmouse: constify usb_device_id and fix space before '[' error
2017-08-09 18:21 [PATCH 0/2] constify hid usb_device_id and fix space before '[' error Arvind Yadav
2017-08-09 18:21 ` [PATCH 1/2] HID: usbkbd: constify " Arvind Yadav
@ 2017-08-09 18:21 ` Arvind Yadav
2017-08-10 9:08 ` [PATCH 0/2] constify hid " Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Arvind Yadav @ 2017-08-09 18:21 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-usb, linux-input, linux-kernel
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hid/usbhid/usbmouse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbmouse.c b/drivers/hid/usbhid/usbmouse.c
index dd911c5..589ad7c 100644
--- a/drivers/hid/usbhid/usbmouse.c
+++ b/drivers/hid/usbhid/usbmouse.c
@@ -226,7 +226,7 @@ static void usb_mouse_disconnect(struct usb_interface *intf)
}
}
-static struct usb_device_id usb_mouse_id_table [] = {
+static const struct usb_device_id usb_mouse_id_table[] = {
{ USB_INTERFACE_INFO(USB_INTERFACE_CLASS_HID, USB_INTERFACE_SUBCLASS_BOOT,
USB_INTERFACE_PROTOCOL_MOUSE) },
{ } /* Terminating entry */
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] constify hid usb_device_id and fix space before '[' error
2017-08-09 18:21 [PATCH 0/2] constify hid usb_device_id and fix space before '[' error Arvind Yadav
2017-08-09 18:21 ` [PATCH 1/2] HID: usbkbd: constify " Arvind Yadav
2017-08-09 18:21 ` [PATCH 2/2] HID: usbmouse: " Arvind Yadav
@ 2017-08-10 9:08 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2017-08-10 9:08 UTC (permalink / raw)
To: Arvind Yadav; +Cc: benjamin.tissoires, linux-usb, linux-input, linux-kernel
On Wed, 9 Aug 2017, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
Applied to for-4.14/upstream.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-10 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-09 18:21 [PATCH 0/2] constify hid usb_device_id and fix space before '[' error Arvind Yadav
2017-08-09 18:21 ` [PATCH 1/2] HID: usbkbd: constify " Arvind Yadav
2017-08-09 18:21 ` [PATCH 2/2] HID: usbmouse: " Arvind Yadav
2017-08-10 9:08 ` [PATCH 0/2] constify hid " Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).