* [PATCH v2 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC
@ 2017-08-12 2:57 Jun Gao
2017-08-12 2:57 ` [PATCH v2 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-12 2:57 ` [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
0 siblings, 2 replies; 6+ messages in thread
From: Jun Gao @ 2017-08-12 2:57 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek
This patch series based on v4.13-rc1, include MT7622 i2c dt-binding
and compatible.
changes since v1:
- Modify commit message
- Revise dt-binding documentation
Jun Gao (2):
dt-bindings: i2c: Add MediaTek MT7622 i2c binding
i2c: mediatek: Add i2c compatible for MediaTek MT7622
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
2 files changed, 24 insertions(+), 5 deletions(-)
--
1.8.1.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding
2017-08-12 2:57 [PATCH v2 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
@ 2017-08-12 2:57 ` Jun Gao
2017-08-12 2:57 ` [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
1 sibling, 0 replies; 6+ messages in thread
From: Jun Gao @ 2017-08-12 2:57 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek, Jun Gao
From: Jun Gao <jun.gao@mediatek.com>
Add MT7622 i2c binding to binding file and change the compatible
information formats of all SoCs to the same.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
index bd5a7be..71fc0b3 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
Required properties:
- compatible: value should be either of the following.
- "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701
- "mediatek,mt6577-i2c": for i2c compatible with mt6577.
- "mediatek,mt6589-i2c": for i2c compatible with mt6589.
- "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623.
- "mediatek,mt8173-i2c": for i2c compatible with mt8173.
+ "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701
+ "mediatek,mt6577-i2c": for Mediatek MT6577
+ "mediatek,mt6589-i2c": for Mediatek MT6589
+ "mediatek,mt7622-i2c": for Mediatek MT7622
+ "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623
+ "mediatek,mt8173-i2c": for Mediatek MT8173
- reg: physical base address of the controller and dma base, length of memory
mapped region.
- interrupts: interrupt number to the cpu.
--
1.8.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
2017-08-12 2:57 [PATCH v2 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-12 2:57 ` [PATCH v2 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
@ 2017-08-12 2:57 ` Jun Gao
2017-08-12 14:44 ` Wolfram Sang
1 sibling, 1 reply; 6+ messages in thread
From: Jun Gao @ 2017-08-12 2:57 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger
Cc: srv_heupstream, devicetree, linux-i2c, linux-arm-kernel,
linux-kernel, linux-mediatek, Jun Gao
From: Jun Gao <jun.gao@mediatek.com>
Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
MT7622 limits message numbers to 255, and does not support 4GB
DMA mode.
Signed-off-by: Jun Gao <jun.gao@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 9bedf0b..2c7f847 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -172,6 +172,14 @@ struct mtk_i2c {
.max_comb_2nd_msg_len = 31,
};
+static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
+ .max_num_msgs = 255,
+ .max_write_len = 65535,
+ .max_read_len = 65535,
+ .max_comb_1st_msg_len = 65535,
+ .max_comb_2nd_msg_len = 65535,
+};
+
static const struct mtk_i2c_compatible mt6577_compat = {
.quirks = &mt6577_i2c_quirks,
.pmic_i2c = 0,
@@ -190,6 +198,15 @@ struct mtk_i2c {
.support_33bits = 0,
};
+static const struct mtk_i2c_compatible mt7622_compat = {
+ .quirks = &mt7622_i2c_quirks,
+ .pmic_i2c = 0,
+ .dcm = 1,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .support_33bits = 0,
+};
+
static const struct mtk_i2c_compatible mt8173_compat = {
.pmic_i2c = 0,
.dcm = 1,
@@ -201,6 +218,7 @@ struct mtk_i2c {
static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
+ { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
{}
};
--
1.8.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
2017-08-12 2:57 ` [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
@ 2017-08-12 14:44 ` Wolfram Sang
2017-08-14 1:36 ` Jun Gao
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2017-08-12 14:44 UTC (permalink / raw)
To: Jun Gao
Cc: Matthias Brugger, srv_heupstream, devicetree, linux-i2c,
linux-arm-kernel, linux-kernel, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
> +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> + .max_num_msgs = 255,
> + .max_write_len = 65535,
> + .max_read_len = 65535,
> + .max_comb_1st_msg_len = 65535,
> + .max_comb_2nd_msg_len = 65535,
> +};
That looks like no quirks? Then just leave the quirks pointer below
empty.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
2017-08-12 14:44 ` Wolfram Sang
@ 2017-08-14 1:36 ` Jun Gao
2017-08-14 19:47 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Jun Gao @ 2017-08-14 1:36 UTC (permalink / raw)
To: Wolfram Sang
Cc: Matthias Brugger, srv_heupstream, devicetree, linux-i2c,
linux-arm-kernel, linux-kernel, linux-mediatek
On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > + .max_num_msgs = 255,
> > + .max_write_len = 65535,
> > + .max_read_len = 65535,
> > + .max_comb_1st_msg_len = 65535,
> > + .max_comb_2nd_msg_len = 65535,
> > +};
>
> That looks like no quirks? Then just leave the quirks pointer below
> empty.
>
Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.
Jun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
2017-08-14 1:36 ` Jun Gao
@ 2017-08-14 19:47 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2017-08-14 19:47 UTC (permalink / raw)
To: Jun Gao
Cc: Matthias Brugger, srv_heupstream, devicetree, linux-i2c,
linux-arm-kernel, linux-kernel, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
On Mon, Aug 14, 2017 at 09:36:56AM +0800, Jun Gao wrote:
> On Sat, 2017-08-12 at 16:44 +0200, Wolfram Sang wrote:
> > > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > > + .max_num_msgs = 255,
> > > + .max_write_len = 65535,
> > > + .max_read_len = 65535,
> > > + .max_comb_1st_msg_len = 65535,
> > > + .max_comb_2nd_msg_len = 65535,
> > > +};
> >
> > That looks like no quirks? Then just leave the quirks pointer below
> > empty.
> >
> Compare to MT8173 i2c controller, MT7622 limits message numbers to 255.
I see. But you can safely drop all the length settings. The i2c core has
this comment in quirk handling:
/* Check if val is exceeding the quirk IFF quirk is non 0 */
IFF means "if and only if".
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-14 19:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-12 2:57 [PATCH v2 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-12 2:57 ` [PATCH v2 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-12 2:57 ` [PATCH v2 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
2017-08-12 14:44 ` Wolfram Sang
2017-08-14 1:36 ` Jun Gao
2017-08-14 19:47 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).