From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"lenb@kernel.org" <lenb@kernel.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk()
Date: Tue, 15 Aug 2017 16:19:50 +0000 [thread overview]
Message-ID: <1502813405.2042.153.camel@hpe.com> (raw)
In-Reply-To: <20170815155000.d57hwki5jbixjuj6@pd.tnic>
On Tue, 2017-08-15 at 17:50 +0200, Borislav Petkov wrote:
> On Tue, Aug 15, 2017 at 03:35:51PM +0000, Kani, Toshimitsu wrote:
> > ghes_edac instantiates an mci as a pseudo device representing a
> > GHES error source. Each error source associates with all DIMMs,
> > and may report errors independently. As ghes_edac is an GHES
> > error-reporting wrapper to edac, this abstraction makes sense.
>
> Bullshit.
>
> An MCI is a memory controller descriptor. That doesn't fit the GHES
> platform devices that get probed. GHES platform device != MCI. How
> many times do I need to say this for it to get through to you?
Right, but it has to be a "pseudo" device for ghes_edac. There is no
memory controller info available. A single mci does not make it a real
memory controller, either.
> > I do not see a problem in having counters for each GHES error
> > source.
>
> And the error counters of that "simulated" mci get incremented
> depending on which pointer gets passed in from GHES? More bullshit.
>
> > This is just statistics info, and ghes_edac does not expect any OS
> > action from the counters.
>
> So let me know if you don't want to do it and rather would prefer to
> pointlessly debate. I certainly don't want to waste my time debating.
Yes, ghes_edac refactoring like this should be considered a separate
item. My patchset is aimed to introduce a platform-check to attach
ghes_edac on supported platforms.
Thanks,
-Toshi
next prev parent reply other threads:[~2017-08-15 16:19 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 21:57 [PATCH v2 0/7] enable ghes_edac on selected platforms Toshi Kani
2017-08-03 21:57 ` [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani
2017-08-04 3:42 ` Borislav Petkov
2017-08-04 20:39 ` Kani, Toshimitsu
2017-08-05 5:12 ` Borislav Petkov
2017-08-07 14:49 ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani
2017-08-03 21:57 ` [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Toshi Kani
2017-08-04 3:44 ` Borislav Petkov
2017-08-04 20:49 ` Kani, Toshimitsu
2017-08-05 5:14 ` Borislav Petkov
2017-08-07 14:50 ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Toshi Kani
2017-08-04 4:05 ` Borislav Petkov
2017-08-04 21:02 ` Kani, Toshimitsu
2017-08-05 5:16 ` Borislav Petkov
2017-08-07 17:59 ` Kani, Toshimitsu
2017-08-11 9:04 ` Borislav Petkov
2017-08-14 15:57 ` Kani, Toshimitsu
2017-08-14 16:24 ` Borislav Petkov
2017-08-14 16:48 ` Kani, Toshimitsu
2017-08-14 17:05 ` Borislav Petkov
2017-08-14 17:52 ` Kani, Toshimitsu
2017-08-14 18:05 ` Borislav Petkov
2017-08-14 18:17 ` Kani, Toshimitsu
2017-08-14 18:35 ` Borislav Petkov
2017-08-14 19:02 ` Kani, Toshimitsu
2017-08-14 19:34 ` Borislav Petkov
2017-08-14 20:17 ` Kani, Toshimitsu
2017-08-14 20:39 ` Borislav Petkov
2017-08-15 15:35 ` Kani, Toshimitsu
2017-08-15 15:48 ` Luck, Tony
2017-08-15 15:53 ` Kani, Toshimitsu
2017-08-16 8:29 ` Borislav Petkov
2017-08-16 11:29 ` Borislav Petkov
2017-08-16 13:59 ` Steven Rostedt
2017-08-16 14:03 ` Borislav Petkov
2017-08-16 14:22 ` Steven Rostedt
2017-08-16 17:31 ` Borislav Petkov
2017-08-16 15:26 ` Kani, Toshimitsu
2017-08-16 16:42 ` Borislav Petkov
2017-08-16 17:28 ` Kani, Toshimitsu
2017-08-16 17:40 ` Borislav Petkov
2017-08-16 18:01 ` Kani, Toshimitsu
2017-08-17 21:08 ` Kani, Toshimitsu
2017-08-21 9:29 ` Borislav Petkov
2017-08-15 15:50 ` Borislav Petkov
2017-08-15 16:19 ` Kani, Toshimitsu [this message]
2017-08-03 21:57 ` [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Toshi Kani
2017-08-04 8:31 ` Borislav Petkov
2017-08-04 21:06 ` Kani, Toshimitsu
2017-08-05 5:37 ` Borislav Petkov
2017-08-07 14:54 ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Toshi Kani
2017-08-04 8:30 ` Borislav Petkov
2017-08-04 21:35 ` Kani, Toshimitsu
2017-08-05 5:44 ` Borislav Petkov
2017-08-07 14:55 ` Kani, Toshimitsu
2017-08-04 13:06 ` kbuild test robot
2017-08-04 15:21 ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 7/7] edac drivers: add MC owner check in init Toshi Kani
2017-08-04 8:39 ` Borislav Petkov
2017-08-04 21:48 ` Kani, Toshimitsu
2017-08-05 5:49 ` Borislav Petkov
2017-08-07 14:57 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502813405.2042.153.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).