linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hpe.com>
To: rjw@rjwysocki.net, bp@alien8.de
Cc: mchehab@kernel.org, tony.luck@intel.com, lenb@kernel.org,
	linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, Toshi Kani <toshi.kani@hpe.com>
Subject: [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner
Date: Thu,  3 Aug 2017 15:57:52 -0600	[thread overview]
Message-ID: <20170803215753.30553-7-toshi.kani@hpe.com> (raw)
In-Reply-To: <20170803215753.30553-1-toshi.kani@hpe.com>

Only a single edac driver can be enabled for EDAC MC.  When ghes_edac
is enabled, a regular edac driver for the CPU type / platform still
attempts to register itself and fails in edac_mc_add_mc().

Add edac_check_mc_owner() so that regular edac drivers can check
the owner of EDAC MC at the beginning of initialization.

Also change the owner check to string comparison from address check.

Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
---
 drivers/edac/edac_mc.c |   15 ++++++++++++++-
 drivers/edac/edac_mc.h |   12 ++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 4800721..52d8d5e 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -701,6 +701,19 @@ struct mem_ctl_info *edac_mc_find(int idx)
 }
 EXPORT_SYMBOL(edac_mc_find);
 
+/*
+ * Returns:
+ *	1 when EDAC MC is free or owned by the module name
+ *	0 when EDAC MC is owned by other module
+ */
+int edac_check_mc_owner(const char *mod_name)
+{
+	if (edac_mc_owner && strcmp(edac_mc_owner, mod_name))
+		return 0;
+
+	return 1;
+}
+EXPORT_SYMBOL(edac_check_mc_owner);
 
 /* FIXME - should a warning be printed if no error detection? correction? */
 int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci,
@@ -742,7 +755,7 @@ int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci,
 #endif
 	mutex_lock(&mem_ctls_mutex);
 
-	if (edac_mc_owner && edac_mc_owner != mci->mod_name) {
+	if (!edac_check_mc_owner(mci->mod_name)) {
 		ret = -EPERM;
 		goto fail0;
 	}
diff --git a/drivers/edac/edac_mc.h b/drivers/edac/edac_mc.h
index 5357800..0e95eba 100644
--- a/drivers/edac/edac_mc.h
+++ b/drivers/edac/edac_mc.h
@@ -128,6 +128,18 @@ struct mem_ctl_info *edac_mc_alloc(unsigned mc_num,
 				   unsigned sz_pvt);
 
 /**
+ *
+ * edac_check_mc_owner - Check the owner of EDAC MC
+ *
+ * @mod_name: pointer to the module name
+ *
+ * Returns:
+ *	1 when EDAC MC is free or owned by the module name
+ *	0 when EDAC MC is owned by other module
+ */
+extern int edac_check_mc_owner(const char *mod_name);
+
+/*
  * edac_mc_add_mc_with_groups() - Insert the @mci structure into the mci
  *	global list and create sysfs entries associated with @mci structure.
  *

  parent reply	other threads:[~2017-08-03 22:07 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 21:57 [PATCH v2 0/7] enable ghes_edac on selected platforms Toshi Kani
2017-08-03 21:57 ` [PATCH v2 1/7] ACPI / blacklist: add acpi_match_oemlist() interface Toshi Kani
2017-08-04  3:42   ` Borislav Petkov
2017-08-04 20:39     ` Kani, Toshimitsu
2017-08-05  5:12       ` Borislav Petkov
2017-08-07 14:49         ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 2/7] intel_pstate: convert to use acpi_match_oemlist() Toshi Kani
2017-08-03 21:57 ` [PATCH v2 3/7] ACPI / APEI: add OSC APEI bit check for ghes_edac Toshi Kani
2017-08-04  3:44   ` Borislav Petkov
2017-08-04 20:49     ` Kani, Toshimitsu
2017-08-05  5:14       ` Borislav Petkov
2017-08-07 14:50         ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Toshi Kani
2017-08-04  4:05   ` Borislav Petkov
2017-08-04 21:02     ` Kani, Toshimitsu
2017-08-05  5:16       ` Borislav Petkov
2017-08-07 17:59         ` Kani, Toshimitsu
2017-08-11  9:04           ` Borislav Petkov
2017-08-14 15:57             ` Kani, Toshimitsu
2017-08-14 16:24               ` Borislav Petkov
2017-08-14 16:48                 ` Kani, Toshimitsu
2017-08-14 17:05                   ` Borislav Petkov
2017-08-14 17:52                     ` Kani, Toshimitsu
2017-08-14 18:05                       ` Borislav Petkov
2017-08-14 18:17                         ` Kani, Toshimitsu
2017-08-14 18:35                           ` Borislav Petkov
2017-08-14 19:02                             ` Kani, Toshimitsu
2017-08-14 19:34                               ` Borislav Petkov
2017-08-14 20:17                                 ` Kani, Toshimitsu
2017-08-14 20:39                                   ` Borislav Petkov
2017-08-15 15:35                                     ` Kani, Toshimitsu
2017-08-15 15:48                                       ` Luck, Tony
2017-08-15 15:53                                         ` Kani, Toshimitsu
2017-08-16  8:29                                         ` Borislav Petkov
2017-08-16 11:29                                           ` Borislav Petkov
2017-08-16 13:59                                           ` Steven Rostedt
2017-08-16 14:03                                             ` Borislav Petkov
2017-08-16 14:22                                               ` Steven Rostedt
2017-08-16 17:31                                                 ` Borislav Petkov
2017-08-16 15:26                                           ` Kani, Toshimitsu
2017-08-16 16:42                                             ` Borislav Petkov
2017-08-16 17:28                                               ` Kani, Toshimitsu
2017-08-16 17:40                                                 ` Borislav Petkov
2017-08-16 18:01                                                   ` Kani, Toshimitsu
2017-08-17 21:08                                                     ` Kani, Toshimitsu
2017-08-21  9:29                                                       ` Borislav Petkov
2017-08-15 15:50                                       ` Borislav Petkov
2017-08-15 16:19                                         ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 5/7] ghes_edac: add platform check to enable ghes_edac Toshi Kani
2017-08-04  8:31   ` Borislav Petkov
2017-08-04 21:06     ` Kani, Toshimitsu
2017-08-05  5:37       ` Borislav Petkov
2017-08-07 14:54         ` Kani, Toshimitsu
2017-08-03 21:57 ` Toshi Kani [this message]
2017-08-04  8:30   ` [PATCH v2 6/7] EDAC: add edac_check_mc_owner() to check MC owner Borislav Petkov
2017-08-04 21:35     ` Kani, Toshimitsu
2017-08-05  5:44       ` Borislav Petkov
2017-08-07 14:55         ` Kani, Toshimitsu
2017-08-04 13:06   ` kbuild test robot
2017-08-04 15:21     ` Kani, Toshimitsu
2017-08-03 21:57 ` [PATCH v2 7/7] edac drivers: add MC owner check in init Toshi Kani
2017-08-04  8:39   ` Borislav Petkov
2017-08-04 21:48     ` Kani, Toshimitsu
2017-08-05  5:49       ` Borislav Petkov
2017-08-07 14:57         ` Kani, Toshimitsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803215753.30553-7-toshi.kani@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=bp@alien8.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).