* [PATCH 2/2] Removed unnecessary TTY ioctl callback
@ 2021-04-27 11:43 Samo Pogačnik
0 siblings, 0 replies; only message in thread
From: Samo Pogačnik @ 2021-04-27 11:43 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, Petr Mladek, Tetsuo Handa, linux-kernel
It turns-out, that TIOCCONS is completely handled in tty_io.c, so
the current local ioctl callback is of no real use.
Signed-off-by: Samo Pogačnik <samo_pogacnik@t-2.net>
---
drivers/char/ttyprintk.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
index 6f616cb7c..99364edf2 100644
--- a/drivers/char/ttyprintk.c
+++ b/drivers/char/ttyprintk.c
@@ -109,7 +109,6 @@ static int tpk_write(struct tty_struct *tty,
unsigned long flags;
int ret;
-
/* exclusive use of tpk_printk within this tty */
spin_lock_irqsave(&tpkp->spinlock, flags);
ret = tpk_printk(buf, count);
@@ -126,27 +125,6 @@ static int tpk_write_room(struct tty_struct *tty)
return TPK_MAX_ROOM;
}
-/*
- * TTY operations ioctl function.
- */
-static int tpk_ioctl(struct tty_struct *tty,
- unsigned int cmd, unsigned long arg)
-{
- struct ttyprintk_port *tpkp = tty->driver_data;
-
- if (!tpkp)
- return -EINVAL;
-
- switch (cmd) {
- /* Stop TIOCCONS */
- case TIOCCONS:
- return -EOPNOTSUPP;
- default:
- return -ENOIOCTLCMD;
- }
- return 0;
-}
-
/*
* TTY operations hangup function.
*/
@@ -176,7 +154,6 @@ static const struct tty_operations ttyprintk_ops = {
.close = tpk_close,
.write = tpk_write,
.write_room = tpk_write_room,
- .ioctl = tpk_ioctl,
.hangup = tpk_hangup,
};
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-04-27 11:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 11:43 [PATCH 2/2] Removed unnecessary TTY ioctl callback Samo Pogačnik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).