* [PATCH] net: ethernet: broadcom: Remove null check before kfree
@ 2017-08-26 20:17 Himanshu Jha
2017-08-28 22:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Himanshu Jha @ 2017-08-26 20:17 UTC (permalink / raw)
To: davem; +Cc: jarod, netdev, linux-kernel, Himanshu Jha
Kfree on NULL pointer is a no-op and therefore checking is redundant.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/ethernet/broadcom/sb1250-mac.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c
index 16a0f19..ecdef42 100644
--- a/drivers/net/ethernet/broadcom/sb1250-mac.c
+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c
@@ -1367,15 +1367,11 @@ static int sbmac_initctx(struct sbmac_softc *s)
static void sbdma_uninitctx(struct sbmacdma *d)
{
- if (d->sbdma_dscrtable_unaligned) {
- kfree(d->sbdma_dscrtable_unaligned);
- d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
- }
+ kfree(d->sbdma_dscrtable_unaligned);
+ d->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;
- if (d->sbdma_ctxtable) {
- kfree(d->sbdma_ctxtable);
- d->sbdma_ctxtable = NULL;
- }
+ kfree(d->sbdma_ctxtable);
+ d->sbdma_ctxtable = NULL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: broadcom: Remove null check before kfree
2017-08-26 20:17 [PATCH] net: ethernet: broadcom: Remove null check before kfree Himanshu Jha
@ 2017-08-28 22:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-28 22:53 UTC (permalink / raw)
To: himanshujha199640; +Cc: jarod, netdev, linux-kernel
From: Himanshu Jha <himanshujha199640@gmail.com>
Date: Sun, 27 Aug 2017 01:47:47 +0530
> Kfree on NULL pointer is a no-op and therefore checking is redundant.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-28 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-26 20:17 [PATCH] net: ethernet: broadcom: Remove null check before kfree Himanshu Jha
2017-08-28 22:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).