linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] i40iw: make some structures const
@ 2017-08-28 16:21 Bhumika Goyal
  2017-08-28 23:19 ` Doug Ledford
  2017-08-29 13:27 ` Shiraz Saleem
  0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-28 16:21 UTC (permalink / raw)
  To: julia.lawall, faisal.latif, shiraz.saleem, dledford, sean.hefty,
	hal.rosenstock, linux-rdma, linux-kernel
  Cc: Bhumika Goyal

Make some structures const as they are only used during a copy
operation.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/infiniband/hw/i40iw/i40iw_uk.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_uk.c b/drivers/infiniband/hw/i40iw/i40iw_uk.c
index 1060725..0aadb7a 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_uk.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_uk.c
@@ -912,7 +912,7 @@ enum i40iw_status_code i40iw_get_wqe_shift(u32 wqdepth, u32 sge, u32 inline_data
 	return 0;
 }
 
-static struct i40iw_qp_uk_ops iw_qp_uk_ops = {
+static const struct i40iw_qp_uk_ops iw_qp_uk_ops = {
 	.iw_qp_post_wr = i40iw_qp_post_wr,
 	.iw_qp_ring_push_db = i40iw_qp_ring_push_db,
 	.iw_rdma_write = i40iw_rdma_write,
@@ -926,14 +926,14 @@ enum i40iw_status_code i40iw_get_wqe_shift(u32 wqdepth, u32 sge, u32 inline_data
 	.iw_post_nop = i40iw_nop
 };
 
-static struct i40iw_cq_ops iw_cq_ops = {
+static const struct i40iw_cq_ops iw_cq_ops = {
 	.iw_cq_request_notification = i40iw_cq_request_notification,
 	.iw_cq_poll_completion = i40iw_cq_poll_completion,
 	.iw_cq_post_entries = i40iw_cq_post_entries,
 	.iw_cq_clean = i40iw_clean_cq
 };
 
-static struct i40iw_device_uk_ops iw_device_uk_ops = {
+static const struct i40iw_device_uk_ops iw_device_uk_ops = {
 	.iwarp_cq_uk_init = i40iw_cq_uk_init,
 	.iwarp_qp_uk_init = i40iw_qp_uk_init,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] i40iw: make some structures const
  2017-08-28 16:21 [PATCH] i40iw: make some structures const Bhumika Goyal
@ 2017-08-28 23:19 ` Doug Ledford
  2017-08-29 13:27 ` Shiraz Saleem
  1 sibling, 0 replies; 3+ messages in thread
From: Doug Ledford @ 2017-08-28 23:19 UTC (permalink / raw)
  To: Bhumika Goyal, julia.lawall, faisal.latif, shiraz.saleem,
	sean.hefty, hal.rosenstock, linux-rdma, linux-kernel

On Mon, 2017-08-28 at 21:51 +0530, Bhumika Goyal wrote:
> Make some structures const as they are only used during a copy
> operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] i40iw: make some structures const
  2017-08-28 16:21 [PATCH] i40iw: make some structures const Bhumika Goyal
  2017-08-28 23:19 ` Doug Ledford
@ 2017-08-29 13:27 ` Shiraz Saleem
  1 sibling, 0 replies; 3+ messages in thread
From: Shiraz Saleem @ 2017-08-29 13:27 UTC (permalink / raw)
  To: Bhumika Goyal
  Cc: julia.lawall, faisal.latif, dledford, sean.hefty, hal.rosenstock,
	linux-rdma, linux-kernel

On Mon, Aug 28, 2017 at 09:51:23PM +0530, Bhumika Goyal wrote:
> Make some structures const as they are only used during a copy
> operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Thanks!

Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-29 13:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 16:21 [PATCH] i40iw: make some structures const Bhumika Goyal
2017-08-28 23:19 ` Doug Ledford
2017-08-29 13:27 ` Shiraz Saleem

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).