* [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl.
@ 2017-08-28 23:32 Jonathan Whitaker
2017-08-29 6:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Whitaker @ 2017-08-28 23:32 UTC (permalink / raw)
To: gregkh
Cc: Jonathan Whitaker, Tobin C. Harding, sayli karnik, devel, linux-kernel
This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__'
style. These warnings were reported by checkpatch.pl.
Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
---
drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 9b28ee1..c0e91c3 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
unsigned char byte;
int ret;
- DPRINTK(5, "ks7010_sdio_probe()\n");
+ DPRINTK(5, "%s()\n", __func__);
priv = NULL;
netdev = NULL;
@@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
struct ks_sdio_card *card;
struct ks_wlan_private *priv;
- DPRINTK(1, "ks7010_sdio_remove()\n");
+ DPRINTK(1, "%s()\n", __func__);
card = sdio_get_drvdata(func);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl.
2017-08-28 23:32 [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl Jonathan Whitaker
@ 2017-08-29 6:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-08-29 6:23 UTC (permalink / raw)
To: Jonathan Whitaker; +Cc: devel, sayli karnik, linux-kernel
On Mon, Aug 28, 2017 at 05:32:39PM -0600, Jonathan Whitaker wrote:
> This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__'
> style. These warnings were reported by checkpatch.pl.
Please wrap your changelog text at 72 columns.
And your subject is very odd, please fix that up as well.
>
> Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 9b28ee1..c0e91c3 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> unsigned char byte;
> int ret;
>
> - DPRINTK(5, "ks7010_sdio_probe()\n");
> + DPRINTK(5, "%s()\n", __func__);
>
> priv = NULL;
> netdev = NULL;
> @@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
> struct ks_sdio_card *card;
> struct ks_wlan_private *priv;
>
> - DPRINTK(1, "ks7010_sdio_remove()\n");
> + DPRINTK(1, "%s()\n", __func__);
These lines can just be deleted entirely, we have in-kernel
functionality for tracing kernel function calls, no need to have special
debug lines just for that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-29 6:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 23:32 [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl Jonathan Whitaker
2017-08-29 6:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).