[PATCH] default implementation for of_find_all_nodes(...)

[PATCH] default implementation for of_find_all_nodes(...)

[Artur Lorincz]

Added default implementation for of_find_all_nodes(). This function is
used by board.c from the board module (drivers/staging/board).

Signed-off-by: Artur Lorincz <larturus@yahoo.com>
---
 include/linux/of.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 4a8a709..0a9c17a 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -865,6 +865,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag

 #define of_match_ptr(_ptr)	NULL
 #define of_match_node(_matches, _node)	NULL
+
+static inline struct device_node *of_find_all_nodes(struct device_node *prev)
+{
+	return NULL;
+}
 #endif /* CONFIG_OF */

 /* Default string compare functions, Allow arch asm/prom.h to override */
--
1.9.1

(no subject)

[Artur Lorincz]

Hello,

Could you please send me an update about this patch?

Thanks,
Artur

[PATCH] default implementation for of_find_all_nodes(...)

[Artur Lorincz]

Added default implementation for of_find_all_nodes(). This function is
used by board.c from the board module (drivers/staging/board).

Signed-off-by: Artur Lorincz <larturus@yahoo.com>
---
 include/linux/of.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 4a8a709..0a9c17a 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -865,6 +865,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag

 #define of_match_ptr(_ptr)	NULL
 #define of_match_node(_matches, _node)	NULL
+
+static inline struct device_node *of_find_all_nodes(struct device_node *prev)
+{
+	return NULL;
+}
 #endif /* CONFIG_OF */

 /* Default string compare functions, Allow arch asm/prom.h to override */
--
1.9.1

Re: [PATCH] default implementation for of_find_all_nodes(...)

[Frank Rowand]

Adding Rob Herring.

On 09/24/17 08:50, Artur Lorincz wrote:
> Added default implementation for of_find_all_nodes(). This function is
> used by board.c from the board module (drivers/staging/board).
> 
> Signed-off-by: Artur Lorincz <larturus@yahoo.com>
> ---
>  include/linux/of.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 4a8a709..0a9c17a 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -865,6 +865,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag
> 
>  #define of_match_ptr(_ptr)	NULL
>  #define of_match_node(_matches, _node)	NULL
> +
> +static inline struct device_node *of_find_all_nodes(struct device_node *prev)
> +{
> +	return NULL;
> +}
>  #endif /* CONFIG_OF */
> 
>  /* Default string compare functions, Allow arch asm/prom.h to override */
> --
> 1.9.1
> 
> 

(no subject)

[Artur Lorincz]

Hello,

When you get to it, could you please send me an update about this patch?

I believe the attached (trivial) patch should take less time to review then reading this message.
 
Thanks,
Artur

[PATCH] default implementation for of_find_all_nodes(...)

[Artur Lorincz]

Added default implementation for of_find_all_nodes(). This function is
used by board.c from the board module (drivers/staging/board).

Signed-off-by: Artur Lorincz <larturus@yahoo.com>
---
 include/linux/of.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 4a8a709..0a9c17a 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -865,6 +865,11 @@ static inline void of_property_clear_flag(struct property *p, unsigned long flag

 #define of_match_ptr(_ptr)	NULL
 #define of_match_node(_matches, _node)	NULL
+
+static inline struct device_node *of_find_all_nodes(struct device_node *prev)
+{
+	return NULL;
+}
 #endif /* CONFIG_OF */

 /* Default string compare functions, Allow arch asm/prom.h to override */
--
1.9.1

Re: [PATCH] default implementation for of_find_all_nodes(...)

[Rob Herring]

On Wed, Aug 30, 2017 at 1:32 PM, Artur Lorincz <larturus2@gmail.com> wrote:
> Added default implementation for of_find_all_nodes(). This function is
> used by board.c from the board module (drivers/staging/board).

Didn't even know we had this... The DT core already has some support
for something like this with "auxdata" that lets you attach DT nodes
to existing platform devices. Why doesn't that work?

In any case, you should just make this code depend on CONFIG_OF. When
there's only 3 other users of this function, that's a good sign we
don't want more. Searching thru all nodes is generally not the right
thing to do.

Rob

(no subject)

[Artur Lorincz]

Hello,

Thanks for checking the patch.

I missed the #else part of he CONFIG_OF #ifdef previously.

I made the code properly depend on CONFIG_OF now.

I am not familiar with this code base. When time allows I would like to contribute by  refactoring code in this area.

Let me know if you have specific ideas about what should change and how the code should be refactored.

Artur

[PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

[Artur Lorincz]

Signed-off-by: Artur Lorincz <larturus@yahoo.com>
---
 include/linux/of.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index cfc34117fc92..250ab4d55fac 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -538,6 +538,11 @@ const char *of_prop_next_string(struct property *prop, const char *cur);

 bool of_console_check(struct device_node *dn, char *name, int index);

+static inline struct device_node *of_find_all_nodes(struct device_node *prev)
+{
+	return NULL;
+}
+
 #else /* CONFIG_OF */

 static inline void of_core_init(void)
--
2.13.6

Re: [PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3383 bytes --]

Hi Artur,

[auto build test ERROR on v4.14-rc3]
[also build test ERROR on next-20170929]
[cannot apply to glikely/devicetree/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Artur-Lorincz/Added-default-implementation-for-of_find_all_nodes-This-function-is-used-by-board-c-from-the-board-module-drivers-staging-board/20171009-014559
config: i386-randconfig-i1-201741 (attached as .config)
compiler: gcc-4.8 (Debian 4.8.4-1) 4.8.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   In file included from include/linux/iio/iio.h:16:0,
                    from drivers/iio/pressure/ms5611_core.c:17:
>> include/linux/of.h:541:35: error: static declaration of 'of_find_all_nodes' follows non-static declaration
    static inline struct device_node *of_find_all_nodes(struct device_node *prev)
                                      ^
   include/linux/of.h:222:28: note: previous declaration of 'of_find_all_nodes' was here
    extern struct device_node *of_find_all_nodes(struct device_node *prev);
                               ^
--
   In file included from drivers//of/base.c:27:0:
>> include/linux/of.h:541:35: error: static declaration of 'of_find_all_nodes' follows non-static declaration
    static inline struct device_node *of_find_all_nodes(struct device_node *prev)
                                      ^
   include/linux/of.h:222:28: note: previous declaration of 'of_find_all_nodes' was here
    extern struct device_node *of_find_all_nodes(struct device_node *prev);
                               ^
>> drivers//of/base.c:280:21: error: redefinition of 'of_find_all_nodes'
    struct device_node *of_find_all_nodes(struct device_node *prev)
                        ^
   In file included from drivers//of/base.c:27:0:
   include/linux/of.h:541:35: note: previous definition of 'of_find_all_nodes' was here
    static inline struct device_node *of_find_all_nodes(struct device_node *prev)
                                      ^
--
   In file included from drivers/of/base.c:27:0:
>> include/linux/of.h:541:35: error: static declaration of 'of_find_all_nodes' follows non-static declaration
    static inline struct device_node *of_find_all_nodes(struct device_node *prev)
                                      ^
   include/linux/of.h:222:28: note: previous declaration of 'of_find_all_nodes' was here
    extern struct device_node *of_find_all_nodes(struct device_node *prev);
                               ^
   drivers/of/base.c:280:21: error: redefinition of 'of_find_all_nodes'
    struct device_node *of_find_all_nodes(struct device_node *prev)
                        ^
   In file included from drivers/of/base.c:27:0:
   include/linux/of.h:541:35: note: previous definition of 'of_find_all_nodes' was here
    static inline struct device_node *of_find_all_nodes(struct device_node *prev)
                                      ^

vim +/of_find_all_nodes +541 include/linux/of.h

   540	
 > 541	static inline struct device_node *of_find_all_nodes(struct device_node *prev)
   542	{
   543		return NULL;
   544	}
   545	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27524 bytes --]

Re: [PATCH] Added default implementation for of_find_all_nodes(). This function is used by board.c from the board module (drivers/staging/board).

[Rob Herring]

On Sun, Oct 8, 2017 at 11:28 AM, Artur Lorincz <larturus2@gmail.com> wrote:
> Signed-off-by: Artur Lorincz <larturus@yahoo.com>
> ---
>  include/linux/of.h | 5 +++++
>  1 file changed, 5 insertions(+)

I replied to you on the previous version[1]. Why are you sending this again?

Rob

[1] https://lkml.org/lkml/2017/10/6/805