* [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
@ 2017-08-30 2:57 Jonathan Whitaker
2017-08-30 9:55 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Whitaker @ 2017-08-30 2:57 UTC (permalink / raw)
To: gregkh
Cc: Jonathan Whitaker, Tobin C. Harding, sayli karnik, devel, linux-kernel
It is prefered to use '"%s...", __func__ instead of function names for
logging. This commit replaces hardcoded function name strings to the
more preferred '"%s...", __func__' style. These warnings were reported
by checkpatch.pl.
Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
Changes in v2:
- Wrapped the changelog text to 72 columns.
- Fixed the commit subject to be more clear.
---
drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 9b28ee1..c0e91c3 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
unsigned char byte;
int ret;
- DPRINTK(5, "ks7010_sdio_probe()\n");
+ DPRINTK(5, "%s()\n", __func__);
priv = NULL;
netdev = NULL;
@@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
struct ks_sdio_card *card;
struct ks_wlan_private *priv;
- DPRINTK(1, "ks7010_sdio_remove()\n");
+ DPRINTK(1, "%s()\n", __func__);
card = sdio_get_drvdata(func);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
2017-08-30 2:57 [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings Jonathan Whitaker
@ 2017-08-30 9:55 ` Dan Carpenter
2017-08-31 4:24 ` [PATCH v3] " Jonathan Whitaker
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-08-30 9:55 UTC (permalink / raw)
To: Jonathan Whitaker; +Cc: gregkh, devel, sayli karnik, linux-kernel
On Tue, Aug 29, 2017 at 08:57:34PM -0600, Jonathan Whitaker wrote:
> It is prefered to use '"%s...", __func__ instead of function names for
> logging. This commit replaces hardcoded function name strings to the
> more preferred '"%s...", __func__' style. These warnings were reported
> by checkpatch.pl.
>
> Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
>
> Changes in v2:
> - Wrapped the changelog text to 72 columns.
> - Fixed the commit subject to be more clear.
> ---
Put the Changelog under the --- cut off line.
> drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 9b28ee1..c0e91c3 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> unsigned char byte;
> int ret;
>
> - DPRINTK(5, "ks7010_sdio_probe()\n");
> + DPRINTK(5, "%s()\n", __func__);
Just delete both the printks. You can get the same information with
ftrace.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
2017-08-30 9:55 ` Dan Carpenter
@ 2017-08-31 4:24 ` Jonathan Whitaker
2017-08-31 8:07 ` Dan Carpenter
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Whitaker @ 2017-08-31 4:24 UTC (permalink / raw)
To: dan.carpenter
Cc: Jonathan Whitaker, Greg Kroah-Hartman, Tobin C. Harding,
sayli karnik, devel, linux-kernel
Removed printk statements for debugging. The same information can be
acquired via ftrace, so these print statements are uneccessary.
Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
---
Changes in v2:
- Wrapped the changelog text to 72 columns.
- Fixed the commit subject to be more clear.
Changes in v3:
- Removed the printk statements altogether. This information is available
via ftrace.
- Updated commit message.
---
drivers/staging/ks7010/ks7010_sdio.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 9b28ee1..8cfdff1 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -834,8 +834,6 @@ static int ks7010_sdio_probe(struct sdio_func *func,
unsigned char byte;
int ret;
- DPRINTK(5, "ks7010_sdio_probe()\n");
-
priv = NULL;
netdev = NULL;
@@ -1008,8 +1006,6 @@ static void ks7010_sdio_remove(struct sdio_func *func)
struct ks_sdio_card *card;
struct ks_wlan_private *priv;
- DPRINTK(1, "ks7010_sdio_remove()\n");
-
card = sdio_get_drvdata(func);
if (!card)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
2017-08-31 4:24 ` [PATCH v3] " Jonathan Whitaker
@ 2017-08-31 8:07 ` Dan Carpenter
2017-08-31 13:48 ` Jonathan Whitaker
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2017-08-31 8:07 UTC (permalink / raw)
To: Jonathan Whitaker; +Cc: devel, Greg Kroah-Hartman, sayli karnik, linux-kernel
Thanks!
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
2017-08-31 8:07 ` Dan Carpenter
@ 2017-08-31 13:48 ` Jonathan Whitaker
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Whitaker @ 2017-08-31 13:48 UTC (permalink / raw)
To: Dan Carpenter; +Cc: devel, Greg Kroah-Hartman, sayli karnik, linux-kernel
Thank you for all of the feedback!
On Thu, Aug 31, 2017 at 2:07 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Thanks!
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-31 13:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 2:57 [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings Jonathan Whitaker
2017-08-30 9:55 ` Dan Carpenter
2017-08-31 4:24 ` [PATCH v3] " Jonathan Whitaker
2017-08-31 8:07 ` Dan Carpenter
2017-08-31 13:48 ` Jonathan Whitaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).